Whats up...
This code works in converting the word to uppercase, but it often puts garbage characters at the end of the converted word (upper). Is this occurring because text is not the full length of the array and so upper still displays those chars? How would I fix this?Code:int a, b; char text[25]; char upper[25]; for (a = 0, b = strlen(text); a < b; a++) { if (isalpha(word[a])) upper[a] = toupper(text[a]); else upper[a] = text[a]; }
Thank you all
Not so much that text is not the full length of the array, but that text does not have a null terminator '\0' where it should.
How do I put that in?
After the for loop, a will still represent the next character in text, so:Originally Posted by pollypocket4eva
Code:} // end of for loop text[a]='\0'
C programming resources:
GNU C Function and Macro Index -- glibc reference manual
The C Book -- nice online learner guide
Current ISO draft standard
CCAN -- new CPAN like open source library repository
3 (different) GNU debugger tutorials: #1 -- #2 -- #3
cpwiki -- our wiki on sourceforge
After the loop terminates, of course.
Code:#include <cmath> #include <complex> bool euler_flip(bool value) { return std::pow ( std::complex<float>(std::exp(1.0)), std::complex<float>(0, 1) * std::complex<float>(std::atan(1.0) *(1 << (value + 2))) ).real() < 0; }
Yes --- thank you!
is unnecessarily complicated. toupper is only going to change things that are different between upper and lower case, which is (generally speaking) only alpha characters. So the if-statement isn't needed - just call toupper on every character in the string. It will be about the same speed as isalpha + upper[a] = text[a], but shorter and simpler to read.Code:if (isalpha(word[a])) upper[a] = toupper(text[a]); else upper[a] = text[a];
Also, if you wish (I'm not at all saying you should, but it's good to recognize that it's an alternative), set b to strlen(text)+1, and you would automatically copy the zero that terminates the string.
--
Mats
Compilers can produce warnings - make the compiler programmers happy: Use them!
Please don't PM me for help - and no, I don't do help over instant messengers.
