> countryList[i] = (char*) calloc (strlen(tempAry), sizeof(char));
1. Don't cast the result of malloc/calloc etc - see the FAQ for why.
2. You don't count the \0, so the strcpy which follows is instant buffer overflow.
> countryList[i] = (char*) calloc (strlen(tempAry), sizeof(char));
> countryList[numCountries] = '\0';
When you exit the loop, i == numCountries, so this is just a memory leak.
'\0' silently becomes NULL with this assignment.
Edit:
Bah, way way too late - the party is over.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
It does, but strlen counts that so that's fine. What strlen doesn't count is the \0 that gets written on as well.Originally Posted by RaDeuX
Excuse me!!
Copying a NULL terminated string requires allocating length for the nul char at the end as well. The code needs to be:
Note the required +1.Code:countryList[i] = calloc(strlen(tempAry)+1, sizeof(char));
My homepage
Advice: Take only as directed - If symptoms persist, please see your debugger
Linus Torvalds: "But it clearly is the only right way. The fact that everybody else does it some other way only means that they are wrong"
