Thread: Can't dump 2D arrays

Two things just from glancing through the file:
1) Don't use strcpy, it's not safe!
2) You mean "free" a 2D array. "Dumping" generally refers to outputting to the screen.

QuantumPete

Error 1 error C3861: 'malloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 78
Warning 2 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 79
Error 3 error C3861: 'realloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 81
Error 4 error C3861: 'malloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 88
Warning 5 warning C4018: '<' : signed/unsigned mismatch g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 90
Error 6 error C3861: 'realloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 93
Error 7 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 95
Error 8 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 96
Error 9 error C3861: 'malloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 115
Error 10 error C3861: 'malloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 116
Error 11 error C3861: 'malloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 119
Warning 12 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 120
Warning 13 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 122
Error 14 error C3861: 'realloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 124
Error 15 error C3861: 'malloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 127
Error 16 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 141
Warning 17 warning C4018: '<' : signed/unsigned mismatch g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 150
Error 18 error C3861: 'realloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 154
Error 19 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 160
Error 20 error C3861: 'realloc': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 166
Error 21 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 172
Error 22 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 178
Error 23 error C3861: 'free': identifier not found g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 184
Warning 24 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 212

...and...

Warning 1 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 79
Warning 2 warning C4018: '<' : signed/unsigned mismatch g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 90
Warning 3 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 120
Warning 4 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 122
Warning 5 warning C4018: '<' : signed/unsigned mismatch g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 150
Warning 6 warning C4101: 'value' : unreferenced local variable g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 110
Warning 7 warning C4244: '=' : conversion from 'int' to 'char', possible loss of data g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 212
Warning 8 warning C4101: 'j' : unreferenced local variable g:\w00t\Visual Studio 2008\Projects\Temp\Temp3.cpp 221
Warning 9 warning C4706: assignment within conditional expression g:\w00t\visual studio 2008\projects\temp\temp3.cpp 112
Warning 10 warning C4706: assignment within conditional expression g:\w00t\visual studio 2008\projects\temp\temp3.cpp 76

I will leave it as an exercise for you to fix those warnings and errors.

> I will leave it as an exercise for you to fix those warnings and errors.
You mean YOUR warnings and errors.
You saved it as a .cpp file, when the OP posted a .c file.

That gets rid of all the malloc cast stuff right off the bat.

However, Farrapo needs to include stdlib.h and then remove all the spurious casts of malloc et al.

> str=(char*)realloc(str,strlen(str)+2);
1. str starts off as 1 UNINITIALISED char, so who knows what strlen is going to return.
2. If realloc fails, you leak memory.
Always do
temp = realloc( str,strlen(str)+2) ); if ( temp != NULL ) str = temp;
// else do some tidying up

> sprintf(str,"%s%c",str,ch);
There are FAR better ways of appending a char to a string.
And they don't invoke undefined behaviour.

In general, consider a few more utility functions to replace some of the code you keep repeating.

> Are you sure these stuff are the cause?
No idea - we advise.

There are many errors in the code, some more serious than others. It's not like we could come up with a complete list right away anyway, since what you do to fix some problems may have implications on future discussions.

Here's a biggie:
int n = dbsection("db.ini",0,NULL);

int dbsection(const char *filename,int sec,char *out)

strcpy(out,str2);

Do you have a debugger?
With a debugger, a crash puts you back in the debugger, with the instruction pointer pointing at the instruction (or line of code) causing the problem. From there you can back-track to find out how it got into that situation.

> Did you guys make it work?
Nope, I just read the code and found some things wrong with it.

Besides, us removing all the bugs wouldn't teach you anything as such. It's your code, all we can do is tell you how to fix it.

Consider, for your next program, writing the program in stages

Also, if you've changed the code, then you need to post it again. It's all very well describing what you've done, but we see with all to regularity that it's somehow different from what we imagined it would be like.

Originally Posted by Salem

> I will leave it as an exercise for you to fix those warnings and errors.
You mean YOUR warnings and errors.
You saved it as a .cpp file, when the OP posted a .c file.

Perhaps I did, but even so, those errors and warnings are legitimate. I would not post them if I did not think they were valid.
Even though a C compiler might give a warning, it might still be a programming error.

That gets rid of all the malloc cast stuff right off the bat.

True, it would work without, but I was not the one who added them.

However, Farrapo needs to include stdlib.h and then remove all the spurious casts of malloc et al.

The failure to include the correct header was one of the errors, another reason I compiled it as C++.

Well uh, no. I compiled it as C++ only to iron out problems in the code and present them (plus I do tend to compile C code as C++ to add C++ debugging techniques to code sometimes).
Perhaps they would have warnings instead of errors if compiled as C, but hey, regardless of that, they should all be fixed, if possible.

Originally Posted by citizen

>> Perhaps they would have warnings instead of errors if compiled as C, but hey, regardless of
>> that, they should all be fixed, if possible.
That's your personal preference and not important to the language being used, thus my point. There is no reason to assume the OP wanted C compiled as C++.

If I compiled that as C, I would have gotten a warning on the calling of malloc instead of an error. Not much else of a difference.
Is that a bad thing?

>> (plus I do tend to compile C code as C++ to add C++ debugging techniques to code sometimes).
As far as I'm aware, C and C++ have the same debugging features in step, next, breakpoints, watches, et cetera for any given professional IDE.

Forgive me. I meant things such as replacing arrays with boost::array to get assertions and such things.

No, it was an attack on the reply, I gather
But I figured it was alright to post what output I got from compiling it as C++ (after filtering out certain things that are C++-related, of course). Perhaps I should just have compiled as C and posted the output or removed the indication that it was compiled as C++ (removing the filenames?)?