help in my program on linked lists

[zerozerozero]

An encoded file will be decoded by the program using a key input from the user. This key is a sequence of numbers that will scramble the message in the file into its appropriate order.

I have to use linked lists for this. I already started it, but I can't seem to find a correct way to jumble the words and display them correctly.

#include <stdio.h>
#include <string.h>

typedef struct _node_{
     char word[30];
     struct _node_ *pPtr_word;
     }node_t;
     
int main(void)
{
FILE *pInput, *pOutput;
int a, b, count, num, group_num, counter, data[10], i, j;
node_t node[100]; 
node_t *pPtr;

     pInput=fopen("input.txt","r");
     if(pInput==NULL){
     printf("Error: can't open file.\n");
     return 1;
     }
     else{
          if('\n')
          count=count++;
          for(a=0;a<count+1;a++)
          fgets(node[a].word,30,pInput);
          for(b=0;b<count+1;b++)
          printf("%s\n", node[b].word);
     }

     printf("Enter number of numbers for key sequence: ");
     scanf("%d", &num);
     printf("Enter key sequence: ");     
     for(counter=0;counter<num;counter++)
     scanf("%d", &data[counter]);

     group_num=((count+1)/num);

     for(i=0;i<group_num;i++)
     for(j=0,pPtr=node;j<num-1;j++,pPtr++)
     node[(data[j]-1)+num*i].pPtr_word=&node[((data[j]-1)+num*i)+1];
     pPtr->pPtr_word=NULL;

     for(pPtr->word;pPtr!=NULL;pPtr=pPtr->pPtr_word)
     printf("%s", pPtr->word);

getchar();
getchar();

     return 0; 
}

Example, the file input [from a text file] is-- brown quick The over jumped fox dog. lazy the
Then the key sequence entered would be 321
The output should be-- The quick brown fox jumped over the lazy dog.

Also, for displaying my linked list, it seems like it doesn't traverse the whole thing.

Please help me out

[matsp]

Your indentation is pretty bad.

         if('\n')
          count=count++;

What do YOU think this does - I'm convinced what it ACTUALLY does isn't what you THINK it does, so I'd be interested in understanding what you meant by it.

count = count++ is superfluous, and may well result in incorrect results (because count is set to count, then the original count is incremented (but probably lost).

The part with if ('\n') is always true - because '\n' is non-zero - it is the same as "if (true)".

--
Mats

[zerozerozero]

Your indentation is pretty bad.

         if('\n')
          count=count++;

What do YOU think this does - I'm convinced what it ACTUALLY does isn't what you THINK it does, so I'd be interested in understanding what you meant by it.

count = count++ is superfluous, and may well result in incorrect results (because count is set to count, then the original count is incremented (but probably lost).

The part with if ('\n') is always true - because '\n' is non-zero - it is the same as "if (true)".

--
Mats

I'm trying to get the words in the file by line. I can't get it by word.
In my text file, it looks like this:
brown
quick
The
over
jumped
fox
dog.
lazy
the

[matsp]

So, let me understand this: You have written a bunch of code - you have no idea what any of it does, and you want one of us to fix it up for you?

I have identified two lines that ABSOLUTELY doesn't do anything meaningfull - if you at least explain what you want those two lines to do, maybe we can help you get to that point.

here is another two lines that are really bad:

int a, b, count, num, group_num, counter, data[10], i, j;
node_t node[count];

count is not initialized, so it may be absolutely anything: -1, 4711, 16231021, 5 or whatever other number between -2 billion and +2 billion - then you create an array of nodes based on that. How many nodes do you actually want to have?

Also, on the other lines I pointed to, you are using count, which has still not been given a value - so it is still some completely random value - between negative and positive 2 billion.

--
Mats

--
Mats

[MK27]

It seems to me like using a linked list for this is like using seat belts on an escalator -- not really impossible, but kind of silly.

Does your prof also make you put your name on assignment covers twice (once on the right margin, and once in the center)?

[zerozerozero]

count is used to get the number of words which I might be able to use later on

I changed that array of nodes to a limit of 100..

the for loop is used to link them.. the array index is my initial "formula" for the correct sequence to be linked [but the formula is not perfect yet]

the next for loop is used to display, but it doesn't display the whole linked list.. it displays only a word.

I have been trying to do this for a week already, so I am asking help now because I am desperate. I'm not an expert programmer, so I still have lots of loopholes, hoping that someone could help out because I'm running out of time.

[zerozerozero]

count is used to get the number of words which I might be able to use later on

I changed that array of nodes to a limit of 100..

the for loop is used to link them.. the array index is my initial "formula" for the correct sequence to be linked [but the formula is not perfect yet]

the next for loop is used to display, but it doesn't display the whole linked list.. it displays only a word.

I have been trying to do this for a week already, so I am asking help now because I am desperate. I'm not an expert programmer, so I still have lots of loopholes, hoping that someone could help out because I'm running out of time.

[master5001]

I am going to fix the indentation first so all of us can see your code clearly:

ORIGINAL CODE!!

#include <stdio.h>
#include <string.h>

typedef struct _node_{
  char word[30];
  struct _node_ *pPtr_word;
}node_t;
     
int main(void)
{
  FILE *pInput, *pOutput;
  int a, b, count, num, group_num, counter, data[10], i, j;
  node_t node[100] = {0}; 
  node_t *pPtr;

  pInput=fopen("input.txt","r");

  if(pInput==NULL){
    printf("Error: can't open file.\n");
    return 1;
  }
  else{
    if('\n')
      count=count++;

    for(a=0;a<count+1;a++)
      fgets(node[a].word,30,pInput);

    for(b=0;b<count+1;b++)
      printf("&#37;s\n", node[b].word);
  }

  printf("Enter number of numbers for key sequence: ");
  scanf("%d", &num);
  printf("Enter key sequence: ");     

  for(counter=0;counter<num;counter++)
    scanf("%d", &data[counter]);

  group_num=((count+1)/num);

  for(i=0;i<group_num;i++)
     for(j=0,pPtr=node;j<num-1;j++,pPtr++)
       node[(data[j]-1)+num*i].pPtr_word=&node[((data[j]-1)+num*i)+1];

  pPtr->pPtr_word=NULL;

  for(pPtr->word;pPtr!=NULL;pPtr=pPtr->pPtr_word)
    printf("%s", pPtr->word);

  getchar();
  getchar();

  return 0; 
}

[master5001]

I don't know dude... the way this parses is VERY screwy. It calls an entire line a word. Which may be how your input file is, but who would type like that?