Thread: Adding 2 Values in 'if else'

I'm trying to write a program which prints a bill given certain input. I'm trying to add the two values for billPeak and billOff but whenever I run my program the last part gives a crazy number. All the other parts run ok. Anyone know where i'm going wrong?

Code:

#include <stdio.h>


int main()
{
	char code;
	int account,consump, peak, off, billPeak, billOff;
	double bill=0;

	
	printf("Enter account no.: ");
	scanf("%d", &account);
	printf("Enter consumption in kwh: ");
	scanf("%d", &consump);
	printf("Code: ");
	
	while((code=getchar()) && code == '\n');
	

	if (code=='R' || code=='r' ){
		printf("\n\nAccount no: %d\n", account);
		bill = consump * 6.052;
		printf("Bill %f\n", bill);
	}


	else if (code=='C' || code=='c' ){
		printf("\n\nAccount no: %d\n", account);
		if (consump<=1000)
			bill = 60;
		
		else bill = (((consump-1000)*0.045)+60);
		printf("Bill %f\n", bill);
	}


	else if (code=='I' || code=='i' ){
		printf("Enter Peak: ");
		scanf("%d", &peak);
			if (peak<=1000)
			billPeak = 76;
			else billPeak = (((peak-1000)*0.045)+60);
		printf("Enter Off Peak: ");
		scanf("%d", &off);
			if (off<=1000)
			billOff = 40;
			else billOff = (((off-1000)*0.028)+40);
		
		printf("\n\nAccount no: %d\n", account);
		printf("Bill %f\n", billPeak+billOff);
	}
	return 0;
}

billPeak and billOff need to be doubles too.

Missed that. Thanks. But even when I do that I keep hetting 116.000 no matter what values I enter for peak and off peak??

Using your code with the fix, I get this:

Code:

$ ./temp
Enter account no.: 147
Enter consumption in kwh: 2000
Code: I
Enter Peak: 1500
Enter Off Peak: 500


Account no: 147
Bill 122.500000

Well 76 + 40 = 116 a lot.

I keep getting 116. I can't figure out how yours worked ok with the same code

Double check the code you have now vs. what you posted, and see what's different.

Because he inputted values that are both greater than 1000. Otherwise, as your program states, you get 76 + 40. You sure you wrote your own code?

Definitely wrote my own code. I've been at it for a while now and it's driving me mad. I'm just looking for some help where i'm going wrong.

I've had a look at my code and i've changed billOff and billPeak to be doubles, put some braces into my last if/else (don't think it matters in this case). There's definitely something up in this if/else though I can't see it

Code:

#include <stdio.h>


int main()
{
	char code;
	double account,consump, bill, peak, off, billPeak, billOff;

	
	printf("Enter account no.: ");
	scanf("&#37;d", &account);
	printf("Enter consumption in kwh: ");
	scanf("%d", &consump);
	printf("Code: ");
	
	while((code=getchar()) && code == '\n');
	

	if (code=='R' || code=='r' ){
		printf("\n\nAccount no: %d\n", account);
		bill = consump * 6.052;
		printf("Bill %f\n", bill);
	}


	else if (code=='C' || code=='c' ){
		printf("\n\nAccount no: %d\n", account);
		if (consump<=1000)
			bill = 60;
		
		else bill = (((consump-1000)*0.045)+60);
		printf("Bill %f\n", bill);
	}


	else if (code=='I' || code=='i' ){
		printf("Enter Peak: ");
		scanf("%d", &peak);
			if (peak<=1000)
			{
			billPeak = 76;
			}
			else 
			{billPeak = (((peak-1000)*0.045)+60);
			}
		printf("Enter Off Peak: ");
		scanf("%d", &off);
			if (off<=1000)
			{billOff = 40;
			}
			else {billOff = (((off-1000)*0.028)+40);
			}
		

		printf("\n\nAccount no: %d\n", account);
		printf("Bill %f\n", billPeak+billOff);
	}
	return 0;
}

If you type in 1500 and 500 as I did, and don't get the answer I did, then you didn't actually compile this code.

I don't know how many times I have to say it: 76 + 40 = 116.

Well since you wrote the code you should have remembered that you hard coded

billPeak = 76;
and
billOff = 40;
In the cases where the user enters in numbers less than 1000.