Thread: File Server Help

Well.. im triying to do a fileserver that handles multiple connections.. but i'm having lots of problems.. i really need a hand.. here's the code
I have simplified the code so it would be more easy to execute withouth having problems..

This is the client..

Code:

#include <stdio.h>
#include <netdb.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <string.h>
#include <sys/stat.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <arpa/inet.h>
#define DEST_PORT 3000
#define DEST_IP 127.0.0.1

int i;
//password check has been removed due it always says its correct &#172;&#172; //ignore this
int passwdcheck(int *sock) {
char password[]="lol";
char i;
char buff[30];
recv(*sock, buff, sizeof(buff), 0);
if(!strcmp(password, buff)) {
send(*sock, 0, sizeof(i), 0);
return 0;
}
else {
send(*sock, 1, sizeof(i), 0);
return 1;
}
}

long fsize(const char *const name)
{
struct stat stbuf;
if(stat(name, &stbuf) == -1)
return -1; // The file could not be accessed.
return stbuf.st_size;
}

void sendfile(int *sock) {
FILE *file;
int parts;
char haslastpart;
int lastpart;
char filepath[30];
char filesend[]="filetransfer";
printf("Filename");
scanf( "&#37;s", filepath );
send(*sock, filesend, sizeof(filesend), 0);
if(file=fopen(filepath,"rb")) {
  long filesize;
  filesize = fsize(filepath);
  if(filesize>=1048576) {
    parts=filesize/1048576;
    if(lastpart=filesize%1048576 != 0) { //ignore this
    haslastpart=1;  //ignore this
    ++parts;  //ignore this
    send(*sock, parts, sizeof(parts), 0);
    }
    else {
      send(*sock, parts, sizeof(parts), 0);
    }
  }
  else {
    int fileparts=1;
    send(*sock, fileparts, sizeof(fileparts), 0);
  }
  for(i=0;i<parts;i++) {
  char *buff;
  fread(buff, 1048576, 1, file);
  send(*sock, buff, 1048576, 0);
  }
}

}

int main() {
char password[]="lol";
struct sockaddr_in serveraddr, dest_addr;
int sock; //sock
/* client buffer */
char buf[1024]; //mucho buffer papa
int nbytes;
/* for setsockopt() */
int addrlen;
int i, j;
int yes = 1;
/* creating socket*/
if((sock = socket(AF_INET, SOCK_STREAM, 0)) == -1) {
perror("Server-socket() error lol!");
exit(1);
}
printf("Socket Creado\n");
/* testing if addr is beeing used */
if(setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof(int)) == -1) {
perror("Server-setsockopt() error lol!");
exit(1);
}
printf("test reusando adress\n");
dest_addr.sin_family = AF_INET;          // host byte order
dest_addr.sin_port = htons(DEST_PORT);   // short, network byte order
dest_addr.sin_addr.s_addr = inet_addr("127.0.0.1");
memset(dest_addr.sin_zero, '\0', sizeof dest_addr.sin_zero);

printf("Conectando\n");
if(!connect(sock, (struct sockaddr *)&dest_addr, sizeof(dest_addr))) { 
exit(1);
}
printf("Conectado..\n");
send(sock, password, strlen(password), 0);
int buf2;
//password check has been removed due it always says its correct &#172;&#172;
printf("Password ok..\n");
while(1) {
//this loop is not beeing executed =S
  printf("Sendifle\n");
  sendfile(&sock);
}

}

This is the server..

Code:

#include <stdio.h>
#include <netdb.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <string.h>
#include <sys/stat.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <arpa/inet.h>
#define QUEQUE_SIZE 100
#define LOCALPORT 3000

struct settings {
        char password[20];
        int port;
        } settings;

int passwdcheck(int *sock) {
char password[]="lol";
char i;
char buff[30];
recv(*sock, buff, sizeof(buff), 0);
if(!strcmp(password, buff)) {
send(*sock, 0, sizeof(i), 0);
return 0;
}
else {
send(*sock, 1, sizeof(i), 0);
return 1;
}
}

void recievefile(int *sock) {
FILE *file;
char filepath[]="mothe........a.txt";
int fileparts;
char i;
recv(*sock, fileparts, sizeof(fileparts), 0);
if(file=fopen(filepath,"ab")) {
  for(i=0;i<fileparts;i++) {
     char *buff;
     recv(*sock, buff, 1048576, 0);
     if(fwrite(buff, 1048576, 1, file) == -1) {
       printf("Error writing file %s in part: %i", filepath, &i); //prototipo
     }
     else {
       //Archivo recibido en..
     }
  fclose(file);
  }
}
else {

}
}

int main() {
fd_set master, read_fds;
struct sockaddr_in serveraddr, clientaddr;
int fdmax; //numero maximo de file descriptor
int listener; //sock a listenear
int newfd; //sock nuevo al accept()

/* client buffer */
char buf[1024]; //mucho buffer
int nbytes;
/* for setsockopt() */
int yes = 1;
int addrlen;
int i, j;
/* clearing the sets */
FD_ZERO(&master);
FD_ZERO(&read_fds);
/* creating socket listener for listen() */
if((listener = socket(AF_INET, SOCK_STREAM, 0)) == -1) {
perror("Server-socket() error lol!");
exit(1);
}
printf("Socket Creado\n");
/* testing if addr is beeing used */
if(setsockopt(listener, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof(int)) == -1) {
perror("Server-setsockopt() error lol!");
exit(1);
}
/* bind data */
serveraddr.sin_family = AF_INET;
serveraddr.sin_addr.s_addr = INADDR_ANY;
serveraddr.sin_port = htons(LOCALPORT);
memset(&(serveraddr.sin_zero), '\0', 8);
/* bind */
if(bind(listener, (struct sockaddr *)&serveraddr, sizeof(serveraddr)) == -1) {
perror("Server-bind() error lol!");
exit(1);
}
printf("Port 3000 bindeado\n");
/* listenando */
if(listen(listener, 10) == -1) {
perror("Server-listen() error lol!");
exit(1);
}
printf("Socket Listeneando\n");
/*adding listener to the master set  */
FD_SET(listener, &master);

fdmax = listener;
/* loop */
for(;;) {
/* copy */
read_fds = master;
/* starts select */
  if(select(fdmax+1, &read_fds, NULL, NULL, NULL) == -1) {
  perror("Server-select() error lol!");
  exit(1);
  }
  printf("Select starteado\n");
  for(i = 0; i <= fdmax; i++) {
    if(FD_ISSET(i, &read_fds)) {
      if(i == listener) { /* nueva conexion */
        addrlen = sizeof(clientaddr);
        if((newfd = accept(listener, (struct sockaddr *)&clientaddr, &addrlen)) == -1) {
          perror("Server-accept() error lol!");
        }
        printf("Nueva conexion.. testeando pass\n");
      if(passwdcheck(&newfd) == 1) {
        FD_SET(newfd, &master);
        printf("Password correcta\n");
        if(newfd > fdmax){ /* keep track of the maximum */
          fdmax = newfd;
        }
      }
      else {
        close(newfd);
        printf("Password incorrecta\n");
      }
    }
    else {
      if((nbytes = recv(i, buf, sizeof(buf), 0)) <= 0) { /* deals with connections */
        if(nbytes == 0) {
          close(i);
          FD_CLR(i, &master);
          printf("Conexion perdida\n");
        }
        else {
          recievefile(&i);
        }
      }
    }

  }
}
}
return 0;
/* fin funcion */
}