Thread: Matching numbers

Just to give everyone the satisfaction of how bad this code is:

Code:

#include <stdio.h>

void readticket(FILE* fin, int ticket[]);
int lottery(int ticket[], int winning[]);

int main(void)
{
    FILE *fin;
    int winning[6],ticket[6];
    int i,j;
    fin = fopen("lottery.txt", "r");
    readticket(fin, winning);
    
    for(i=0; i<6;i++)
    {
    printf("&#37;d ", winning[i]);
}

     while(!feof(fin))
     {
       scanf("%d \n",readticket);               //read ticket
       if(lottery==0)               //compare ticket, winning using lottery func
       printf("Ticket# %d has %d matching numbers \n",&ticket,&winning);               //print
     }
    system("PAUSE");
    return 0;
}


void readticket(FILE* fin, int ticket[])
{
     int i;
     for(i=0;i<6;i++)
         fscanf(fin,"%d", &ticket[i]);
     
     }
     
int lottery(int ticket[], int winning[])
{
   {    
        int i;
        int k;
        int count=0;

        for (i=0;i<6;i++)
            for(k=0;k<6;k++)
    
                if (ticket[i]==winning[k])
       
                     count++;
       
       return count; 
}
}

Code:

LotteryTicket.c: In function `main':
LotteryTicket.c:23: warning: int format, different type arg (arg 2)
LotteryTicket.c:23: error: syntax error before '/' token
LotteryTicket.c:27: warning: implicit declaration of function `system'
LotteryTicket.c:11: warning: unused variable `ticket'
LotteryTicket.c:12: warning: unused variable `j'

As tabstop and my compiler both pointed out, your scanf() is wrong. Always fix syntax errors first so you can test the logic itself instead of wasting time with stupid things like this. This will most likely just waste time crashing your program. If your compiler is not spitting out these types of errors, you need to turn the warning level up higher, preferably to max.

Edit: And actually your entire program logic appears bizarre like you mixed and matched totally different strategies.

Originally Posted by kirksson

Your posts are really useless so stop posting replies. If my code is bizzare why in the world you're even bothering to spend your precious time on my code.

Because you asked him to? Hello?

Also, forgot to mention: to call a function, like lottery for instance, you need to put (stuff in parentheses) behind it, indicating what you want to pass to the function.

Edit: Oh, and his point was also that if your code is only that long, there's no need to attach it, because, well, it's only that long. Making people have to click, and click, and then click again just to read it is not to your advantage. (I mean, yes, I'm that bored, but a lot of people aren't.)

Originally Posted by kirksson

Your posts are really useless so stop posting replies.

I'll post wherever I wish on these forums without your permission and without your blessing, as I told you more than once when you PM'ed me multiple times with such complaints.

Originally Posted by kirksson

If my code is bizzare why in the world you're even bothering to spend your precious time on my code.

If you won't put the effort into getting a decent grade, why take a programming course?

Originally Posted by kirksson

Get lost before i use my Mr. T line.

You already did that via PM over your prior homework topic:

Originally Posted by kirksson

I hope that is not all you got! We are just warming up because " I pity you fool!" - (remeber that famous line.)

I was actually waiting when you will use religious remarks so you can call me a buss driver.
Why a bus driver ?
I am taking you to school son!

I don't mind you being an idiot entirely since it doesn't necessarily affect me if you mess your life up, but if you can't contain yourself in public, the mods might get upset and restrict your ability to post. I suggest you play nice in the sandbox, and work with those who are trying to help you.

/me shrugs.

Your call to respond that way, but I wouldn't be entirely surprised, however, if this topic ends up getting locked.