Help with structures

Nearly all of menu() should be inside a do - while loop, so your code will do whatever the user has chosen, and then return and show the menu again, so the user can do something else.

Code:

---

do  {

  print "welcome to the main menu"...

  print something else.....

  get user's choice
 
  call other functions based on user's choice inside a large switch statement

  switch(choice)

    case 1: show(choice); break;

    case 2: whatever; break;

    default: print that choice is not available
  }
 
}while(choice != '9');

---

Something along the above lines is common.

Code:

---


#include <stdio.h>
#include <stdlib.h>
#include <conio.h>
#include <ctype.h>
#include <string.h>

void load_data();
void save_data();
void goto_record();
void enter_details(char edit);
void delete_record();

int const max_recs = 100;
char const data_file_name[100] = "cs215_b.dat";

struct TimberIDType
    {
        char Zone;
        char ID[10], TimberID[10];
        ID=TimberID;
    };

struct TimberRec
    {
        struct TimberIDType TimberID;
        char Kind[31];
        float Diameter, Weight, Height;
    }TimberArray[max_recs];
   
int address_count = 0, current_record = 0;

main()
    {
    char reply;
    load_data();
    do
        {
        clrscr();
        printf("Timber Database\n------------\n\n");
        if (address_count > 0)
            {
            printf("Record &#37;3d/%3d\n==============\n\n",
            current_record+1, address_count);
            printf("      ID: %s\n", TimberArray[current_record].TimberID);
            printf("  Kind: %s\n", TimberArray[current_record].Kind);
            printf(" Diameter: %2f\n", TimberArray[current_record].Diameter);
            printf(" Weight: %2f\n", TimberArray[current_record].Weight);
            printf(" Height: %2f\n", TimberArray[current_record].Height);

---

is this ok?

Code:

---


#include<stdio.h>
#include<string.h>
main()
{
    struct TimberIDType
    {
        char Zone;
        char ID[10];
    }TimberID;

    struct TimberRec
    {
        struct TimberIDType ID;
        char Kind[30];
        float Diameter;
        float Weight;
        float Height;
    }TimberArray[100];
   
    int x, y = 0, z, a, b;
    char kind[30], d[10];
    float c;
    for(x=y; x<=99; x++)
    {
        printf("Enter a choice \n");
        printf("[1] Add new record \n");
        printf("[2] Display all records\n");
        printf("[3] Display particular record given the kind\n");
        printf("[4] Display given record using weight\n");
        printf("[5] Display records given the TimberID \n");
        scanf("&#37;d",&z);
        if(z==1)
        {
            y=x;
            if(y>=100)
            {
                printf("\nRecord full\n\n");
            }
            else
            {
            printf("Enter Zone [A-Z]: ");
            fflush(stdin);
            scanf("%c", &TimberID[x].Zone);
            printf("Enter ID: ");
            scanf("%s", &TimberID[x].ID);
                if(strlen(TimberID[x].ID)!=10)
                    {
                printf("ID is invalid, it should be 10 characters\n");
                y=y-1;

                    }
            }
        printf("Enter timber kind: ");
        scanf("%s", &TimberArray[x].Kind);
        fflush(stdin);
        printf("Enter timber diameter: ");
        scanf("%f", &TimberArray[x].Diameter);
        fflush(stdin);
        printf("Enter timber weight: ");
        fflush(stdin);
        scanf("%f", &TimberArray[x].Weight);
        fflush(stdin);
        printf("Enter timber height: ");
        scanf("%f", &TimberArray[x].Height);
        fflush(stdin);
        printf("Record added at index %d",x);
        }
        else if(z==2)
        {
            for(a=0; a<=y; a++)
            {
                printf("%c\t", TimberID[a].Zone);
                printf("%s\t", TimberID[a].ID);
                printf("%s\t", TimberArray[a].Kind);
                printf("%f\t", TimberArray[a].Diameter);
                printf("%f\t", TimberArray[a].Weight);
                printf("%f\n", TimberArray[a].Height);



            }
        }
        else if(z==3)
        {
            printf("\n Enter kind to look for: ");
            scanf("%s",kind);
            for(a=0; a<=y; a++)
            {
                if(strcmp(kind, TimberArray[a].Kind))
                {
                    printf("\nRecord found\n");
                }
                else
                {
                    printf("\nRecord not found\n");
                    break;
                }
                printf("%c\t", TimberID[a].Zone);
                printf("%s\t", TimberID[a].ID);
                printf("%s\t", TimberArray[a].Kind);
                printf("%f\t", TimberArray[a].Diameter);
                printf("%f\t", TimberArray[a].Weight);
                printf("%f\n", TimberArray[a].Height);
            }

        }
        else if(z==4)
        {
            printf("\n Enter weight to look for: ");
            scanf("%f",&c);
            for(a=0; a<=y; a++)
            {
                if(c==TimberArray[a].Weight)
                {
                    printf("\nRecord found\n");
                }
                else
                {
                    printf("\nRecord not found\n");
                    break;
                }
                printf("%c\t", TimberID[a].Zone);
                printf("%s\t", TimberID[a].ID);
                printf("%s\t", TimberArray[a].Kind);
                printf("%f\t", TimberArray[a].Diameter);
                printf("%f\t", TimberArray[a].Weight);
                printf("%f\n", TimberArray[a].Height);
            }

        }

        else if(z==5)
        {
            printf("\n Enter ID to look for: ");
            scanf("%d",&d);
          for(a=0; a<=y; a++)
            {
                if(d==TimberID[a].ID)
                {
                    printf("\nRecord found\n");
                }
                else
                {
                    printf("\nRecord not found\n");
                    break;
                }
                printf("%c\t", TimberID[a].Zone);
                printf("%s\t", TimberID[a].ID);
                printf("%s\t", TimberArray[a].Kind);
                printf("%f\t", TimberArray[a].Diameter);
                printf("%f\t", TimberArray[a].Weight);
                printf("%f\n", TimberArray[a].Height);
            }
        }
    }
}

---

heres my timber program, but it needs some debugging here because of the subscripted value problem.

I see no variable named "value".

Show the problem, and please be direct and very descriptive. What are you getting for your output that you shouldn't be getting?

main () should return an int:

int main(void) {

I would recommend breaking this huge main function up into several smaller one's. Much easier to debug and keep organized logically, that way.

That may be too much for you to tackle atm, but keep it in mind. Nothings worse than having a HUGE function, and you either just can't get the right answer out of it, or you have errors that won't quit. Smaller functions mean smaller problems, which is a big help in programming.