Array of forums

[Ron]

Thanks <tabstop>.
The program is working now. In addhead I had to assign the return to a temp node, which in turn I have to equate to List[bucket].
As for as, add function, I worked with 2 pointers prev and curr. Now it is working.

Thanks Once again tabstop.

[Ron]

No the add is still not working. When I tried printing the contents of the node, only the heads are printed, not the rest of the linked list.

Im still not getting it. Once a linked list is set, can't I just leave it void.

My whole program is working except for this. I have to take another input file and compare the words with the words in the array of nodes. Then destroy the array. Everything is working, but the add function. Please someone show a spotlight to me.

PLEASE PLEASE

[tabstop]

No the add is still not working. When I tried printing the contents of the node, only the heads are printed, not the rest of the linked list.

Im still not getting it. Once a linked list is set, can't I just leave it void.

My whole program is working except for this. I have to take another input file and compare the words with the words in the array of nodes. Then destroy the array. Everything is working, but the add function. Please someone show a spotlight to me.

PLEASE PLEASE

We already have:

Question: Suppose you use the add() function to add a second node to your linked list. What line of your program sets the link from the head of the list to the new node? Bonus question: What, if anything, does the line temp = &NewNode do in your add() function, in the grand scheme of things? Double bonus question: When you are back in your main program after calling add(), what, if anything, is pointing to your newly-created node?

[Ron]

In the add function, I have returned the whole Linked list temp.

Then from main :
{
 Node *temp

temp=add(para,para);
 List[bucket] = temp;
}

But this doesnt help either.

[tabstop]

In the add function, I have returned the whole Linked list temp.

Then from main :
{
 Node *temp

temp=add(para,para);
 List[bucket] = temp;
}

But this doesnt help either.

So? Look at the question again:

What line of your program sets the link from the head of the list to the new node?

I'll ask another question to lead in to it: where would this link from one node to ... oh, let's call it the "next" node ... where would this link be?

[Ron]

Good question. I was always thinking of that. But didnt figure that to be the problem.
How can I set it up?
I have to create a function get head. But how can I do this with an arry of Node pointers?

[tabstop]

Good question. I was always thinking of that. But didnt figure that to be the problem.
How can I set it up?

You seem to have, in your code, code to follow a linked list all the way to the end. (I believe it's even in your add function.) How do you get from one node to the next? If that's how you get from one node to the next, how do you tack another node on to the end?

And an aside, if you hadn't noticed: the less work you put into your replies, the more obscure our answers become. If you want me to give you some better hints, you'll have to show that you've understood anything at all we've been saying to you. (And no, you really haven't shown much understanding at all in this thread that I can see.)

I have to create a function get head. But how can I do this with an arry of Node pointers?

You don't care about this until you get the rest working.

[Ron]

I have a pointer curr in the function , that goes curr =curr-> next.
This is my add code.

void add(char *new_string, Node *temp)
{
	Node *NewNode;
	NewNode = newNode(new_string);
	Node *curr;
	Node *prev;
	curr = temp;
	while (curr != NULL)
	{
		prev = curr;
		curr = curr->next;
	}
	prev->next=NewNode;
return (temp);
}

Main function
			if (List[bucket] == NULL)
				{  
					temp = addhead(string,List[bucket]);
				 List[bucket]= temp;

				}
    		else
    	    	{

					
					temp =  add(string,List[bucket]);
                                        List[bucket] = temp;

		}

My question is about the function call. Im aware you are making me think with your replies. which is good. So I can solve the problem myself. But your vocabulary is way over my head.
Thanks.

[tabstop]

I have a pointer curr in the function , that goes curr =curr-> next.
This is my add code.

void add(char *new_string, Node *temp)
{
	Node *NewNode;
	NewNode = newNode(new_string);
	Node *curr;
	Node *prev;
	curr = temp;
	while (curr != NULL)
	{
		prev = curr;
		curr = curr->next;
	}
	prev->next=NewNode;
return (temp);
}

Main function
			if (List[bucket] == NULL)
				{  
					temp = addhead(string,List[bucket]);
				 List[bucket]= temp;

				}
    		else
    	    	{

					
					temp =  add(string,List[bucket]);
                                        List[bucket] = temp;

		}

My question is about the function call. Im aware you are making me think with your replies. which is good. So I can solve the problem myself. But your vocabulary is way over my head.
Thanks.

Alright, now we're getting somewhere. add does everything it's supposed to: walks the link, tacks the new node at the end, sets the link. So why do you feel the need to do anything else afterwards? Why not just call

add(string, List[bucket]);

and be done with it?

Also, note that add is a void function, which means you cannot return something from it, so return(temp) is invalid and your compiler should be screaming to you about it.

[Ron]

That is what I have been telling so far. After doing the add and add head function. when I print the list. including sublists. only the heads are printed.

[tabstop]

I think (assuming you removed the return from add and the extra two assignments) that you have that right, then. I have no idea what your print code looks like.

[Ron]

void print (Node *temp)
{
	char word_copy[MAX];
	Node *curr;
	curr = temp;

				if (curr !=NULL)
				{


					
					while (curr != NULL)
					{
						strcpy(word_copy,temp->string);
						printf("%s",word_copy);


						curr=curr->next;

					}
				
				}

}

Main function:
	for(bucket=0;bucket < MAX; ibucket++)
	{

	print (List[bucket]);

	}

[tabstop]

strcpy(word_copy,temp->string);

temp??? Why print temp, when you want to print curr?

[Ron]

Just wanted to print the contents of the node. It is curr, sorry.

Still doesnt work, as i count checked the contents in the lists.

[rags_to_riches]

In an attempt to save tabstop's Hat of Guessing from becoming too bloodied:

void print (Node *temp)
{
    Node *curr = temp;

    while (curr !=NULL)
    {
        if (curr->string)
            printf("%s", curr->string);
        curr=curr->next;
    }
}