String Revarsal

[shwetha_siddu]

Dear All,
I want reverse string i wrote code as follow:-

#include "stdio.h"
#include "string.h"
int main()
{
  char *str="shwetha";
  char *str1;
  while(*str!='\0')
  str++;
  while(*str1!='\0')
  {
    *str1=*str;
    str1++;
    str++;
  }
str1='\0';
printf("%s", str1);
return 0;
}

i am getting Run time error what is the problem?

[MacGyver]

You're overwriting a string literal, which is generally not allowed. Declare your string as follows:

char str[]="shwetha";

[zacs7]

Also perhaps think of more meaningful names.

As "str!" looks like "str1" at a glance.

[MacGyver]

And unless I missed it, str1 doesn't point to anything meaningful.

[The Dog]

Be simple. The original string has 7 characters, so make space for str1.

Also, your logic is completely flawed.

str must move from the back to the front (decrement the pointer),
and str1 must move from the front the back (increment the pointer),
yet in your code, you increment both pointers all the time...