Calculating the length of a string

[BSmith4740]

I am trying to calculate the length of a string and finding the compiler aren't getting along.

For instance "code " == 4 I don't want it to include the null character but I am missing something. I thought a cast was when you have an int for instance and you want to return a value. For instance, you want to go from a conversion specifier of better precision and you have declared intengers.

 #include <stdio.h>
  4 #include <stdlib.h>
  5 
  6 int stringlength( const char *s);
  7 int count = 0;
  8 
  9 int main (void)
 10 
 11 {
 12 
 13 char s [ 50 ];
 14 int length;
 15 
 16 printf("Please enter a string\n");
 17 scanf("%s", s);
 18 
 19 length = stringlength(count);
 20 
 21 printf("The length of the string is %d\n",length);
 22 
 23 return 0;
 24 
 25 }
 26 
 27 int stringlength( const char *s )
 28 
 29 {
 30 
 31 
 32 while (  *s != NULL ) {
 33 count++;
 34 }
 35 
 36 return count;
 37 }




warning: passing argument 1 of âstringlengthâ makes pointer from integer without a cast

In function âstringlengthâ:
:32: warning: comparison between pointer and inte

[BSmith4740]

I have declared count globally or atleast I think I have. Why can't I pass in the array s and return count. It makes sense to me.

[robwhit]

look closely.

  6 int stringlength( const char *s);
  7 int count = 0;

 19 length = stringlength(count);

[BSmith4740]

line 6 I am passing in const char *s. I don't want the function to modify the string.

I have declared the global variable to 0. I can't increment it once I have declared it to be 0 in the while statement.

I want to return count to the function stringlength because that's what's counting my string.

[BSmith4740]

I am returning an intenger to my function.

[MacGyver]

You're not catching it. Look again. What are you actually passing to stringlength()?

[BSmith4740]

The count. If I pass it back the array. How does it know how many characters are in the array?

[MacGyver]

...... Um...... Apparently you have to study functions again.

You declared stringlength() as taking a const char *, but you're passing it an int. Do you not see this as wrong? If not, you made a mistake somewhere in your understanding of how this works.

[BSmith4740]

My book says to use const in being careful not to allow the function to modify the array or pointer.

[Elysia]

That is irrelevant.
You are passing an int, while the function is expecting const char*.
int != const char*.
The end.

[cpjust]

Once you figure out which parameter you should be passing to your stringlength() function (which is just duplicating the standard strlen() function) you need to fix the bug in stringlength() (or just use strlen() instead).
HINT: You have an infinite loop.

[BSmith4740]

How do I have an infinite loop. The while should exit when it reaches the null character. Setting the count to however many times it counted up to the null character.

 #include <stdio.h>
  4 #include <stdlib.h>
  5 
  6 int stringlength(  char s, 50);
  7 int count = 0;
  8 
  9 int main (void)
 10 
 11 {
 12 
 13 char s [ 50 ];
 14 int length;
 15 
 16 printf("Please enter a string\n");
 17 scanf("&#37;s", s);
 18 
 19 length = stringlength(count);
 20 
 21 printf("The length of the string is %d\n",length);
 22 
 23 return 0;
 24 
 25 }
 26 
 27 int stringlength(  char s, 50 )
 28 
 29 {
 30 
 31 
 32 while (  s != NULL ) {
count++;
 34 }
 35 
 36 return count;
 37 
 38 
 39 }

 error: expected declaration specifiers or &#226;...&#226; before numeric constant
.c:27: error: expected declaration specifiers or &#226;...&#226; before numeric constant
 In function &#226;stringlength&#226;:
 warning: comparison between pointer and integer

[Elysia]

Seriously, stop using C. It's obvious you have no idea what you're doing.
Go back to your books some weeks and try again afterwards.

[BSmith4740]

I wish I could. lol

[BSmith4740]

Sorry if I offended anyone. I am really trying to learn this and someone states I have an infinite loop. I state what "I think it is doing" and ask a question and Elysia gets ........ed off. What the heck?