Thread: converting string to integers

It would be possible with strtok and strtol.

Well, that just makes it more difficult, but the idea is the same.
You would have to walk through the string to find the spaces and either truncate the string (may be a little over course) or copy it into a new array with strcpy.
Then you would simply have to walk through that new string and translate each char into the appropriate integer and apply a little math.

You will need to use (either your own or a standard function [1]) that converts from string to integer, no matter what you do.

As Elysia indicated, you would have to walk through the string and find the separator, then find the next separator (or end of string), and copy the portion of string out, then convert that string to an integer.


[1] Ok, so we don't HAVE to make it a function - it could be code written inline in the main function - but that would not be good coding style, in my opinion - but it would remove the need to use a function if that's the requirement you have.

--
Mats

If you use wchar_t *temp, then your malloc should also use
wchar_t here:

Code:

if((temp = malloc(sizeof(char))) == NULL)
         exit(EXIT_FAILURE);

Moreover, you are only ever allocating one byte, but storing potentially more in the string.

And temp is never freed, so it's a memory leak too.

I would suggest using a fixed size string for this purpose - a number that is longer than (say) 15 digits will not be a valid integer [unless it has redundant leading zeros of course], so there's no need to have a string bigger than 16 chars. Saves all sort of problems with allocating memory - but make sure that you detect longer strings before trying to copy.

I would also, unless there is clear need to support a HUGE number of numbers, have buffer as a statically sized array - again, simplifying the code [and avoiding problems with what to do when allocation fails].

--
Mats

The assignment was no pointers, so that little solution fails.
But if you wanted to do it with pointers, then sure, that's one way.
Although, unfortunately, the code is not without bugs.

But temp is always one wchar_t, and it contains '\0'.
It never contains any other data, so trying to convert it to a number is meaningless.

Originally Posted by audinue

I wonder, where is it?

Where is what? You need to allocate strlen(something), and not sizeof(char). And you never assign anything to temp, except \0.

EDIT: Hang on, I see a for-loop that I missed before. (Yes, I got lost in the indentation.) So that should fill your temp array.

Originally Posted by tabstop

Where is what? You need to allocate strlen(something), and not sizeof(char). And you never assign anything to temp, except \0.

Exactly.

Originally Posted by audinue

Sorry, the code was ANSI before. I forget that one. Thanks.

Please take a look at...

Code:

if(input[i] == L' ' || i == wcslen(input))
{

   //...

   j = 0;
   free(temp);
   temp = NULL;

   //...

}

At the end of the loop the temp is freed.

Ok, I admit I didn't see that. So if i != wcslen(input) and the string doesn't end with a space, it won't do that, right - and I'm pretty sure that i < wcslen(input) in your for-loop will prevent it from hitting that bit of code...

Doing a realloc for every char in the string is REALLY bad coding practice. realloc itself is quite time consuming, and it will copy the content of the string each time [well, ok, so a decent implementation of realloc will just grow in place some of the time, but you don't know that this is how it's implement, nor when and under what conditons]. I still think you should use a fixed array size. Saves a lot of hazzle, and it's more efficient too.

--
Mats