Thread: How to properly use a C function?

This works:

Code:

#include <stdio.h>
#include <glob.h>
#include <stdlib.h>
#include <string.h>

#define MAX_ARGS 20

int main()
{
    char *cmd = strdup("ls *.php *.sh *.yo");
    char *arguments[MAX_ARGS] = { 0 };
    char *token = NULL; 
    char *command = strtok(cmd, " ");
    int count = 0;
    while (NULL != (token = strtok(NULL, " ")) && count < MAX_ARGS)
    {
        arguments[count++] = token;
    }

    glob_t globbuf = { 0 };
    int i = 0;
    int rc = 0;
    for (; i < count ; ++i)
    {
        if (0 != (rc = glob(arguments[i], GLOB_DOOFFS | GLOB_APPEND, 
                            NULL, &globbuf)))
        {
            if (GLOB_NOMATCH == rc)
                continue;
            fprintf(stderr, "glob failed: &#37;d\n", rc);
            free(cmd);
            return -1;
        }
    }
    for (i = 0; i < globbuf.gl_pathc; ++i)
    {
        printf("Argument %d: %s\n", i, globbuf.gl_pathv[i]);
    }
    globfree(&globbuf);
    free(cmd);
    return 0;
}

Originally Posted by Output

neon:~ me$ ./globtest
Argument 0: qs.php
Argument 1: sbtest.php
Argument 2: test.php
Argument 3: blah.sh
Argument 4: yoohoo.sh
Argument 5: p.sh
neon:~ me$

I'm not sure how to apply that to what i'm trying to do. I'm trying to allow make the command "ls *.c" display all the C files in the current directory. Looking at your code doesn't really help me understand what I did wrong or how to fix it. But don't worry about it, I figured out what I was doing wrong. I now have a general solution to allow all and any types of globbing via input. Thanks anyways.

First and foremost, string literals should be const char, not char.
const char *string = "ls *.c";
Second, I don't see where you define arguments. Most likely, your "arguments" variable isn't big enough to hold the data, but of course I can't be sure.

You are overwriting data you shouldn't somewhere. That's why you get an error.

One difference I see is that your globbuf isn't initialized. I don't KNOW if that's of any importance tho'.

--
Mats