Thread: Why doesn't it works?

I am just trying to use the command below

.............
..................
.......................

Code:

if (s[c]<1) {
     naccept=naccept+1;
else {
      nreject=nreject+1;
}

printf("naccept=%lf   nreject=%lf\n",naccept, nreject);

....................
.................

I am just trying to use if conditional statement to test values used using array

Thanx in advance

I am not sure if this is your problem, but in the code you provided, you are missing the closing brace for your first if statement. Since you are only using one line after both your if and else, the braces are not necessary at all.

I have this "}" closing bracket in my source code. Since i was coding using vim accessing the linux on windows platform, it ws hard for me copy the code and paste it so i wrote it and missed "}". And %lf works with my compiler.

And i am still having the problem. I get naccept =0 as well as nreject=0

Code:

for (c=0; c<NUM; c++)
	{
		r[c]=x[c]*x[c]+y[c]*y[c];
		printf("r=%lf\n",r[c]);
		s[c]=r[c]*r[c];
		printf("s[c]=%lf\n",s[c]);
		if (s[c]<1){
			naccept++;
		}
		else  {
			nreject++;
		}
	}

Code:

#include <stdlib.h>
#include <stdio.h>

#define NUM 100
#define IMAX 10
#define ISEED 777861
#define ISEED1 777862

#define RND() ((double)random()/(double)RAND_MAX)

main ()
{

	int i, naccept=0, nreject=0, ntrial=0, c;
	double x[NUM],s[NUM],r[NUM],pi;

	srandom(ISEED);
	 naccept=0; nreject=0; ntrial=0;
	for (i=0; i<NUM; i++)
	{
		x[i]=RND();
	}

	int j;
	double y[NUM];
	srandom(ISEED1);

	for (j=0; j<NUM; j++)
	{
		y[j]=RND();
	}
	for (c=0; c<NUM; c++)
	{
		r[c]=x[c]*x[c]+y[c]*y[c];
		printf("r=%lf\n",r[c]);
		s[c]=r[c]*r[c];
		printf("s[c]=%lf\n",s[c]);
		if (s[c]<1){
			naccept++;
		}
		else  {
			nreject++;
		}
	}
		ntrial= naccept+nreject;
		printf("naccept=%lf   nreject=%lf   ntrail=%lf\n",naccept,nreject,ntrial);
		pi=4*(naccept/ntrial);
		printf("pi=%.3lf\n",pi);
}

Would that be something to do with the floating point number, since s[c] is float, as i assume from the above snap of code. So what values do you get printed, when you print s[c]. Whats sort of values does that vector contain.

Some idea of values and input would help perhaps :-/

ssharish

You should perhaps get a quite lot linker error there when you compiler that code ????????????
Shoudn't that be rand and srand() ??????????

ssharish

It's basically values between 0.0000 to 1.70000 or something like that. my all other thing works expect that if condition statemen for s[c]. I don't why naccept and nreject aren't accumulating the values.

Small part of my result:

r=0.203552
s[c]=0.041433
r=1.747480
s[c]=3.053686
r=0.341290
s[c]=0.116479
r=1.269106
s[c]=1.610629
r=0.269674
s[c]=0.072724

try it with

Code:

if( s[c] < 1.0 ) {

ssharish