Updating a binary file

[jaybeeb]

I have a small bit of code here, basically getting an error

Lvalue required

on the line where I have marked. I think the '+=' symbol is for updating integers and I am updating a string, I could be wrong though, anybody have any ideas?
Thanks

 else {
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        printf("Enter change:");
        scanf("%s",&transaction);
        patient.doctor += transaction ; /*Line where the error shows*/
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        fseek( fPtr, (pat_no -1 ) * sizeof(struct pat_record ), SEEK_SET );
        fwrite( &patient, sizeof( struct pat_record ), 1, fPtr );
        }
    }

[master5001]

I would need to see the struct to be 100% sure, but isn't patient.doctor a char array?

[root4]

If you want to concatenate two strings, it cannot be done directly with a simple operator,
use strncat() for instance.

[jaybeeb]

I would need to see the struct to be 100% sure, but isn't patient.doctor a char array?

struct pat_record{
    int pat_no;
    char name [20];
    int dob;
    char doctor [20];
}

[master5001]

If you want to concatenate two strings, it cannot be done directly with a simple operator,
use strncat() for instance.

Alright, well I assumed as much. In any event, since all you want to do is concatenate two strings just do as was suggested and use strncat().

Example:

        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        printf("Enter change:");
        scanf("%s",&transaction);
        strncat(patient.doctor, transaction, sizeof(patient.doctor));
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        fseek( fPtr, (pat_no -1 ) * sizeof(struct pat_record ), SEEK_SET );
        fwrite( &patient, sizeof( struct pat_record ), 1, fPtr );

[jaybeeb]

Hi, thanks for the help. tried this but when I run it, the program encounters a windows error and then just ends, it doesnt give any error types just says it has to close?

[tabstop]

And what is your program doing when that happens? If we're still on this strncat thing, you might be trying to put more things into patient.doctor than it has room for. The strncat above will write up to 20 characters (the original size of patient.doctor), but there may not be that much room left if patient.doctor already contains something. If you want to overwrite, you should use strncpy, otherwise you'll need to figure out how much room you have left.

[rags_to_riches]

What tabstop said, and remove the & from the transaction variable in the scanf.

[jaybeeb]

Hi, thanks for the suggestions I wanted to overwrite so I sorted that out, but the error is still happening. The program asks me what patient number to be updated and when I enter the number, the program ends and the error appears.
Here is my whole function

void binupdaterecord(FILE *fPtr){
    int pat_no;
    char transaction[20];
    struct pat_record patient = { 0 , "" , 0 , "" };

    printf("Enter the number of the patient to be updated\n");
    printf(":");
    scanf("%d",&pat_no);
    fseek( fPtr,( pat_no - 1 ) * sizeof( struct pat_record ), SEEK_SET );
    fread( &patient, sizeof( struct pat_record ), 1, fPtr );

    if ( patient.pat_no == 0 )
        printf( "Patient number %d has no information.\n", pat_no );
    else {
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        printf("Enter change:");
        scanf("%s",transaction);
        strncpy(patient.doctor, transaction, sizeof(patient.doctor));
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        fseek( fPtr, ( pat_no -1 ) * sizeof( struct pat_record ), SEEK_SET );
        fwrite( &patient, sizeof( struct pat_record ), 1, fPtr );
        }
    }

[master5001]

I am thinking its probably still a buffer overflow problem.

Try:

scanf("%20s", transaction);

Check the return value of fseek(). Also, I am positive you are putting your input in correctly, however, you may want to fix it up a bit anyway for anyone else who uses it. i.e.

Example:

long pat_max = fseek(fPtr, 0, SEEK_END) / sizeof(struct pat_record);

// your code goes here
scanf("%d", &pat_no);
if(pat_no > 0 && pat_no < pat_max)
// more code

Just a thought.

[jaybeeb]

I am thinking its probably still a buffer overflow problem.

Where is it crashing exactly?

It asks me to enter the patient number I want to update then once I enter it and press enter it crashes.

Tried what you said...same thing

[master5001]

To be brutally honest, if it is crashing before where I thought it would buffer overflow my only thoughts are to add this before you do anything.

if(!fPtr)
{
   fprintf(stderr, "Invalid file handle.")
   return;
}

[swoopy]

>    fread( &patient, sizeof( struct pat_record ), 1, fPtr );

I would be sure the read was successful by checking the return value:

    if (fread( &patient, sizeof( struct pat_record ), 1, fPtr ) != 1)
    {
        printf("Error reading record %d\n", pat_no);
        return;
    }

Also be sure you opened the file in binary mode:

if ((fPtr = fopen(filename, "rb+") == NULL)

[jaybeeb]

long pat_max = fseek(fPtr, 0, SEEK_END) / sizeof(struct pat_record);

// your code goes here
scanf("%d", &pat_no);
if(pat_no > 0 && pat_no < pat_max)
// more code

This made the program crash when I selected "edit" didnt even get to enter a number?

if(!fPtr)
{
   fprintf(stderr, "Invalid file handle.")
   return;
}

Not sure exactly where to put this?? (bit of a novice at C)

>    fread( &patient, sizeof( struct pat_record ), 1, fPtr );

I would be sure the read was successful by checking the return value:

    if (fread( &patient, sizeof( struct pat_record ), 1, fPtr ) != 1)
    {
        printf("Error reading record %d\n", pat_no);
        return;
    }

Also be sure you opened the file in binary mode:

if ((fPtr = fopen(filename, "rb+") == NULL)

Put all this in but still getting the same error!?

Here is my code as it stands now

void binupdaterecord(FILE *fPtr){
    int pat_no;
    char transaction[20];
    struct pat_record patient = { 0 , "" , 0 , "" };


    if ((fPtr = fopen("binpatient.dat", "rb+") == NULL));
    printf("Enter the number of the patient to be updated\n");
    printf(":");
    scanf("%d",&pat_no);
    fseek( fPtr,( pat_no - 1 ) * sizeof( struct pat_record ), SEEK_SET );
    if(!fPtr)
    {
    fprintf(stderr, "Invalid file handle.");
    return;
    }
    if (fread( &patient, sizeof( struct pat_record ), 1, fPtr ) !=1);
    {
    		printf("Error reading record %d\n", pat_no);
         return;
    }
    if ( patient.pat_no == 0 )
        printf( "Patient number %d has no information.\n", pat_no );
    else {
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        printf("Enter change:");
        scanf("%20s",transaction);
        strncpy(patient.doctor, transaction, sizeof(patient.doctor));
        printf( "%d%s%d%s\n\n", patient.pat_no,patient.name,patient.dob,patient.doctor);
        fseek( fPtr, ( pat_no -1 ) * sizeof( struct pat_record ), SEEK_SET );
        fwrite( &patient, sizeof( struct pat_record ), 1, fPtr );
        }
    }

Thanks for the help so far!

[swoopy]

>    if ((fPtr = fopen("binpatient.dat", "rb+") == NULL));

if NULL is returned, then the file didn't open, so that would be the place to print an error message and quit:

    if ((fPtr = fopen("binpatient.dat", "rb+") == NULL))
    {
        printf("Error opening file binpatient.dat\n");
        return;
    }