Printable View
ok. i got the get_a_winner functtion to return winner that is a char. now is the do while loop.I want the program to keep looping until winner = 'X' or 'O'. When winner is 'X' or 'O' someone has won so i want the game to end. this is what i have. This doesn't seem to stop it tho.
Code:do
{
int i =user_move(tic_tac_toe);
tic_tac_toe[i-1]= choice;
print_board(tic_tac_toe);
char winner =get_a_winner(tic_tac_toe);
}while(winner != 'X' || winner != 'O');
printf("end of game\n");
Change || to &&. You want to keep going while BOTH statements are true.
english translation: while(winner != 'X' || winner != 'O');....if the winner is not X or the winner is not O then the program will keep going. If the winner is X or is O the program should execute the next line correct? I want to say that if the winner is X or O end of game.
That's the English translation, yes. Now: suppose the winner is X. Is the winner not O? Yes, the winner is not O. Therefore we keep going with the loop, since our loop condition is true (one side is true, so the whole thing is true).
We want the winner to not be X AND the winner to not be O.
I changed to && and tested the program and made X be the winner but it still doesn't stop when a winner is found???
snapshot of output already entered two positionsCode:Enter what box number that you
would like to place you move in>
3
make another move
X | X | X
----+---+----
| |
----+---+----
| |
player X is the winner
Enter what box number that you
would like to place you move in>
by the way thanks for all your help....couldn't have done it without you.
you do have a return 'X' somewhere in your winner check function?
Are you declaring winner inside your loop? If so, then winner will go out of scope before the check is made in the while() statement. So make sure winner is declared at the top of the program, rather than inside the loop.
Doesn't work like that. program below
Shouldn't the get_a_winner be inside the loop so that it can be checked everytime a input is made? If i put it outside the do{} it will never check for a winner it'll just keep going.Code:#include <stdio.h>
#include <stdlib.h>
#define NUMBER_OF_SQUARES 9
char tic_tac_toe[NUMBER_OF_SQUARES]={'0', '1','2', '3', '4', '5','6', '7', '8'};
void print_board(char*);
void clear_board(char*);
char get_user_character();
char user_move(char*);
char get_a_winner(char*);
int get_computer_move(char*);
int main()
{
int j =0;
char winner;
int O;
clear_board(tic_tac_toe);
print_board( tic_tac_toe);
char choice =get_user_character();
char winner =get_a_winner(tic_tac_toe);
do
{
int i =user_move(tic_tac_toe);
tic_tac_toe[i-1]= choice;
print_board(tic_tac_toe);
char winner =get_a_winner(tic_tac_toe);
}while(winner != 'X' && winner != 'O');
printf("end of game\n");
}
char get_a_winner(char*tic_tac_toe)
{
char X;
char O;
char winner;
if((tic_tac_toe[0] == 'X') && (tic_tac_toe[1] =='X') && (tic_tac_toe[2]=='X')||
(tic_tac_toe[3] == 'X') && (tic_tac_toe[4] =='X') && (tic_tac_toe[5]=='X')||
(tic_tac_toe[6] == 'X') && (tic_tac_toe[7] =='X') && (tic_tac_toe[8]=='X')||
(tic_tac_toe[0] == 'X') && (tic_tac_toe[3] =='X') && (tic_tac_toe[6]=='X')||
(tic_tac_toe[1] == 'X') && (tic_tac_toe[4] =='X') && (tic_tac_toe[7]=='X')||
(tic_tac_toe[2] == 'X') && (tic_tac_toe[5] =='X') && (tic_tac_toe[8]=='X')||
(tic_tac_toe[0] == 'X') && (tic_tac_toe[4] =='X') && (tic_tac_toe[8]=='X')||
(tic_tac_toe[2] == 'X') && (tic_tac_toe[4] =='X') && (tic_tac_toe[6]=='X'))
{
winner = 'X';
printf("player %c is the winner\n",winner);
return (winner);
}
else if((tic_tac_toe[0] == 'O') && (tic_tac_toe[1] =='O') && (tic_tac_toe[2]=='O')||
(tic_tac_toe[3] == 'O') && (tic_tac_toe[4] =='O') && (tic_tac_toe[5]=='O')||
(tic_tac_toe[6] == 'O') && (tic_tac_toe[7] =='O') && (tic_tac_toe[8]=='O')||
(tic_tac_toe[0] == 'O') && (tic_tac_toe[3] =='O') && (tic_tac_toe[6]=='O')||
(tic_tac_toe[1] == 'O') && (tic_tac_toe[4] =='O') && (tic_tac_toe[7]=='O')||
(tic_tac_toe[2] == 'O') && (tic_tac_toe[5] =='O') && (tic_tac_toe[8]=='O')||
(tic_tac_toe[0] == 'O') && (tic_tac_toe[4] =='O') && (tic_tac_toe[8]=='O')||
(tic_tac_toe[2] == 'O') && (tic_tac_toe[4] =='O') && (tic_tac_toe[6]=='O'))
{
winner = 'O';
printf("player %c is the winner\n", winner);
return (winner);
}
}
Remove the bits in red. You only declare variables once. The declaration inside the loop is "shadowing" the variable outside the loop, but when you get to the while() part, the inside-the-loop variable ceases to exist, leaving the outside-the-loop variable which is "random uninitialized data".Quote:
Originally Posted by marquis1431
Also, when you get to the bottom of the get_a_winner function you need to return ' ' (no winner).
ok. i removed char winner =get_a_winner(tic_tac_toe); all together and left this char choice =get_user_character(); as is and removed the char from char winner =get_a_winner(tic_tac_toe);......it seems to work fine...I should have noticed that i was delaring winner twice.
I have a function written for a computer play. The computer would take the next open space and play a O.
Shouldn't the for loop cycle thru the array unitl ' ' and then teturn computer_move which in the function will put an 'O' in that spot?Code:int main()
{
int j =0;
char winner;
int O;
clear_board(tic_tac_toe);
print_board( tic_tac_toe);
char choice=get_user_character();
do
{
int i =user_move(tic_tac_toe);
tic_tac_toe[i-1]= choice;
print_board(tic_tac_toe);
winner =get_a_winner(tic_tac_toe);
int computer_move=get_computer_move(tic_tac_toe);
tic_tac_toe[computer_move] = 'O';
}while(winner != 'X' && winner != 'O');
printf("end of game\n");
}
int get_computer_move(char *tic_tac_toe)
{
int computer_move;
for (computer_move=0; computer_move<9; computer_move++)
if(tic_tac_toe[computer_move] = ' ')
return (computer_move);
}
output
It doesn't put an 'O" on the board intil I entered the 6. then it said make another move as if the spot was not empty???? confusingCode:| |
----+---+----
| |
----+---+----
| |
Play with X or play with O
X
Enter what box number that you
would like to place you move in>
4
| |
----+---+----
X | |
----+---+----
| |
Enter what box number that you
would like to place you move in>
6
make another move
O | |
----+---+----
X | | X
----+---+----
| |
Enter what box number that you
would like to place you move in>
Is it not cycling thur the array correctly?Code:char user_move(char *tic_tac_toe)
{
int k;
int i;
printf("Enter what box number that you\n");
printf("would like to place you move in>\n");
scanf("%d", &i);
if (i < 0 || i>9)
printf("invalid move\n");
else if (*tic_tac_toe != ' ')
printf("make another move\n");
return (i);
}
Put a print_board after setting the computer's move to 'O'.
In your user_move thing, *tic_tac_toe is the first element of the board, always and forever. Maybe tic_tac_toe[i] is what you want instead.
great suggestions......it doesn't place the 'O" on the second iteration
shouldn't the computer_move function go thru the array tic_tac_toe until it reaches a ' '?Code:| |
----+---+----
| |
----+---+----
| |
Play with X or play with O
X
Enter what box number that you
would like to place you move in>
3
| | X
----+---+----
| |
----+---+----
| |
O | | X
----+---+----
| |
----+---+----
| |
Enter what box number that you
would like to place you move in>
5
O | | X
----+---+----
| X |
----+---+----
| |
O | | X
----+---+----
| X |
----+---+----
| |
Enter what box number that you
would like to place you move in>
8
O | | X
----+---+----
| X |
----+---+----
| X |
O | | X
----+---+----
| X |
----+---+----
| X |
This is why your compiler is telling you "assignment inside conditional statement" (or similar).Code:if(tic_tac_toe[computer_move] == ' ')
tabstop....i can say that you are a great person for this forum.....It works now....I could not have done it without you...I'm so grateful!!! Thank you sooo much.
if i wanted to let te computer be 'X' and the user be 'O' could I do this?
Code:int main()
{
int j =0;
char winner;
int O;
clear_board(tic_tac_toe);
print_board( tic_tac_toe);
char choice=get_user_character();
int computer_move=get_computer_move(tic_tac_toe);
do
{
int i =user_move(tic_tac_toe);
tic_tac_toe[i-1]= choice;
print_board(tic_tac_toe);
winner =get_a_winner(tic_tac_toe);
int computer_move=get_computer_move(tic_tac_toe);
if (choice = 'X')
tic_tac_toe[computer_move] = 'O';
else
tic_tac_toe[computer_move] = 'X';
// tic_tac_toe[computer_move] = 'O';
print_board(tic_tac_toe);
}while(winner != 'X' && winner != 'O');
printf("end of game\n");
return EXIT_SUCCESS;
}
You'll learn eventually.Code:if (choice == 'X')