Thread: looping and condition problems

  1. #1
    Registered User
    Join Date
    Mar 2008

    Question looping and condition problems

    I need to a program which prompt for how many names the user will enter
    Then a (dynamic) array of the requested size is created. It is an array of strings.
    In a loop of the requested size
    prompt the user to enter a name of at most 20 characters.
    read the name and turn into a string.
    allocate memory for a copy of the string and store its address in the appropriate item of the dynamic array.
    copy the input string into the memory allocated.
    When the loop is over, display the strings stored in the dynamic array.

    1. i cant show " empty input" for the user to enter only "\n"
    2. the loop cant run properly, it always trapped after i enter all the names

    this is the work i done so far.
    Thank you for the effort!

    #include <stdio.h>
    #include <string.h>
    #include <stdlib.h>
    #define merror()   {printf("memory allocation problem\n");exit(1);}
    int main(void)
    int num;
    char p;
    char **resp;
    char buf[21];
    int i, j;
    	printf(" how many names will be entered : \n");
        scanf("%d", &num);
    	if (num ==0)
    		printf(" empty input \n");
    	else if (num>= 10)
    		printf(" input too long \n");
    	else if (num >0 && num<10)
    		printf("you will enter %d names \n", num);
    for(i=0; i < num; i++)
    	printf(" enter the name \n");
            for(j=0; j<21; j++) 
    	      if (buf[j]=='\n')
    	    if (j==21)
    	      printf("input too long\n");
    for(i=0; i< num; i++)
        for(j=0; j<21; j++)
        **resp= buf[j];
      printf("\names as entered: \n");
      for(i=0; i<num; i++)
    return 0;

  2. #2
    Hurry Slowly vart's Avatar
    Join Date
    Oct 2006
    Rishon LeZion, Israel
    i cant show " empty input" for the user to enter only "\n"
    Read the input with fgets - then analyze it with strtol
    There are several samples on the forum

    2. fflush(stdin); is not defined - read FAQ

    3. **resp you dereference uninitialized pointer

    4. In your input loop you always oerwrite same buffer - loosing all inputs except the last

    for(i=0; i<num; i++)
    Do you see i somewhere inside the loop?
    All problems in computer science can be solved by another level of indirection,
    except for the problem of too many layers of indirection.
    David J. Wheeler

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. 'For loop' looping one too many times.
    By thealmightyone in forum C Programming
    Replies: 7
    Last Post: 02-20-2009, 06:46 AM
  2. Endless Looping with const_iterator
    By CH_Tang in forum C++ Programming
    Replies: 4
    Last Post: 05-24-2008, 09:43 PM
  3. Looping condition
    By Chaplin27 in forum C++ Programming
    Replies: 3
    Last Post: 05-29-2005, 02:06 PM