Thread: help on assignment (file i/o)

Hey guys. I'm new here. I have an assignment to read from a file and emulate a computer (moving around imaginary registers, moving RAM around, etc.)

I have two file pointers. one is in my main function and one is in a different function.

here is the code up to the first error:

Code:

#include <stdio.h>
#include <stdlib.h>

#define INPUT_FILE "interpreter.txt"

    FILE *fp, *rp;
int registers[10], ram[1000], freq[10], instruction, lines;

void decMack0();
void decMack1();
void decMack2();
void decMack3();
void decMack4();
void decMack5();
void decMack6();
void decMack7();
void decMack8();
void decMack9();
void output();
int s, a, d, n, l;

int main()
{
fp = fopen(INPUT_FILE, "r");
    if (fp == NULL)
    {
     printf("Can't open %s\n", INPUT_FILE);
     getchar();
     exit(1);
    }
   fscanf(fp, "%d", &lines);
   printf("%d", fp);
   reader(); 
 		while(!feof(fp))

here is the code for my second function:

Code:

reader()
{
int i=0;
int f=0;
while(!feof(rp)){
   rp = fopen(INPUT_FILE, "r");
   fscanf(rp, "%d", &f);
   f = ram[i];
	i++;
}
fclose(rp);
return;
}

for some reason, when I debug it, it doesn't seem to like the while loops. it won't even load the file once it sees that. when i print the pointers, fp and rp, it has a huge number (435557) something like that. can anyone see what I'm doing wrong? any help would be appreciated.

You can never get a meaningful number from printing the value of a FILE* variable.

You can't meaningfully check a file pointer (such as rp) for end-of-file if you have not yet opened it. Also, should you somehow get into that while loop, opening a file that is already open is a Bad Thing. (IOW: move that fopen outside the while loop.)

Also, you should remember that assignment statements in C move from right to left (i.e., the value on the right side is assigned to the variable on the left), not the other way around.

While on the subject of good function declarations, you should also always declare the types of the parameters, and never leave the list empty. That is:

Code:

void f(); /* bad */
void f(void); /* good */

This is so the compiler can tell you if you call the function with incorrect arguments:

Code:

void f();
void g(void);
int main(void)
{
  f(1, 2, 3); /* no diagnostic required! */
  g(1, 2, 3); /* diagnostic required */
}

The empty parameter list meaning "unspecified arguments" is leftover garbage from the pre-ANSI/ISO days of C, and was kept for compatibility purposes. New code should avoid it.

what do you want to do in reader() function , it is not clear
first, you are opening the file which is already opend than you are taking integer value in local variable int f , and then updating this value with ram[i]; value after completing the loop you are returning no value to the main..i think it is looking like some dummy code

and in the same section first you are using the' rp' value before assign it to any file ..so it is looking like a wild pointer