Thread: My Encryption Algorithm...

  1. #16
    C++ Witch laserlight's Avatar
    Join Date
    Oct 2003
    Location
    Singapore
    Posts
    28,413
    Since the statements were about public key, I felt it appropriate to illuminate this fact when replying to a comment that changed the discussion from public key to private key in order to attempt to refute a statement made about public key crypto.
    Sounds like a misunderstanding. You were the first one to mention public key cryptography in this thread. citizen's comments were directly concerning Junior89's algorithm.

    While I provided a link to wikipedia to the original poster, that does not mean I advocate wikipedia as the supreme authority on all things crypto.
    Please do not make such assumptions, unless you wish your own statements to be "beneath contempt"
    I did not use Wikipedia as an authority here, though I did use it as a reference to double check. Schneier's website on Blowfish claims: "Vincent Rijmen's Ph.D. thesis includes a second-order differential attack on 4-round Blowfish that cannot be extended to more rounds."

    Last I checked you get AES-512 on thumbdrive encryption utilities.
    FIPS 197 states: "The AES algorithm is capable of using cryptographic keys of 128, 192, and 256 bits to encrypt and decrypt data in blocks of 128 bits."
    There is clearly no mention of 512 bit keys. I had the impression that primes are not needed for keys in symmetric ciphers.
    Quote Originally Posted by Bjarne Stroustrup (2000-10-14)
    I get maybe two dozen requests for help with some sort of programming or design problem every day. Most have more sense than to send me hundreds of lines of code. If they do, I ask them to find the smallest example that exhibits the problem and send me that. Mostly, they then find the error themselves. "Finding the smallest program that demonstrates the error" is a powerful debugging tool.
    Look up a C++ Reference and learn How To Ask Questions The Smart Way

  2. #17
    Registered User
    Join Date
    Sep 2001
    Posts
    752
    Quote Originally Posted by Junior89 View Post
    Well i couldn't seem to find a good forum (out there on the web) or anything like that for a little review and courteous criticism of my algorithm here. I'm sure it's stupid and insecure but i would like it if someone with some knowledge in the field could point out some of the biggest mistakes i made. I'm not naive and i do know that it probably isn't more than a dressed up XOR encryption but hey, i'll give it a shot!
    Block 1...
    Code:
    a, b, c, d
    a^L, b^L, c^L, d^L
    d^L, a^L, b^L, c^L
    d^L^R, a^L^R, b^L^R, c^L^R
    S(d^L^R), S(a^L^R), S(b^L^R), S(c^L^R)
    We can undo the S(), so it's just a problem of finding L^R, which is just a single XOR problem. Cracking XOR of plaintext is a problem solved long ago.


    On the other hand, look at block 3...
    Code:
    a, b, c, d
    a^R, b^R, c^R, d^R
    S(a^R), S(b^R), S(c^R), S(d^R)
    S(a^R)^L, S(b^R)^L, S(c^R)^L, S(d^R)^L
    S(d^R)^L, S(a^R)^L, S(b^R)^L, S(c^R)^L
    This is better, because L^R can't combine into a single XOR problem. The classic XOR methodology wouldn't work.



    To be honest, the biggest problems with this are...
    1) The permutation method is far too simple.
    2) It doesn't repeat enough times.

    I suggest trying to implement a Feistel cipher, what you have is very close to that, which is the basis of a lot of cryptography.
    Callou collei we'll code the way
    Of prime numbers and pings!

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. RSA Encryption Algorithm help
    By gL_nEwB in forum C++ Programming
    Replies: 2
    Last Post: 04-27-2008, 04:14 AM
  2. Binary Search Trees Part III
    By Prelude in forum A Brief History of Cprogramming.com
    Replies: 16
    Last Post: 10-02-2004, 03:00 PM
  3. abt encryption algorithm
    By purIn in forum C Programming
    Replies: 9
    Last Post: 12-22-2003, 10:16 PM
  4. What's wrong with my Stream Cipher Encryption?
    By Davros in forum C++ Programming
    Replies: 3
    Last Post: 04-18-2002, 09:51 PM