Thread: instructor situation.

using brackets in the argument list is pretty non-standard, even if it will compile and is technicalyl correct. Your professor is wrong, it is ansi, but it does present a readability issue, since most people trying to read yoru code would be confused for a few milliseconds at what you are doing. The real test is whether -

Code:

void foo(int []);
 
void main(void){  // i love you ***** :D
   int* bar = NULL;
 
   foo(bar);
   }

will compile. if you can't use [] in a forward declaration without the variable name, and if the compiler wont accept it as synonymous rather than an overloaded function, then [] is incorrect.

Originally Posted by Dave_Sinkula

Are you seeing diagnostic messages with that code?

Of course he does:

temp.c: In function `main':
temp.c.4: error: `NULL' undeclared (first use in this function)
temp.c.4: error: (Each undeclared identifier is reported only once
temp.c.4: error: for each function it appears in.)
temp.c.3: warning: return type of `main' is not `int'

Originally Posted by novacain

If your boss (head developer / technical lead) told you to use the pointer declaration (or to do some other task their way), would you question their ability / understanding? [I hope not.]

Sometimes I want something done a particular way (and have a very good reason) but don't want to spend the 15-30 minutes explaining the specifics it to a new staff member who is not experienced in real world systems/conditions.

And fair enough, but would you give an obviously false reason and expect it to go by?