passing struct to function

Hello all! I'm creating a Win32 App using MSVC++ 6 compiler.
I'm looking for help because I don't understand why I am getting these errors. I've been reading up on structs in C ... but it hasn't clicked yet. I'm returning pVect so I can use it later in another function and it will be called more than once. I think i'm doing something wrong with my struct, but I cannot pinpoint it from here...is there a better way to pass a struct or use pointers in a different way...so confusing =[

Code:

		struct vect2d
        {
            float h;
            float v;

        };

Code:

	float getMouse(struct vect2d mVect)
        {	
			
			float One0;
			float One1;

			mVect.h = ReadProcessMemory(hand, (void*)0x402AD4B8, &One0,4, &bytes);//169
			mVect.v = ReadProcessMemory(hand, (void*)0x402AD4BC, &One1,4, &bytes);//170
            return mVect;//171
        }

Code:

main.c(169) : warning C4244: '=' : conversion from 'int ' to 'float ', possible loss of data
main.c(170) : warning C4244: '=' : conversion from 'int ' to 'float ', possible loss of data
main.c(171) : error C2115: 'return' : incompatible types

Moved to the Windows programming forum.

You might want to indent your code more consistently.

An online search tells me ReadProcessMemory() returns a BOOL (which is a typedef for int, methinks), not a float, so you probably want to write either:

Code:

struct vect2d getMouse()
{
    struct vect2d mVect;
    ReadProcessMemory(hand, (void*)0x402AD4B8, &mVect.h, 4, &bytes);
    ReadProcessMemory(hand, (void*)0x402AD4BC, &mVect.v, 4, &bytes);
    return mVect;
}

or:

Code:

void getMouse(struct vect2d* mVect)
{
    ReadProcessMemory(hand, (void*)0x402AD4B8, &mVect->h, 4, &bytes);
    ReadProcessMemory(hand, (void*)0x402AD4BC, &mVect->v, 4, &bytes);
}

... assuming that everything else that you are doing is correct.

PERFECT. Exactly what I needed to see! =] Thanks!

Incidentally, for completeness it may be better to write:

Code:

BOOL getMouse(struct vect2d* mVect)
{
    return ReadProcessMemory(hand, (void*)0x402AD4B8, &mVect->h, 4, &bytes)
        && ReadProcessMemory(hand, (void*)0x402AD4BC, &mVect->v, 4, &bytes);
}

I am a little uneasy though, since it looks like hand and bytes are global variables, and I hope you know what you are doing with the addresses.

I have them declared at the top like so:

Code:

DWORD bytes; 
HANDLE hand = NULL;

I then find the process on Initilization.. but since it's inside another function, will I need to set hand = OpenProcess each time I want to read/write in a different function?

Could you explain the significant different between these two functions? What is the end result of both?

Code:

BOOL getMouse(struct vect2d* mVect)
{
    return ReadProcessMemory(hand, (void*)0x402AD4B8, &mVect->h, 4, &bytes)
        && ReadProcessMemory(hand, (void*)0x402AD4BC, &mVect->v, 4, &bytes);
}

Code:

void getMouse(struct vect2d* mVect)
{	
    ReadProcessMemory(hand, (void*)0x402AD4B8, &mVect->h,4, &bytes);
    ReadProcessMemory(hand, (void*)0x402AD4BC, &mVect->v,4, &bytes);
}

The first returns TRUE (ie success) if both ReadProcessMemory succeeds.
The second does not return anything at all (so it's impossible to know if they failed).

But I need to to actually return a value of mVect (which i think is int)so I can use it later in a calculation to get an angle distance and then write it back in another function. True or false would do me no good I think.

mVect is a struct and you're passing a pointer, so the data is indeed written into your struct.

Awesome! Thanks for the info Elysia and laserlight! Got it working now.

I'm now doing this successfully:

Code:

struct vect2d
{
	float h;
	float v;
};

void getMouse()
{
	struct vect2d mVect;
	ReadProcessMemory(hand, (void*)0x4BD7D4B8, &mVect.h,4, &bytes);
	ReadProcessMemory(hand, (void*)0x4BD7D4BC, &mVect.v,4, &bytes);
}



void setMouse()
{
	struct vect2d mVect;
	WriteProcessMemory(hand, (void*)0x4BD7AF00, &mVect.h,4, &bytes);
	WriteProcessMemory(hand, (void*)0x4BD7AF04, &mVect.v,4, &bytes);
}

//Then in main, call the functions

Just for clarification, do these mean the same thing?:

Code:

void getMouse()
{
	struct vect2d mVect;
	ReadProcessMemory(hand, (void*)0x4BD7D4B8, &mVect.h,4, &bytes);
	ReadProcessMemory(hand, (void*)0x4BD7D4BC, &mVect.v,4, &bytes);
}

Code:

void getMouse(struct vect2d* mVect)
{
	ReadProcessMemory(hand, (void*)0x4BD7D4B8, &mVect.h,4, &bytes);
	ReadProcessMemory(hand, (void*)0x4BD7D4BC, &mVect.v,4, &bytes);
}

This does not work as intended.
The struct you define in the function is destroyed when the function returns, so all the data you just read is lost.
And you never return whether or not the function succeeded or failed.

Hmm, interesting...

Because when I look in memory of that process, that data is updated and writes continuously to the address I specified...so it IS working, but maybe it's not how I should be doing it?

I've removed everything but this from my program and it's working properly. I check memory and the data IS writing to the address so I'm not sure why you say it's lost?

Here's what I have that is working:

Code:

#include <windows.h>

DWORD pid; 
HWND hwndWindow; 
DWORD bytes; 
HANDLE hand=NULL;
char *myWindow = "theApp";


struct vect2d
{
	float h;
	float v;
};
		
void getMouse()
{
	struct vect2d mVect;
	ReadProcessMemory(hand, (void*)0x4BD7D4B8, &mVect.h,4, &bytes);
	ReadProcessMemory(hand, (void*)0x4BD7D4BC, &mVect.v,4, &bytes);
}



void setMouse()
{
	struct vect2d mVect;
	WriteProcessMemory(hand, (void*)0x4BD7AF00, &mVect.h,4, &bytes);
	WriteProcessMemory(hand, (void*)0x4BD7AF04, &mVect.v,4, &bytes);
}

void main(void)
{
	hwndWindow = FindWindow(NULL,myWindow);	
	
	if(hwndWindow) 
	{
			
		GetWindowThreadProcessId(hwndWindow, &pid);
		hand = OpenProcess(PROCESS_ALL_ACCESS,0,pid);
		
		while(hand!=0)
		{
			getMouse();
			setMouse();
		}
	}
}

I did mention "read," didn't I? All the data you read is lost once the function returns.
What is the point of reading the memory if you're not going to do anything with it?
Further, you also write junk data to the process memory, as well, since the struct is uninitialized.

Originally Posted by Elysia

I did mention "read," didn't I? All the data you read is lost once the function returns.
What is the point of reading the memory if you're not going to do anything with it?
Further, you also write junk data to the process memory, as well, since the struct is uninitialized.

I do appologize that I wasn't taking into consideration what you said. However, looking over what you suggested, I came up something, tell me if this looks any better.. =p

Code:

#include <windows.h>

DWORD pid; 
HWND hwndWindow; 
DWORD bytes; 
HANDLE hand=NULL;
char *myWindow = "myApp";


struct vect2d
{
	float h;
	float v;
};
		
void getMouse(struct vect2d* mVect)
{
	ReadProcessMemory(hand, (void*)0x4BD7D4B8, &mVect->h,4, &bytes);
	ReadProcessMemory(hand, (void*)0x4BD7D4BC, &mVect->v,4, &bytes);
}



void setMouse(struct vect2d* mVect)
{	
	WriteProcessMemory(hand, (void*)0x4BD7AF00, &mVect->h,4, &bytes);
	WriteProcessMemory(hand, (void*)0x4BD7AF04, &mVect->v,4, &bytes);
}

void main(void)
{
	hwndWindow = FindWindow(NULL,myWindow);	
	
	if(hwndWindow) 
	{
		struct vect2d mVect;
			
		GetWindowThreadProcessId(hwndWindow, &pid);
		hand = OpenProcess(PROCESS_ALL_ACCESS,0,pid);
		
		while(hand!=0)
		{
			getMouse(&mVect);
			setMouse(&mVect);
		}
	}
}

Originally Posted by silentkarma

Code:

 float getMouse(vect2d mVect)
        {    
 
            float One0;
            float One1;
 
            mVect.h = ReadProcessMemory(hand, (void*)0x402AD4B8, &One0,4, &bytes);//169
            mVect.v = ReadProcessMemory(hand, (void*)0x402AD4BC, &One1,4, &bytes);//170
            return mVect;//171
        }

you dont need the struct keyword in the function parameter list. Once you declare a struct, the name of the struct becomes a type.

Originally Posted by abachler

you dont need the struct keyword in the function parameter list. Once you declare a struct, the name of the struct becomes a type.

In C you do.