help with MDI CreateWindow

hey guys, im having some problems with creating the frame window for an MDI application. Ive checked over the code a dozen tiems and cant find the error. I looking at petzold, but I keep getting the frame window creation failed result. Here is the relevant stuff -

Code:

    // in WinMain
    CreateFrameWindow(hInstance);
    if(hwndFrame == NULL){
        MessageBox(0, "Frame Window Creation Failed!", "Error!",MB_ICONEXCLAMATION | MB_OK | MB_SYSTEMMODAL);
        return 0;
        }
 
 
 
void CreateFrameWindow(HINSTANCE hInstance){
    WNDCLASS WndClass;
    RECT Rect;
    char    szClassName[] = "MyMDIFrameClass";
 
    WndClass.style         = (CS_HREDRAW | CS_VREDRAW);
    WndClass.lpfnWndProc   = FrameWndProc;
    WndClass.cbClsExtra    = 0;
    WndClass.cbWndExtra    = 0;
    WndClass.hInstance     = hInstance;
    WndClass.hIcon         = LoadIcon(NULL, IDI_APPLICATION);
    WndClass.hCursor       = LoadCursor(NULL, IDC_CROSS);
    WndClass.hbrBackground = (HBRUSH)(COLOR_APPWORKSPACE+1);
    WndClass.lpszMenuName  = NULL; //MAKEINTRESOURCE(IDR_MENU1);
    WndClass.lpszClassName = szClassName;
 
    if(!RegisterClass(&WndClass)){
        MessageBox(0, "Window Registration Failed!", "Error!", MB_ICONEXCLAMATION | MB_OK | MB_SYSTEMMODAL);
        return;
        }
 
    Rect.left = 0;
    Rect.top = 0;
    Rect.right = 1284;
    Rect.bottom = 964;
    AdjustWindowRect( &Rect , WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN , TRUE );
    hwndFrame = CreateWindow(   szClassName,
                                "MyMDI App",
                                WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN,
                                CW_USEDEFAULT, CW_USEDEFAULT, 
                                CW_USEDEFAULT, CW_USEDEFAULT,
                                NULL, LoadMenu(hInstance,"IDR_MENU1"), 
                                hInstance, NULL);
 
    return;
    }

BTW, im writing in straight C/C++, no MFC

In your WndProc are you returning DefFrameProc for messages you don't handle?

Did you test your hwnd right after the call to createwindow in the function? Is it valid there? If not, did you call getlasterror()? What value did you get for that?

Im using DefFrameProc, I added this bit of error handlign code -

Code:

    sprintf(szError,"GetLastError() = %d\0",GetLastError());
    if(hwndFrame == NULL){
        MessageBox(NULL,"Frame Window Failure in-function",szError,MB_OK);
        }

GetLastError() is returning 1400 - Invalid Window Handle ???

This doesnt make any sense to me, since im not passing it a window handle

>>This doesnt make any sense to me, since im not passing it a window handle

Yes you are, the menu's handle.


Put a break point in the Frames WM_CREATE.

Does your code get to try and create the frame window?

I think it is to do with your menu, you have some commented in and some out. ie the class is registered as not having a menu then you try and add one.


I think this is you error.

LoadMenu(hInstance,"IDR_MENU1"),

Check this, does it load the menu or is it returning an invalid handle?

Try

LoadMenu(hInstance, MAKEINTRESOURCE(IDR_MENU1) ),

Make sure it loads the menu BEFORE calling createwindow