Thread: Systemtray Problem

Hi,

This is my code:

Code:

case WM_CREATE:
		
				hInst = (HINSTANCE)GetWindowLong(NULL, GWL_HINSTANCE);
				hmenu = LoadMenu(hInst,MAKEINTRESOURCE(IDR_SYSMENU));
				hmenu = GetSubMenu(hmenu,0);

				Nicon.cbSize = sizeof(NOTIFYICONDATA);	
				Nicon.hWnd = hWnd;	
				Nicon.uFlags = NIF_ICON|NIF_MESSAGE|NIF_TIP;
				Nicon.hIcon = (HICON)LoadImage(GetModuleHandle(NULL),MAKEINTRESOURCE(IDI_ICON1),
					IMAGE_ICON,16,16,LR_DEFAULTCOLOR); 								
				Nicon.uCallbackMessage = WM_TRAYMESSAGE;
				Nicon.uID = ICONIDENT;
				wcscpy(Nicon.szTip, _T("Check"));
				Shell_NotifyIcon(NIM_ADD, &Nicon);
			break;

case WM_DESTROY:
         Shell_NotifyIcon(NIM_DELETE, &Nicon);	
	 PostQuitMessage(0); 
	 return 0;

The problem i am having is that when my program closes, the tray icon is not removed, and it is left in the tray, until i move my mouse over it then it is removed. Any ideas what i have done wrong?

Thanks

Originally Posted by Dante Shamest

Tell me if this helps...

Code:

case WM_DESTROY:
         SetForegroundWindow( hwnd );
         Shell_NotifyIcon(NIM_DELETE, &Nicon);	
	 PostQuitMessage(0); 
	 return 0;

Sadly that didnt help , but i managed to fix the problem by moving my code out of WM_CREATE into my WinMain() function, and i made the notifyicon structure global then just added the icon in WM_CREATE, by doing this in combination with having Shell_NotifyIcon(NIM_DELETE, &Nicon); inside WM_DESTROY the icon is now removed fine

Originally Posted by BobS0327

I have the same system tray problem. This is a known bug in the Win32 GUI. Unfortunately, Win32 is an extremely low MS priority. So, I don't believe this problem will ever be resolved.

Except that no real profession software experiences this alleged 'bug'. There is no such 'bug' - there's failing to clean up and remove your systray icon.

(TNT): Does your NOTIFYICONDATA structure contain any information, or random garbage? You'll need to fill out at least the uID & hWnd members for removal to work. (Perhaps more) (Is Shell_NotifyIcon() returning success? No...)

All I can see from your code post is Nicon being filled out in WM_CREATE. If you've declared Nicon as a normal variable ( ie, NOTIFYICONDATA Nicon; ) then it contains no real data.

1) Show us how/where you declare Nicon.
2) Make sure that at the call with NIM_DELETE, that the uID & hWnd members are valid.

but i managed to fix the problem by moving my code out of WM_CREATE into my WinMain() function, and i made the notifyicon structure global then just added the icon in WM_CREATE, by doing this in combination with having Shell_NotifyIcon(NIM_DELETE, &Nicon); inside WM_DESTROY the icon is now removed

(TNT)

This does seem to work for me. I don't know how many times I've single stepped thru my code with a debugger to no avail. It even got to the point where I was questioning my debugger. So, I sent the code to an associate programmer for a peer review and she experienced the same thing. Between Googling and single stepping the code, I have quite a bit of time invested in this problem.

THANX!!!!

iTunes has the False Icon Bug if I close it during a high load time, Java has this bug also from time to time. So your "real profession software" theory is off.

Hmm im not to sure what you mean Yuri, If a process is terminated directly, then the tray icon still remains, I dont think this can be fixed, because the said program does not go through its cleanup routines which will include removing the tray icon, as a result its left behind (sometimes anyway...)

However, it does seem like a bug to me because i would have thought if the parent process to the tray icon no longer exists then windows should remove the icon automatically.

Anyway this wasnt the problem i was having, my problem was that during a 'normal' program exit the icon was left behind, i have now fixed this by placing the code in the WinMain function.