Weird optimalisation error (with code)

[johny145]

I've written some code to get the filename of the executable from a window handle. This code works perfect, but when i turn on optimalisation on in the compiler my program crashes. I cant debug this problem since it only happens when optimalisation is turned on.
The reason why i think the problem is GetModuleFileNameExDLL, is because the program doesnt get past this line.

I am using mingw in combination with code::blocks.

void GetFilenamFromWindowHandle(HWND hwnd,char* fileName,int sizeFileName)
{
    typedef DWORD (*GETMODULEFILENAMEEX) (HANDLE hProcess,HMODULE hModule,LPTSTR lpFilename,DWORD nSize);
    typedef BOOL (*ENUMPROCESSMODULES) (HANDLE hProcess,HMODULE* lphModule,DWORD cb,LPDWORD lpcbNeeded);
    if(isWinNT)
    {
        HINSTANCE psapiLib = LoadLibrary("PSAPI");
        if(!psapiLib)
        {
            Msg("Missing or invallid psapi.dll, this program will now close.");
            ExitProcess(0);
            return;
        }
        GETMODULEFILENAMEEX GetModuleFileNameExDLL = (GETMODULEFILENAMEEX) GetProcAddress(psapiLib, "GetModuleFileNameExA");
        ENUMPROCESSMODULES EnumProcessModulesDLL = (ENUMPROCESSMODULES) GetProcAddress(psapiLib, "EnumProcessModules");
        if(GetModuleFileNameExDLL == 0 || EnumProcessModulesDLL == 0)
        {
            Msg("Missing or invallid psapi.dll, this program will now close.");
            ExitProcess(0);
            return;
        }
        HANDLE hMainProc;
        DWORD procId=0;
        GetWindowThreadProcessId(hwnd,&procId);
        hMainProc = OpenProcess( PROCESS_QUERY_INFORMATION |PROCESS_VM_READ,false, procId );
        if(!hMainProc)
            return;
        HMODULE mod ;
        DWORD needed;
        EnumProcessModulesDLL(hMainProc,&mod,sizeof(mod),&needed); 
        GetModuleFileNameExDLL(hMainProc,mod,fileName,sizeFileName);  //something goes wrong at this call (i think)  
        CloseHandle(hMainProc);
    }
    else
    {
        GetWindowModuleFileName(hwnd,fileName,sizeFileName);
    }
}

[Salem]

It's pretty certain that where it falls over and where the problem is are two different things.

Changing the build type usually means that you have some kind of uninitialised variable (possibly a pointer) or buffer overrun problem somewhere in the code.

I mean, if you try this function in isolation (with just enough of a main() to call it), does it still crash, or does it work? If it works, then the problem is somewhere else in your code.

[johny145]

I have replaced the GetModuleFileNameExDLL with the "real" GetModuleFileNameEx and now it does work when using optimalisation. I just dont get it. I am importing this function from a dll so my program can be run under win98. But somehow my imported functions doesnt work as good as the "real" one. And this problem only shows up when using optimalisation

[Codeplug]

Your function pointers don't have the right calling convention.

    typedef DWORD (WINAPI *GETMODULEFILENAMEEX)(HANDLE, HMODULE, LPTSTR, DWORD);
    typedef BOOL (WINAPI *ENUMPROCESSMODULES)(HANDLE, HMODULE*, DWORD, LPDWORD);

gg

[johny145]

Thanks, now it works perfectly . But i dont know exactly why it now works. I found on google it has to do with calling conventions (__stdcall) , like you mentioned, but im still unsure what i am actualy doing with the typedef. I always copy it and modify it to suit my needs, but i never really understanded what this kind of typedef really does. The usual examples of typedef are really simple, but i cant find any info that explains something as "complicated" like the one i use. Could you give a link/info on this kind of typedefs?