Damn Simple Window Program

this has a malfuntion in it ONE ERROR!

40 C:\Documents and Settings\Richard\Desktop\Win API.cpp expected primary-expression before ')' token

ill comment it in the code

Code:

#include <windows.h>

LRESULT CALLBACK WindowProcedure(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam);

char szClassName[ ] = "App";
char WinName[ ] = "Windows API Test....";

int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow)
{
    MSG Msg;
    HWND hWnd;
    WNDCLASSEX cls;
    
    cls.cbSize = sizeof(WNDCLASSEX);
    cls.style = CS_HREDRAW | CS_VREDRAW;
    cls.lpfnWndProc = WindowProcedure;
    cls.cbClsExtra = 0;
    cls.cbWndExtra = 0;
    cls.hIcon = LoadIcon(NULL, IDI_ERROR);
    cls.hCursor = LoadCursor(NULL, IDC_NO);
    cls.hbrBackground = (HBRUSH)GetStockObject(WHITE_BRUSH);
    cls.lpszMenuName = NULL;
    cls.lpszClassName = szClassName;
    cls.hInstance = hInstance;
    cls.hIconSm = LoadIcon(NULL, IDI_ERROR);
    
    RegisterClassEx(&cls);
    
    hWnd = CreateWindow (szClassName, WinName, WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT,
    CW_USEDEFAULT, CW_USEDEFAULT, NULL, NULL, hInstance, NULL); 
    
    if( !hWnd )
    {
        return 0;
    }
    
    ShowWindow(hWnd, SW_SHOWNORMAL);
    UpdateWindow(hWnd);
    
    while( GetMessage(&Msg, NULL, 0, 0,) ) /* line 40 (error) */
    {
           TranslateMessage(&Msg);
           DispatchMessage(&Msg);
    }
    
    return Msg.wParam;
}
    
LRESULT CALLBACK WindowProcedure(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam)
{
        switch(Msg)
            {
                   case WM_DESTROY:
                            PostQuitMessage(WM_QUIT);
                            break;
                       default:
                            return DefWindowProc(hWnd, Msg, wParam, lParam);
            }
        return 0;
}

help please

and for:

Code:

cls.hbrBackground = (HBRUSH)GetStockObject(WHITE_BRUSH);

i want to get the background red i tried RED_BRUSH but it didnt work any ideas??

For the first question, try this:

Code:

while(GetMessage(&Msg, NULL, 0, 0) > 0)

-
For the second question, you will have to create a red brush,

Code:

HBRUSH BackgroundBrush = CreateSolidBrush(RGB(255,0,0));

Then,

Code:

cls.hbrBackground = BackgroundBrush;

Don't forget to

Code:

DeleteObject(BackgroundBrush);

When you're finished with it.

wow thanks! but know i have double thee errors and createsold obj. thingy dontwork says undeclared (HBRUSH IS UNDECLARED)
so i kept it white


[Linker error] undefined reference to `GetStockObject@4'

ld returned 1 exit status

i just deleted the hbrbackground attribute so it now compiles then exits quick

Here's your code, works fine for me.

Code:

#include <windows.h>

LRESULT CALLBACK WindowProcedure(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam);

char szClassName[ ] = "App";
char WinName[ ] = "Windows API Test....";

int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow)
{
    MSG Msg;
    HWND hWnd;
    WNDCLASSEX cls;
    HBRUSH BackgroundBrush = CreateSolidBrush(RGB(255,0,0));
    
    cls.cbSize = sizeof(WNDCLASSEX);
    cls.style = CS_HREDRAW | CS_VREDRAW;
    cls.lpfnWndProc = WindowProcedure;
    cls.cbClsExtra = 0;
    cls.cbWndExtra = 0;
    cls.hIcon = LoadIcon(NULL, IDI_ERROR);
    cls.hCursor = LoadCursor(NULL, IDC_NO);
    cls.hbrBackground = BackgroundBrush;
    cls.lpszMenuName = NULL;
    cls.lpszClassName = szClassName;
    cls.hInstance = hInstance;
    cls.hIconSm = LoadIcon(NULL, IDI_ERROR);
    
    RegisterClassEx(&cls);
    
    hWnd = CreateWindow (szClassName, WinName, WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT,
    CW_USEDEFAULT, CW_USEDEFAULT, NULL, NULL, hInstance, NULL); 
    
    if( !hWnd )
    {
        return 0;
    }
    
    ShowWindow(hWnd, SW_SHOW);
    UpdateWindow(hWnd);
    
    while(GetMessage(&Msg, NULL, 0, 0) > 0)
    {
           TranslateMessage(&Msg);
           DispatchMessage(&Msg);
    }

    DeleteObject(BackgroundBrush);

    return Msg.wParam;
}
    
LRESULT CALLBACK WindowProcedure(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam)
{
        switch(Msg)
            {
                   case WM_DESTROY:
                            PostQuitMessage(WM_QUIT);
                            break;
                       default:
                            return DefWindowProc(hWnd, Msg, wParam, lParam);
            }
        return 0;
}

[Linker error] undefined reference to `CreateSolidBrush@4'

[Linker error] undefined reference to `DeleteObject@4'

i think its my compiler what IDE do you use?

I use Microsoft Visual C++ Pro 6.0, if you would listen to me in the other thread and create a windows project, I'm sure it will work, because you're using a blank project needed libraries are not getting included, gdi32.lib for example.

ok i did but still same ........

Code:

cls.hbrbackground = (HBRUSH)COLOR_BACKGROUND;

if i cange it its ........s up

You're still getting those linker errors?
Are you definitely linking to gdi32.lib?

how do i know should i #include it

Originally Posted by C+noob

how do i know should i #include it

No. Don't #include anything other than header files. Check in the linker options ... it'll be buried in a menu somewhere.

no no settingsa in the linker options reflectuing libraries but in another secxtion your able to include libraries buit i dont know were you would find the pone im lookin for

Code:

while( GetMessage(&Msg, NULL, 0, 0,) ) /* line 40 (error) */

extra comma after 0