Thread: window doesn't open

can someone tell me why my dialog box doesn't open please.
It builds fine, it just doesn't open a window..

Code:

#include <windows.h>
#include "resource.h" 

BOOL CALLBACK DlgProc(HWND hwnd, UINT Message, WPARAM wParam, LPARAM lParam)
{
	switch(Message)
	{
		case WM_INITDIALOG:
			
                return TRUE;
		case WM_COMMAND:
			switch(LOWORD(wParam))
			{
				case IDOK:
				        MessageBox(NULL, "You hit OK", "Note", MB_OK);
				break;
            
				case IDCANCEL:
				        MessageBox(NULL, "You hit Cancel", "Note", MB_OK);
				break;
                         }
		case WM_CLOSE:
			EndDialog(hwnd, 0);
		break;
		default:
			return FALSE;
	}
	return TRUE;
}

int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,
	LPSTR lpCmdLine, int nCmdShow)
{
	return DialogBox(hInstance, MAKEINTRESOURCE(IDD_MAIN), NULL, DlgProc);
}

My .rc file is a follows:

Code:

#include <windows.h>
#include <afxres.h>
#include "resource.h"

IDD_MAIN DIALOG DISCARDABLE  0, 0, 186, 90
STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU
CAPTION "Dialog"
FONT 8, "MS Sans Serif"
BEGIN
    DEFPUSHBUTTON   "&Yes",IDOK,23,42,50,14
    PUSHBUTTON      "&No",IDCANCEL,110,41,50,14
    CONTROL         "Progress1",IDC_PROGRESS1,"msctls_progress32",WS_BORDER,
                    14,65,159,10
    CTEXT           "Do you want to download and install Mozilla ActiveX Control?",
                    IDC_STATIC,16,7,152,27
END


/////////////////////////////////////////////////////////////////////////////
//
// DESIGNINFO
//

#ifdef APSTUDIO_INVOKED
GUIDELINES DESIGNINFO DISCARDABLE 
BEGIN
    IDD_MAIN, DIALOG
    BEGIN
        LEFTMARGIN, 7
        RIGHTMARGIN, 179
        TOPMARGIN, 7
        BOTTOMMARGIN, 83
    END
END
#endif    // APSTUDIO_INVOKED

Thanks.

Hi Codeplug.

I've tried that, and DS_CENTER but I'm still getting nothing.

I've pulled this program right down to the bare minimum as you can see above, but I can't get to the bottom of why it won't load.

Thanks.

Your dialog resource includes a common control so you need to link with comctl32.lib, otherwise your dialog won't show. But make sure your dialog has the WS_VISIBLE style, too, as Codeplug has recommended.

Thanks, Quantum1024 - I forgot to mention that.

OK, I've got it working, (well I didn't quite get the window I was after, but I got something) but I don't understand it ...... at all.

I didn't link in the comctl32 library, or call InitCommonControls, all I did was remove the braces around 'switch(LOWORD(wParam))' and it worked.

Here is my working code ......... can anyone shed some light on this please, I'm baffalled

Code:

#include <windows.h>
#include "resource.h" 


BOOL CALLBACK DlgProc(HWND hwnd, UINT Message, WPARAM wParam, LPARAM lParam)
{
	switch(Message)
	{
	         case WM_INITDIALOG:
			
                 break;       
	         case WM_COMMAND:
			switch(LOWORD(wParam))
			
				case IDOK:
				        MessageBox(NULL, "You hit OK", "Note", MB_OK);
				break;
            
				case IDCANCEL:
				        MessageBox(NULL, "You hit Cancel", "Note", MB_OK);
				break;
       
		case WM_CLOSE:
			EndDialog(hwnd, 0);
		break;
		default:
			return FALSE;
	}
	return TRUE;
}

int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,
	LPSTR lpCmdLine, int nCmdShow)
{
	return DialogBox(hInstance, MAKEINTRESOURCE(IDD_MAIN), NULL, DlgProc);
}

Hi.

OK, I fixed up the code, but I'm still not getting the result I want.


If I leave the braces in for switch (LOWORD(wParam)), as follows, I get no Window

Code:

#include <windows.h>
#include "resource.h" 


BOOL CALLBACK DlgProc(HWND hwnd, UINT Message, WPARAM wParam, LPARAM lParam)
{
   switch (Message)
   {
      case WM_INITDIALOG :
         break;       
      case WM_COMMAND:
         switch (LOWORD(wParam))
            case IDOK:
               MessageBox(NULL, "You hit OK", "Note", MB_OK);
               break;
            
            case IDCANCEL:
               MessageBox(NULL, "You hit Cancel", "Note", MB_OK);
               break;
         break;
      case WM_CLOSE:
         EndDialog(hwnd, 0);
         break;
      default:
         return FALSE;
   }
	return TRUE;
}

int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,
	            LPSTR lpCmdLine, int nCmdShow)
{
   return DialogBox(hInstance, MAKEINTRESOURCE(IDD_MAIN), NULL, DlgProc);
}

If I remove the braces, I get the message box saying 'you hit cancel' from IDCANCEL.

Why am I not getting my main dialog box?

Thanks