please read this source code and tell me what is wrong

goof · 11-30-2001, 11:43 PM

This is the soruce code for a win32 prog that you enter two numbers and select your operator to go between them and then it outputs and answer. It's under 2K zipped and I appreciate anyone who will take the time to read it! Thanks!

**nvoigt** · 12-01-2001, 03:33 AM

>please read this source code and tell me what is wrong

hm... this is your compilers job. It will do it in a minute if you try.
If you don't get what the errormessage means, come back here and post it.

goof · 12-01-2001, 11:48 AM

Sorry, I should have been more specific. The program compiles fine, but doesn't work "right" ie how I want it to. I am not asking for any source code, just an explanation of what is wrong. Thanks for your time.

Garfield · 12-01-2001, 11:50 AM

How does it "not work right"? What are the symptoms?

goof · 12-01-2001, 01:19 PM

It doesn't add/subtract/multiply/divide the numbers when you enter two numbers and click a operator button. It gives out a seemingly random number, not the right answer. Here is the exec file, It not virused or anything.

maes · 12-01-2001, 04:41 PM

-> make "numone" and "numtwo" static, otherwise they will lose their value.

->your use of GetDlgItemInt is wrong
numone=GetDlgItemInt(hDlg,IDC_NUMONE,NULL,TRUE);

->it is better to check also if you change your operation (+,-,*,/)

Code:

case IDC_PLUS:
case IDC_MINUS:
case IDC_MULTIPLY:
case IDC_DIVIDE:
Calculate(hDlg,numone,numtwo);
break;

one more thing: in your "Calculate" function, check if numtwo is zero. It is safer. press the '/' button before entering a number in numtwo and see what happens

goof · 12-01-2001, 10:39 PM

Hey thanks maes, it works right now. I really appreciate it!

12-01-2001, 11:49 PM

Hey thanks maes, it works right now. I really appreciate it!

12-01-2001, 03:33 AM	#2
nvoigt the hat of redundancy hat Join Date: Aug 2001 Location: Hannover, Germany Posts: 2,769	>please read this source code and tell me what is wrong hm... this is your compilers job. It will do it in a minute if you try. If you don't get what the errormessage means, come back here and post it. __________________ hth -nv She was so Blonde, she spent 20 minutes looking at the orange juice can because it said "Concentrate." When in doubt, read the FAQ. Then ask a smart question.
nvoigt is offline

12-01-2001, 11:48 AM	#3
goof Registered User Join Date: Nov 2001 Posts: 4	Sorry, I should have been more specific. The program compiles fine, but doesn't work "right" ie how I want it to. I am not asking for any source code, just an explanation of what is wrong. Thanks for your time.
goof is offline

12-01-2001, 11:50 AM	#4
Garfield the Corvetter Join Date: Sep 2001 Posts: 1,584	How does it "not work right"? What are the symptoms? __________________ 1978 Silver Anniversary Corvette
Garfield is offline

12-01-2001, 04:41 PM	#6
maes Banned Join Date: Aug 2001 Posts: 744	-> make "numone" and "numtwo" static, otherwise they will lose their value. ->your use of GetDlgItemInt is wrong numone=GetDlgItemInt(hDlg,IDC_NUMONE,NULL,TRUE); ->it is better to check also if you change your operation (+,-,*,/) Code: case IDC_PLUS: case IDC_MINUS: case IDC_MULTIPLY: case IDC_DIVIDE: Calculate(hDlg,numone,numtwo); break; one more thing: in your "Calculate" function, check if numtwo is zero. It is safer. press the '/' button before entering a number in numtwo and see what happens
maes is offline

12-01-2001, 10:39 PM	#7
goof Registered User Join Date: Nov 2001 Posts: 4	thanks! Hey thanks maes, it works right now. I really appreciate it!
goof is offline

12-01-2001, 11:49 PM	#8
Unregistered Guest Posts: n/a	thanks! Hey thanks maes, it works right now. I really appreciate it!

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode