[C] error in RegGetValue

Hi to all..

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
#include <string.h>

..
..
..

char ControllaCartelleStartup(char chiave[]){
   
    HKEY hKey;
   
    char folder[MAX_KEY];
         
    if((RegOpenKeyEx(HKEY_LOCAL_MACHINE,
                          "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",
                          0,
                          KEY_ALL_ACCESS,
                          &hKey))!= ERROR_SUCCESS){
                             
                          MessageBox(NULL,
                                    "Errore nel leggere il registro.\n",
                                    "Errore in lettura:", // Titolo del messagebox
                                      MB_OK);
                    }//End errore nell'aprire reg
                   
                    RegGetValue(hKey,
                                "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",
                                "Common Startup",
                                RRF_RT_ANY,
                                NULL,
                                folder,
                                sizeof(folder));
                               
 
}//end ControllaCartelleStartup

---

why why and why RRF_RT_ANY is not recognized??

Quote:

---

776 C:\Programmi\Dev-Cpp\Progetti\Enumera Valori\main.c `RRF_RT_ANY' undeclared (first use in this function)

---

thanx ;)

documentation : RegGetValue

Quote:

---

dwFlags
[in] Restricts the data type of value to be queried. If the data type of the value does not meet this criteria, the function fails. This parameter can be one of the following values.

RRF_RT_ANY No type restriction.

---

Are you running Windows Server 2003 SP1 (see the 'Requirements' section at the foot of the GetRegValue msdn page)?

DAMN!!!! what should I do on Xp/9x ?

RegEnumValue untill I find the wanted value? booooooooring!!

Quote:

---

RegEnumValue untill I find the wanted value?

---

Sounds like a good idea to me.

Here is another solution ;)

gg

Why can't you use RegQueryValueEx()? Even easier is SHGetValue():

Code:

---

{
  DWORD dwType,
        dwSize = sizeof(folder) - 1;

  if (SHGetValue(HKEY_LOCAL_MACHINE,
              TEXT("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders"),
              TEXT("Common Startup"),
              &dwType,
              folder,
              &dwSize) != ERROR_SUCCESS)
    {
        // Error!
    }

    /* Make sure the returned value is nul terminated. */
    folder[dwSize / sizeof(folder[0])] = TEXT('\0');
}

---

thanx guys

(quite) working code:

Code:

---

char ControllaCartelleStartup(void){

  char folder[MAX_KEY];
 
  DWORD dwType,
        dwSize = sizeof(folder) - 1;

  if (SHGetValue(HKEY_LOCAL_MACHINE,
              "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",
              "Common Startup",
              &dwType,
              folder,
              &dwSize) != ERROR_SUCCESS);
    {
    MessageBox(NULL,
              "Error.\n",
              "Error while reading:", // Titolo del messagebox
              MB_OK);
    }

    folder[dwSize / sizeof(folder[0])] = TEXT('\0');
   
    printf("%s\n", folder);
}

---

As I said it is a quite-working code.. SHGetValue returns something != ERROR_SUCCESS. Anyway "folder" contains the wanted common startup link.. So every time I call the function I have an Error PopUp.. Any suggestion about why it doesn't return ERROR_SUCCESS?

I thought it was SHGet.. so I rewrited it a bit :

Code:

---

char BufferCartellaCommonStartup(void){

  HKEY hKey;
 
  char folder[MAX_KEY];
 
  DWORD dwSize = sizeof(folder) - 1;

  if((RegOpenKeyEx(HKEY_LOCAL_MACHINE,
                  "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",
                  0,
                  KEY_ALL_ACCESS,
                  &hKey))!= ERROR_SUCCESS){
                         
        MessageBox(NULL,
                  "Errore nel leggere il registro.\n",
                  "Errore in lettura:", // Titolo del messagebox
                  MB_OK);
        }
       
  if (RegQueryValueEx(hKey,
                      "Common Startup",
                      NULL,
                      NULL,
                      folder,
                      &dwSize) != ERROR_SUCCESS); 
       
        {MessageBox(NULL,
                  "Errore nel leggere il link al CommonStartup.\n",
                  "Errore in lettura:", // Titolo del messagebox
                  MB_OK);
        }

    RegCloseKey(hKey);
   
    folder[dwSize / sizeof(folder[0])] = '\0';
   
    printf("%s\n", folder);
   
}//end ControllaCartelleStartup

---

and again the same.. it works (I get the common startup link) but it appears again the error message box... RegQueryValueEx seems to fail :(

Code:

---

  if (SHGetValue(HKEY_LOCAL_MACHINE,
              "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Expl  orer\\Shell Folders",
              "Common Startup",
              &dwType,
              folder,
              &dwSize) != ERROR_SUCCESS); // <<------ You don't want this!

---

Sorry mate, this was a typo in my original post. The semicolon ends the if clause. Some compilers will give a warning about this oddly placed semicolon.

:D hahah yesterday I lost 30 mins for this stupid thing!!
thanx for the solution, I feel stupid :D

I've just realised that you shouldn't be querying the registry for this information anyway. This is the correct method to get a shell folder path:

Code:

---

TCHAR folder[MAX_PATH];
SHGetSpecialFolderPath(NULL, folder, CSIDL_COMMON_STARTUP, TRUE);

---

ah excellent!!!! :D

ooh mayi god...how is this working??
i got this error
error C2664: 'RegQueryValueExA' : cannot convert parameter 5 from 'char *' to 'LPBYTE'

5th parameter you are passing is char*, but LPBYTE exptected...

~calvin

Cast it to BYTE* and it will work.
BYTE is really unsigned char anyway.