EnumResourceTypes Error

I've compiled a ver simple Windows program in C which uses a resource. I can find the resource easily just doing:

Code:

byte* data;
HRSRC hResInfo = FindResource(NULL, "RCDATA_0", RT_RCDATA);
if (hResInfo==NULL) {
    MessageBox(NULL, "FindResource has failed!", "", MB_OK);    
    return -1;
}
HGLOBAL hResData = LoadResource(NULL, hResInfo);
if (hResData==NULL) {
    MessageBox(NULL, "LoadResource has failed!", "", MB_OK);    
    return -1;
}
data = LockResource(hResData);
if (data==NULL) {
    MessageBox(NULL, "LockResource has failed!", "", MB_OK);
    return -1;
}

For testing purpose I'm executing the previous code when I clic a simple button, and it all works perfectly.


But now I want to create a resource list, and I'm getting an error using EnumResourceTypes. This is the way I'm using this function:

Code:

if (EnumResourceTypes(NULL, (ENUMRESTYPEPROC)EnumResTypeProc, 0)==0) {
    MessageBox(NULL, "EnumResourceTypes has failed!", "", MB_OK);
    return -1;
}

And this is the callback function:

Code:

BOOL CALLBACK EnumResTypeProc(HMODULE hModule, LPTSTR lpszType, LONG_PTR lParam)
{
    MessageBox(NULL, lpszType, "", MB_OK);
    return TRUE;
}

The GetLastError function returns 998, "Invalid access to memory location". What is the problem?

Looking at the MSDN Docs for the callback function

Code:

BOOL CALLBACK EnumResTypeProc(          HMODULE hModule,
    LPTSTR lpszType,
    LONG_PTR lParam
);

If IS_INTRESOURCE( lpszType) is TRUE, lpszType specifies the integer identifier of the given resource. Otherwise, it is a pointer to a null-terminated string. If the first character of the string is a pound sign ( #), the remaining characters represent a decimal number that specifies the integer identifier of the resource. For example, the string " #258" represents the identifier 258.

I guess this is one situation where a string isnt always a string!

Error occurs when EnumResourceTypes is executed. EnumResTypeProc isn't even called.

Probably because you are calling it with 0 as the first param

Code:

#include <windows.h>
#include <tchar.h>
#include <sstream>

BOOL CALLBACK EnumResTypeProc(HMODULE hModule, LPTSTR lpszType, LONG_PTR lParam)
{	
	if(IS_INTRESOURCE(lpszType))
	{
		std::basic_stringstream<TCHAR> StringStream;
		StringStream << reinterpret_cast<INT>(lpszType);
		MessageBox(0, StringStream.str().c_str(),_T("Type Found"), MB_OK);
	}
	else
	{
		MessageBox(0, lpszType,_T("Type Found"), MB_OK);
	}
    return TRUE;
}


int WINAPI WinMain(HINSTANCE hInst,HINSTANCE,LPSTR,int)
{
	OPENFILENAME OpenFileName = {sizeof(OPENFILENAME)};
	TCHAR NameBuff[MAX_PATH + 1] = {0};
	
	OpenFileName.lpstrFile = NameBuff;
    OpenFileName.nMaxFile = MAX_PATH;
	OpenFileName.lpstrFilter = _T("Programs\0*.exe\0DLLs\0*.dll\0");
	OpenFileName.nFilterIndex = 1;
	OpenFileName.Flags = OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST;

	if(!GetOpenFileName(&OpenFileName))
		return -1;

	HMODULE Module = LoadLibrary(NameBuff);
	if(Module == 0)
	{
		MessageBox(0,_T("Unable to load!"),_T(""), MB_OK);
		return -1;
	}

	if(EnumResourceTypes(Module,EnumResTypeProc, 0)==0)
	{
		MessageBox(0,_T("EnumResourceTypes has failed!"),_T(""), MB_OK);
		FreeLibrary(Module);
		return -1;
	}
	FreeLibrary(Module);
	return 0;
}

First parameter of EnumResourceTypes is NULL because the resource is within the current process (a rc file compiled and linked with the application)

The question is:
Why does FindResource(NULL, "RCDATA_0", RT_RCDATA); work but
EnumResourceTypes(NULL, (ENUMRESTYPEPROC)EnumResTypeProc, 0) fail?

Dont know, but I got it to work for me in the above example.

Try substituting the NULL in the first param with GetModuleHandle(0). See if that fares any better

I've tried it, but it still doesn´t work

Well I dont know what your doing wrong.


Here's an example that works fine

Here is my example. If you use the enumRCDATAResources function you get an error, but if you use the handleRCDATAResources function, the resource is accesed without errors

Go back and read Fordy's first post and the sample in his second post, or even the sample in his fourth post!

Code:

    MessageBox(NULL, lpszType, "", MB_OK);

The GetLastError function returns 998, "Invalid access to memory location"

1. You call MessageBox() with an invalid 'string' pointer.
2. EnumResourceTypes() is kind enough to catch the resulting exception.
3. It returns failure with the accurate error "Invalid access to memory location".

>> EnumResTypeProc isn't even called. <<

Yes it is. A correct call to MessageBox() or a debug breakpoint would confirm this.

The problem is in EnumResTypeProc. You cannot assume that lpszType is a string, it might be INT_RESOURCE.
INT_RESOURCE is an integer disguised inside a string pointer - ugly but there you have it.

So the proper implementation of EnumResTypeProc would be:

Code:

BOOL CALLBACK EnumResTypeProc(HMODULE hModule, LPTSTR lpszType, LONG_PTR lParam)
{
    if (! IS_INTRESOURCE(lpszType))
    {
        MessageBox(NULL, lpszType, "", MB_OK);
    }
    
    return TRUE;
}

The thread you replied to is 7 years old... I'm guessing he's solved the problem by now.