Recusively delete registry keys

Hello,

I've been trying to delete registry keys, including all their subkeys, without resorting to SHDeleteKey (Which isn't directly Windows 95 compatible). So far I've come up with:-

Code:

int DeleteKey(HKEY hKey, char *szSubKey)
{
	char szKeyDelete[255];
	unsigned long ulSize = 255;
	DWORD dwIndex = 0;
	HKEY hKeySub;

	if (!RegOpenKeyEx(hKey, szSubKey, 0, DELETE | KEY_ENUMERATE_SUB_KEYS, &hKeySub))
	{
		while (!RegEnumKeyEx(hKeySub, dwIndex, szKeyDelete, &ulSize, NULL, NULL, NULL, NULL))
		{
			DeleteKey(hKeySub, szKeyDelete);
			ulSize = 255;
			dwIndex++;
		}

		RegCloseKey(hKeySub);
		RegDeleteKey(hKey, szSubKey); 
		return TRUE;
	}
	else
		return FALSE;

}

This manages to delete just one of the main subkeys of a key I'm trying to delete.

Is there anything here that might be problematic or wrong that I'm not seeing?

You could try enumerating the keys in reverse order.

As a side note, anyone running Windows 95 without IE4 is unlikely to be installing new software.

You could try NOT incrementing dwIndex.

As a side not, you should make the szKeyName buffer 256 chars long, not 255, to make space for a \0-character.
The registry is very confusing there, the programmers must have been on drugs. The lpcName parameter:

This size should include the terminating null character. When the function returns, the variable pointed to by lpcName contains the number of characters stored in the buffer. The count returned does not include the terminating null character.

The maximum key name size:

The maximum size of a key name is 255 characters.

+ NUL = 256.


And there's also this detail concerning your problem:

While an application is using the RegEnumKeyEx function, it should not make calls to any registration functions that might change the key being enumerated.

But I don't quite believe it.

Originally posted by CornedBee
You could try NOT incrementing dwIndex.

You, CornedBee, are a star. Why do all my problems have such simple answers...

Ha! You were incrementing your index while the delete call was shifting the keys down one at a time as they were being deleted! Were you skipping every other one?

tmode -nopause