C - Win32 problem writing in ListBox

Hi all,


I have a generic WndProc() func running and I have a Dialog Box with a ListBox in it.
I enter a Menu Item to open the Dialog Box and enter a specific function I created to fill the ListBox

Code:

        BOOL CALLBACK FillListBox(HWND hWnd, UINT messg, WPARAM wParam, LPARAM lParam);

The problem i'm facing, is the fact that while I have the Dialog Box opened, it keeps revisiting the WndProc() function and coming back to the FillListBox() in an infinit cycle, causing it to fill the ListBox numerous times.

Is there a better way to treat the ListBox in the Dialog Box, or a way to only enter the FillListBox() function once?

Thanks in advance,

keyboarder
P.S. I tried creating a modal and non-modal Dialog Box and it still cycles.

Can you show us more than just the function prototype?
There's not enough to go on...

Here's how I open the DialogBox:

Code:

hDialog = CreateDialog(hInstance, MAKEINTRESOURCE(ID_DIALOG_TOP10), hWnd, (DLGPROC) Top10 );
					ShowWindow(hDialog,SW_SHOW);

This is the funcion. when the dialog box is opened, it keeps writing into the ListBox

Code:

BOOL CALLBACK Top10(HWND hWnd, UINT messg, WPARAM wParam, LPARAM lParam){
	int i = 0;

	for(i=0;i<10;i++){
		SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,i,names[i]);
	}

	switch (messg) 
	{
		case WM_COMMAND:
			if(LOWORD(wParam) == IDSAIR){
				EndDialog(hWnd,0);
				DestroyWindow(hWnd);
			}
			break;

		case WM_CLOSE:
			EndDialog(hWnd,0);
			DestroyWindow(hWnd);
			break;
		default:
			break;
	}
	return 0;
}

The names I used previously were generic names. These are the actual ones

Originally Posted by keyboarder

Here's how I open the DialogBox:

Code:

hDialog = CreateDialog(hInstance, MAKEINTRESOURCE(ID_DIALOG_TOP10), hWnd, (DLGPROC) Top10 );
                    ShowWindow(hDialog,SW_SHOW);

This is the funcion. when the dialog box is opened, it keeps writing into the ListBox

Code:

BOOL CALLBACK Top10(HWND hWnd, UINT messg, WPARAM wParam, LPARAM lParam){
    int i = 0;

    for(i=0;i<10;i++){
        SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,i,names[i]);
    }

    switch (messg) 
    {
        case WM_COMMAND:
            if(LOWORD(wParam) == IDSAIR){
                EndDialog(hWnd,0);
                DestroyWindow(hWnd);
            }
            break;

        case WM_CLOSE:
            EndDialog(hWnd,0);
            DestroyWindow(hWnd);
            break;
        default:
            break;
    }
    return 0;
}

The names I used previously were generic names. These are the actual ones

Well, your dialog procedure sends 10 messages to itself, which in turn generates 10 more messages, ad infinitum. Hint: You can control the update of the list box by monitoring the messages (ie: WM_XXX) sent to your callback function.

Got it Thank you very much!

And what is the tipe of message? What do I put in the XXXX part of WM_XXXX to treat these messages?

Thanks again for the help

Originally Posted by keyboarder

And what is the tipe of message?

Think about it. What message is sent to a dialog window when it is created?

I guess WM_CREATE
ok gonna try it thanks for the teaching method

Originally Posted by keyboarder

I guess WM_CREATE
ok gonna try it

Nope. Dialog boxes don't process that one. Try again!

WM_INITDIALOG

thanks google

Originally Posted by keyboarder

Here's how I open the DialogBox:
This is the funcion. when the dialog box is opened, it keeps writing into the ListBox

Because it's right in the callback and is executed everytime windows stends a message.

Code:

BOOL CALLBACK Top10(HWND hWnd, UINT messg, WPARAM wParam, LPARAM lParam){
	switch (messg) 
	{
 
// see here
                  case WM_INITDIALOG :
                            for(int i=0;i<10;i++)
                                SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,i,names[i]);
                                return TRUE;



		case WM_COMMAND:
			if(LOWORD(wParam) == IDSAIR){
				EndDialog(hWnd,0);
				DestroyWindow(hWnd);
			}
			break;

		case WM_CLOSE:
			EndDialog(hWnd,0);
			DestroyWindow(hWnd);
			break;
		default:
			break;
	}
	return 0;
}

I don't get it... something must be missing :S

I have to char arrays:

Code:

char names[10][50] = { "Julieta", "Martin", "Samanta", "Ruben", "Franco", "Sandra", "Marta", "Ofélia", "Carlos", "Fabiana" };
static char rank[10][3] = {"1º","2º","3º","4º","5º","6º","7º","8º","9º","10º"};

And I have 2 Listboxes in the DialogBox. I'm writing one of the arrays in each box with the following:

Code:

case WM_INITDIALOG:
			for( i=0 ; i<10 ; i++){
				SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,NULL,names[i]);
				SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,NULL,rank[i]);
                        }
			break;

The first array it gets it right, but the second one it writes:

___________
10º
1º
2º
3º
4º
5º
6º
7º
8º
9º
____________

Starts on the last position, and only then starts normally.... what the hell?

Originally Posted by keyboarder

I don't get it... something must be missing :S

I have to char arrays:

Code:

case WM_INITDIALOG:
			for( i=0 ; i<10 ; i++){
				SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,NULL,names[i]);
				SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,NULL,rank[i]);
                        }
			break;

The first array it gets it right, but the second one it writes:

Look closely... you are sending two different strings to the same listbox index... the second overwrites the first.
Also in your dialog box turn off the LBS_SORT parameter.

lool sorry, I must have changed it before posting it. In the code I'm using, it's correct:

Code:

case WM_INITDIALOG:
			for( i=0 ; i<10 ; i++)
			{
				SendDlgItemMessage(hWnd, IDC_LIST1,LB_ADDSTRING,NULL,names[i]);
				SendDlgItemMessage(hWnd, IDC_LIST2,LB_ADDSTRING,NULL,rank[i]);
			}
			break;

this looks more like a memory access problem. If I change the

Code:

char rank[10][3] = {"1º","2º","3º","4º","5º","6º","7º","8º","9º","10º"};

to

Code:

char rank[11][3] = {"1º","2º","3º","4º","5º","6º","7º","8º","9º","10º","\0"};

Thanks all!!! I FIGURED IT OUT. It was a dumb propriety "Sort". just changed it to false. Thank you for all the intel