using listboxes and fgetc()

hey I am using listboxes and fgetc to add a comma delimited string to my listbox but I am always getting segmentation faults, here is the code (please help I am almost done with this app).

Code:

hwndlistbox = CreateWindow(TEXT("Listbox"), NULL, WS_CHILD | WS_VISIBLE | WS_BORDER | ES_MULTILINE,
				50, 70, 170, 140, hwnd, (HMENU) ID_EDIT,
				NULL, NULL);
                char buff1;
                
                 pfile = fopen("C:\\reminder\\data\\backup1.xls", "r");
                 atoi(&buff1)
                 while( (buff1 = fgetc(pfile)) != EOF)
{
   /* filter out unwanted characters*/

       SendMessage(hwndlistbox, LB_ADDSTRING, 0, (LPARAM)buff1);
}

atoi() expects a pointer to a char ARRAY, which ends with a \0 character.

A single character (unless it is set to \0) is not valid (even though the code is syntactically correct).

You need to focus more on what the function actually does, rather than just declaring variables and passing parameters with the correct type.

ES_MULTILINE is not a listbox style.

Originally Posted by Salem

atoi() expects a pointer to a char ARRAY, which ends with a \0 character.

A single character (unless it is set to \0) is not valid (even though the code is syntactically correct).

You need to focus more on what the function actually does, rather than just declaring variables and passing parameters with the correct type.

I agree, but if being picky...

atoi() will stop as soon as it hits a character that is not a digit or part of a number (which depends on the local settings ie is a decimal point a period or a comma), it does not 'require' a null terminated string.

I use this 'feature' quite a bit (ie iDate = atoi("20100714_SomeFileName.ext") is valid in MSVC)

I would not use a single character as I would be worried about what random value was in the next memory address (if it happens to be a digit then....)