Thread: Resource file issues

Ok, so I recently took up windows programming again and wanted to create a simple modeless dialog. I downloaded Resedit to make the file and am using Visual C++ Express 2008 to compile and debug the application. However, my window looks funny for some reason. The window is sort of not there, no title bar or close buttons, no window around the controls. the controls are just hanging mid-screen with nothing around them. I would suppose it has something to do with my resource script but i cant figure out what is going on. Here is the code i am using to load the window:

Code:

#include <windows.h>
#include <winsock.h>
#include <process.h>
#include <shellapi.h>
#include <commctrl.h>

#include <stdio.h>
#include <string.h>

#include "resource.h"

#define Alert(x) MessageBox(NULL, x, "Alert:", MB_OK);
//#define ID_TASKICON 1010

//structures
struct THREADOPCTRL
{
	bool operate;
	bool operating;
};

//global variables
NOTIFYICONDATA tray_icon;
OPENFILENAME set_file;
bool error_log = false, client_info = false;
THREADOPCTRL serv_ctrl;

//function declarations
void FlipState (bool&);

//window procedures
BOOL CALLBACK SettingsWindowProc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch (msg)
	{
	case WM_COMMAND:

		switch (LOWORD (wParam))
		{
		case IDSAVE:

			Alert("You pressed ok!");
			break;

		case IDCANCEL:

			Alert ("You pressed cancel!");
			break;

		case IDC_ERRORLOG:

			FlipState (error_log);
			
			if (error_log == true)
			{
				Alert("I will make an error log!");
			}

			else if (error_log == false)
			{
				Alert("I will not make an error log!");
			}

			break;
		}
		break;

	case WM_CLOSE:

		DestroyWindow (hwnd);
		break;

	case WM_DESTROY:

		PostQuitMessage (0);
		break;

	default:

		return TRUE;
	}

	return TRUE;
}

int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nShowCmd)
{
	HWND SettingsDialog;
	MSG msg;

	serv_ctrl.operate = true;
	serv_ctrl.operating = false;

	SettingsDialog = CreateDialog (GetModuleHandle (NULL), MAKEINTRESOURCE (MAIN_DIALOG), NULL, SettingsWindowProc);

	while (GetMessage (&msg, NULL, 0, 0))
	{
		TranslateMessage (&msg);
		DispatchMessage  (&msg);
	}

	return msg.wParam;
}

void FlipState (bool& to_filp)
{
	to_filp = !to_filp;
}

This is a work in progress so i know it is VERY incomplete. If the error is in my code i would much appreciate if someone would be able to point it out. If anyone needs more information, please feel free to ask. I plan to add a tray icon and some other functionality as well. thanks all!

Moin Sir,

try this, please ...

Code:

	while (GetMessage (&msg, NULL, 0, 0) > 0)
	{
		if (IsDialogMessage (SettingsDialog, &msg))
		{
			TranslateMessage (&msg);
			DispatchMessage  (&msg);
		}
	}

and maybe try ShowWindow/UpdateWindow after the call to CreateDialog ...


Regards
Greenhorn

That had no effect. i actually omitted it because I was having a problem with the Dialog Procedure. If it helps at all this also happens when I use modal dialogs created with ResEdit. I dont understand it. is this a problem with the editor or with visual c++? I seem to remember trying to use it with Dev-C++ too and had the same problem. sometimes it worked, sometimes it didnt.

Originally Posted by adeyblue

Returning TRUE tells Windows that you've handled the message

Not 100% true. Many msgs expect FALSE on processing (WM_CHAR) and you should always check MSDN.

You should call the default processor and let it do the work.

Code:

default: 
            return DefWindowProc(hwnd, msg, wParam, lParam);

Ok. I made some changes, just to get the window to show up right. The changes i made caused the window to show up, but now it wont move, minimize, or close for me w/ the DefWindowProc as it should:

Code:

#include <windows.h>
#include <winsock.h>
#include <process.h>
#include <shellapi.h>
#include <commctrl.h>

#include <stdio.h>
#include <string.h>

#include "resource.h"

#define Alert(x) MessageBox(NULL, x, "Alert:", MB_OK);
//#define ID_TASKICON 1010

//structures
struct THREADOPCTRL
{
	bool operate;
	bool operating;
};

//global variables
NOTIFYICONDATA tray_icon;
OPENFILENAME set_file;
bool error_log = false, client_info = false;
THREADOPCTRL serv_ctrl;

//function declarations
void FlipState (bool&);

//window procedures
BOOL CALLBACK SettingsWindowProc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
	switch (msg)
	{
	case WM_COMMAND:

                break;

	case WM_CLOSE:

		DestroyWindow (hwnd);
		break;

	case WM_DESTROY:

		PostQuitMessage (0);
		break;

	default:

		return DefWindowProc (hwnd, msg, wParam, lParam);
	}

	return TRUE;
}

int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nShowCmd)
{
	HWND SettingsDialog;
	MSG msg;

	serv_ctrl.operate = true;
	serv_ctrl.operating = false;

	SettingsDialog = CreateDialog (GetModuleHandle (NULL), MAKEINTRESOURCE (MAIN_DIALOG), NULL, SettingsWindowProc);

	while (GetMessage (&msg, NULL, 0, 0))
	{
                if (!IsDialogMessage (SettingsDialog, &msg))
                {
		         TranslateMessage (&msg);
		         DispatchMessage  (&msg);
                }
	}

	return msg.wParam;
}

void FlipState (bool& to_filp)
{
	to_filp = !to_filp;
}

well at least the window is solid now...

Sry to bump my own post, but i just found this on theForger's Win32 API Tutorial site:

Most of the same message handling rules apply to dialogs created with CreateDialog() as with DialogBox(), don't call DefWindowProc(), return FALSE for messages you don't handle and TRUE for those you do.

So this is an inaccurate statement. just wanted to let u guys know that.

Originally Posted by novacain

Not 100% true. Many msgs expect FALSE on processing (WM_CHAR) and you should always check MSDN.

You should call the default processor and let it do the work.

Code:

default: 
            return DefWindowProc(hwnd, msg, wParam, lParam);

Originally Posted by xixpsychoxix

So this is an inaccurate statement. just wanted to let u guys know that.

Sorry my bad, missed the use of CreateDialog() in the OP.

Hope it did not cost you too much time.