Printing from a Rich Edit control

I have an application with a Rich Edit Control. My "print" function works but I get a small square at the end of each line on the printout.

Any ideas as to how to get rid of them? I don't know if it the way I am printing or the way the Rich Edit control is set up.

I also noticed that, if I select the text in the control, there is a blank space inserted after each line of text I type in.

Sounds like you're adding a \n or \r when you don't need to.

I can open a blank form and type in a word, when I print, it has the square at the end of the word. I am not adding anything programmatically.

Is it printing the null character ('\0')?

I have no way of telling which character it is. I am assuming it is the '\0' or '\n' but I do not know why or how it is getting in there. If I open a text file in notepad, it isn't there but the same file in my control has them.

Could I be doing something wrong here:

Code:

---

TextOut (pd.hDC, 0, yChar * iLine, pstrBuffer,
              (int) SendMessage (hwndEdit, EM_GETLINE,
              (WPARAM) iLineNum, (LPARAM) pstrBuffer));

---

Here is the print function:

Code:

---

BOOL PrintTheFile (HINSTANCE hInst, HWND hwnd, HWND hwndEdit,
                      PTSTR szTitleName)
{
    static DOCINFO  di = { sizeof (DOCINFO) } ;
    static PRINTDLG pd ;
    BOOL            bSuccess ;
    int            yChar, iCharsPerLine, iLinesPerPage, iTotalLines,
                    iTotalPages, iPage, iLine, iLineNum ;
    PTSTR          pstrBuffer ;
    TCHAR          szJobName [64 + MAX_PATH] ;
    TEXTMETRIC      tm ;
    WORD            iColCopy, iNoiColCopy ;

          // Invoke Print common dialog box
   
    pd.lStructSize        = sizeof (PRINTDLG) ;
    pd.hwndOwner          = hwnd ;
    pd.hDevMode            = NULL ;
    pd.hDevNames          = NULL ;
    pd.hDC                = NULL ;
    pd.Flags              = PD_ALLPAGES | PD_COLLATE |
                              PD_RETURNDC | PD_NOSELECTION ;
    pd.nFromPage          = 0 ;
    pd.nToPage            = 0 ;
    pd.nMinPage            = 0 ;
    pd.nMaxPage            = 0 ;
    pd.nCopies            = 1 ;
    pd.hInstance          = NULL ;
    pd.lCustData          = 0L ;
    pd.lpfnPrintHook      = NULL ;
    pd.lpfnSetupHook      = NULL ;
    pd.lpPrintTemplateName = NULL ;
    pd.lpSetupTemplateName = NULL ;
    pd.hPrintTemplate      = NULL ;
    pd.hSetupTemplate      = NULL ;
   
    if (!PrintDlg (&pd))
          return TRUE ;

    if (0 == (iTotalLines = SendMessage (hwndEdit, EM_GETLINECOUNT, 0, 0)))
        {       
          return TRUE ;
        }
          // Calculate necessary metrics for file
   
    GetTextMetrics (pd.hDC, &tm) ;
    yChar = tm.tmHeight + tm.tmExternalLeading ;
   
    iCharsPerLine = GetDeviceCaps (pd.hDC, HORZRES) / tm.tmAveCharWidth ;
    iLinesPerPage = GetDeviceCaps (pd.hDC, VERTRES) / yChar ;
    iTotalPages  = (iTotalLines + iLinesPerPage - 1) / iLinesPerPage ;

          // Allocate a buffer for each line of text
   
    pstrBuffer = (PSTR)malloc(sizeof (TCHAR) * (iCharsPerLine + 1)) ;
          // Display the printing dialog box
   
    EnableWindow (hwnd, FALSE) ;
   
    bSuccess  = TRUE ;
    bUserAbort = FALSE ;
   
    hDlgPrint = CreateDialog (hInst, TEXT ("PrintDlgBox"),
                              hwnd, PrintDlgProc) ;

    SetDlgItemText (hDlgPrint, IDC_RICHEDIT, szTitleName) ;
    SetAbortProc (pd.hDC, AbortProc) ;

          // Start the document
    GetWindowText (hwnd, szJobName, sizeof (szJobName)) ;
    di.lpszDocName = szJobName ;
   
    if (StartDoc (pd.hDC, &di) > 0)
    {
              // Collation requires this loop and iNoiColCopy

          for (iColCopy = 0 ;
              iColCopy < ((WORD) pd.Flags & PD_COLLATE ? pd.nCopies : 1) ;
              iColCopy++)
          {
              for (iPage = 0 ; iPage < iTotalPages ; iPage++)
              {
                    for (iNoiColCopy = 0 ;
                        iNoiColCopy < (pd.Flags & PD_COLLATE ? 1 : pd.nCopies);
                        iNoiColCopy++)
                    {
                              // Start the page

                        if (StartPage (pd.hDC) < 0)
                        {
                              bSuccess = FALSE ;
                              break ;
                        }

                              // For each page, print the lines
                       
                        for (iLine = 0 ; iLine < iLinesPerPage ; iLine++)
                        {
                              iLineNum = iLinesPerPage * iPage + iLine ;
                             
                              if (iLineNum > iTotalLines)
                                  break ;
                             
                              *(int *) pstrBuffer = iCharsPerLine ;
                             
                              TextOut (pd.hDC, 0, yChar * iLine, pstrBuffer,
                                      (int) SendMessage (hwndEdit, EM_GETLINE,
                                      (WPARAM) iLineNum, (LPARAM) pstrBuffer));
                        }
                       
                        if (EndPage (pd.hDC) < 0)
                        {
                              bSuccess = FALSE ;
                              break ;
                        }
                       
                        if (bUserAbort)
                              break ;
                    }
                    SendMessage( hwnd, EM_SETSEL, 0, 0 );
                    if (!bSuccess || bUserAbort)
                        break ;
              }
             
              if (!bSuccess || bUserAbort)
                    break ;
          }
    }
    else
          bSuccess = FALSE ;
   
    if (bSuccess)
          EndDoc (pd.hDC) ;
   
    if (!bUserAbort)
    {
          EnableWindow (hwnd, TRUE) ;
          DestroyWindow (hDlgPrint) ;
    }
   
    free (pstrBuffer) ;

    DeleteDC (pd.hDC) ;
   
    return bSuccess && !bUserAbort ;
}

---

Could it have to do with opening a text file in a rich edit control? There appears to be a blank space at the end of each line in the rich edit control. I also see it (by selecting all text) in WordPad. It does not appear in NotePad though.

I have seen this problem before (when I was viewing a txt file, a square came up where each newline should have been. that looked much worse than the prob you are having). It is a whitespace character, probably '\n', you could try omitting the last character of each line (might work).

Quote:

---

Originally Posted by JustMax

pstrBuffer = (PSTR)malloc(sizeof (TCHAR) * (iCharsPerLine + 1)) ;

---

You forgot to check that this succeeds and also cast it to the wrong type, you wanted PTSTR instead.

I think thei issue is that you are using the number of characters copied to the buffer, which includes the /n/r or /0
Also you will print a NULL buffer if there is no text of the Send message fails.

Try

Code:

---

                           
int iLen=SendMessage (hwndEdit, EM_GETLINE, (WPARAM) iLineNum, (LPARAM) pstrBuffer);
if(iLen)//we got some text
{
    TextOut (pd.hDC, 0, yChar * iLine, pstrBuffer, lstrlen(pstrBuffer));
}

---

Thank you all, Novacain has eased the pain. I now have a good looking printout.