Printable View
I've learned at school that i should avoid Global declarations... But now with windows API i noticed all variables to be used or updated in WM_PAINT after every WM_COMMAND need to be global, otherwise won't update... Is there a limit here? and is my perception correct
They don't need to be global - they just need to be the same variable. Local variables in a function are "recreated" every time the function is called.Quote:
Originally Posted by csonx_p
You have local variables that are static, which means that the variable remains each time.
There are also, usually, many other ways to have local but persistent storage - the typical way is to pass something from a "never ending" function to the lower level function, which is some sort of struct that contains your actual "global" variables.
--
Mats
Also, dont listen too much to the 'no global variables' camp. While you should try to minimize the number you use, they are a tool to be used as necessary. One of the issues with global variables is that you can take 2 perfectly legitimate cpp files from different projects, put them into a new project and get compile errors because they happen to use the same name for a global variable. Its also kind of a pain to extern alot if you use too many global variables, but there are some times when its just too simple a solution not to use one. Like most things in life, listen to the advice of those who have gone before, but don't take it as gospel.
Mats i declare a variable to contain a handle to an edit control inside the WinProc, initialized within WM_CREATE. But i intend to use this variable within WM_PAINT and would sometimes refresh (call InvalidateRect) WM_PAINT.. I noticed that i don't get it initialized properly unless i move its declaration globally. So you suggest i should declare it as static rather within WinProc? There are few others which would need same resolutionQuote:
Originally Posted by matsp
Like Abachler, I don't have a religious conviction that global variables are all bad. They are, to again echo Abachler, a tool. A hammer is a tool - if you use it incorrectly your thumb, or the walls in your house, may get damaged. But use it correctly with nails, and you can build a house. A knife can kill people, but it's also a useful tool to cut up your meat or vegetables to make your dinner.
So, used with care and for the right reasons, global variables are "OK". There are a few problems with global variables:
1. It's hard to know when and where they get changed.
2. There is a risk of name collisions when merging source from different places.
3. It is harder to change the behaviour of the code if global variables are used too much - for example if you want to create another of something, it's quite easy when it's being passed around as a parameter to various functions, but if it's one global variable, you need to create another variable and then go around and change all the code that uses the first variable to KNOW which one to use at what times.
--
Mats
And you are using C?Quote:
Originally Posted by csonx_p
Yes, supposedly... Well my files are .cpp (whilst writing c code) cause i can't compile .c files successfully in Visual Studio 2005 standard Edition...Quote:
Originally Posted by Elysia
Why not - Visual Studio (all versions, including 2008) can compile C code. Presumably you are either using C++ features, or something else is wrong in your code... What error(s) do you get?Quote:
Originally Posted by csonx_p
--
Mats
I just renamed the .cpp file to .c and hit compile, I get a pre-compile header error... turning them of gives billion errorsQuote:
Originally Posted by matsp
Yeah, you probably need to do a clean before you build (rebuild all or whatever it's called in MS speak), as the precompiled headers will "know" whether you are using C++ or C when compiling the header, so if you just rename the file, it will still think the precompiled header is the same [my personal opinion is that precompiled headers are only worth-wile in big projects - in small projects the saving is pretty small, really].Quote:
Originally Posted by csonx_p
--
Mats
Visual Studio 2005 compiles well if you add a c file but as console application, once you choose windows application then is a problem.... Is there a step by step on how to compile windows application with .c files?Quote:
Originally Posted by matsp
It shouldn't be a problem. But seeing as I don't have MSVC (well, I have V6.0 on my machine, but I don't use it, and it would probably be quite different from 2005 anyways) here at work, I can't really help.Quote:
Originally Posted by csonx_p
--
Mats
It really shouldn't matter. Rename it .c, then do a rebuild.
If you get any errors, post them.
I just copied the first few...Quote:
Originally Posted by Elysia
They all come from a file 'cstdio' .....Code:1>c:\program files\microsoft visual studio 8\vc\include\cstdio(25) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(25) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(25) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(25) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(25) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(25) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(26) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(26) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(26) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(26) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(26) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(26) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(27) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(27) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(27) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(27) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(27) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(27) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(28) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(28) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(28) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(28) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(28) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(28) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(29) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(29) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(29) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(29) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(29) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(29) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(30) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(30) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(30) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(30) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(30) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(30) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(31) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(31) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(31) : error C2143: syntax error : missing '{' before ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(31) : error C2059: syntax error : ':'
1>c:\program files\microsoft visual studio 8\vc\include\cstdio(31) : error C2143: syntax error : missing '{' before ':'
my Program
Code://=============================================================================
//FRS Range - Copyright ©2008 Songezo Nkukwana
//=============================================================================
//#include "stdafx.h"
#include <windows.h> //include all the basics
#include <tchar.h> //string and other mapping macros
#include <string>
#include <math.h>
// Define structure for colors
typedef struct rgbColors {
int R,G,B;
} RGBColor;
COLORREF g_rgbBackground = RGB(0xD3,0xD3,0xD3); // Set to grey
#define MAXCOLOR 10
//define an unicode string type alias
typedef std::basic_string<TCHAR> ustring;
// ======================================================
// ENUM types
//Edit control id's
enum {
IDCE_SINGLELINE=200,
IDCE_SINGLELINE1,
IDCE_SINGLELINE2,
IDCE_SINGLELINE3,
IDCE_SINGLELINE4,
IDCE_SINGLELINE5,
IDCE_SINGLELINE6,
IDCE_SINGLELINE7,
IDCE_SINGLELINE8,
IDCE_SINGLELINE9,
IDCE_SINGLELINE10,
IDCE_SINGLELINE11,
IDCE_SINGLELINE12,
IDCE_SINGLELINE13,
IDCE_SINGLELINE14,
IDCE_SINGLELINE15,
IDCE_MULTILINE,
IDBC_DEFPUSHBUTTON,
IDBC_PUSHBUTTON,
IDBC_QUITBUTTON,
IDBC_UPDATEBUTTON,
IDBC_CHECKBOX_C,
IDBC_CHECKBOX_H,
IDBC_CHECKBOX_V,
IDBC_AUTORADIOBUTTON,
IDBC_GROUPBOX,
IDBC_ICON,
IDBC_BITMAP
};
// ==============================================================
// enum constants
// Radar Antenna indices
enum {
AZIM,
ELEV,
GAIN,
RPM,
HGTH
};
// Radar Transmitter/Receiver indices
enum {
FREQ,
WVLNTH,
PP,
PW,
PRF,
BNDWTH,
NF,
LOSS
};
// Target indices
enum {
RCS,
HOT
};
// General Parameters indices
enum {
FARE,
DP
};
//=============================================================================
// Function declarations
LRESULT CALLBACK WndProc(HWND,UINT,WPARAM,LPARAM);
inline int ErrMsg(const ustring&);
double GetValue(HWND hEdit,int nCtrlID);
double Round(double dbVal, int nPlaces);
BOOL SelectedButton(HWND hwnd, int CheckID);
void EditBoxes(HWND hwnd, CREATESTRUCT *cs);
BOOL SetDlgItemFloat(HWND hWnd,int nCtrlID,float fValue);
RECT& initRecArea(int left, int top, int right, int bottom);
void drawArea(HWND hwnd, HDC hdc, int pos, RGBColor colors[]);
HWND OnCreate(const HWND,CREATESTRUCT*, RECT& rc, int EditID);
void RadioButtonsText(HWND hwnd, HDC hdc, TCHAR polarLbl[]);
void printText(HWND hWnd, TCHAR txt[], RECT& rc, HDC hDC, DWORD fnWeight);
void paintObject(HWND hwnd, const RECT& rc, RGBColor *color, HDC hdc, int index);
void DrawARectangle(HWND hwnd, HPEN hpen, HDC hdc, HBRUSH hbrush, const RECT& rc);
HWND CreateEdit(const HWND,const HINSTANCE,DWORD,const RECT&,const int, const ustring&);
HWND CreateButton(const HWND hParent,const HINSTANCE hInst,DWORD dwStyle,const RECT& rc,
const int id,const ustring& caption);
void RadaAntennaText(HWND hwnd, TCHAR rdrAntenaLbl[5][25], TCHAR deg[], TCHAR db[],
TCHAR halfMin[], TCHAR mtrs[], HDC hdc);
void RadarReceiverText(HWND hwnd, TCHAR rdrTrans_recv[8][20], TCHAR hz[], TCHAR mhz[],
TCHAR mtrs[], TCHAR kw[], TCHAR usec[], TCHAR db[], HDC hdc);
// =============================================================================
// Globals
PAINTSTRUCT pntS;
HWND rdrAntnCntrl[5];
double beamWazth=0;
int update=0,box1=0,box2=0,box3=0;
// =============================================================================
// MAIN
int WINAPI WinMain(HINSTANCE hInst,HINSTANCE,LPSTR pStr,int nCmd)
{
ustring classname=_T("RFS Range");
int height_frac = 250;
WNDCLASSEX wcx={0}; //used for storing information about the wnd 'class'
wcx.cbSize = sizeof(WNDCLASSEX);
wcx.lpfnWndProc = WndProc; //wnd Procedure pointer
wcx.hInstance = hInst; //app instance
wcx.hIcon = (HICON)LoadImage(0,IDI_APPLICATION,IMAGE_ICON,0,0,LR_SHARED);
wcx.hCursor = (HCURSOR)LoadImage(0,IDC_ARROW,IMAGE_CURSOR,0,0,LR_SHARED);
wcx.hbrBackground = reinterpret_cast<HBRUSH>(COLOR_BTNFACE+1);
wcx.lpszClassName = classname.c_str();
if (!RegisterClassEx(&wcx))
{
ErrMsg(_T("Failed to register wnd class"));
return -1;
}
int desktopwidth=GetSystemMetrics(SM_CXSCREEN);
int desktopheight=GetSystemMetrics(SM_CYSCREEN);
HWND hwnd=CreateWindowEx(0,
classname.c_str(),
_T("RFS Range"),
WS_OVERLAPPEDWINDOW,
desktopwidth/4,
desktopheight/4,
desktopwidth/2,
desktopheight/2 + height_frac,
0,
0,
hInst,
0);
if (!hwnd)
{
ErrMsg(_T("Failed to create wnd"));
return -1;
}
ShowWindow(hwnd,nCmd);
UpdateWindow(hwnd);
MSG msg;
while (GetMessage(&msg,0,0,0)>0)
{
TranslateMessage(&msg);
DispatchMessage(&msg);
}
return static_cast<int>(msg.wParam);
}
//=============================================================================
LRESULT CALLBACK WndProc(HWND hwnd,UINT uMsg,WPARAM wParam,LPARAM lParam)
{
// ************************************************************************************
// Init Labels
static TCHAR deg[]="degrees", db[]="dB", halfMin[]="1/minute", mtrs[]="meters",
mhz[]="MHz", kw[]="kW", usec[]="usec", hz[]="Hz";
static TCHAR rdrAntenaLbl[5][25] = {"Beamwidth (Azimuth) :", "Beamwidth (Elevation) :",
"Gain :", "RPM :", "Height :"};
static TCHAR polarLbl[] = "Polarisation :";
static TCHAR targetLbl[2][30] = {"Radar Cross Section (RCS) :", "Height of Target :"};
static TCHAR rdrTrans_recv[8][20] = {"Frequency :", "Wavelenght :", "Peak Power :", "Pulse Width :",
"PRF :", "Bandwith :", "Noise Figure :", "Losses :"};
static TCHAR genPara[2][30] = {"False Alarm Rate Exponent :", "Detection Probability :"};
// ************************************************************************************
// Local Variables
HDC hdc;
// HWND rdrAntnCntrl[5];
int pos=0, maxChars = 20, cnrtlIndx=0;
RGBColor colors[MAXCOLOR] = {{0xD3,0xD3,0xD3},{0x00,0xFF,0x00},
{0xFF,0xFF,0xFF},{0x00,0x00,0x00}};
CREATESTRUCT *cs = reinterpret_cast<CREATESTRUCT*>(lParam);
// ************************************************************************************
// Window Messages
switch (uMsg)
{
case WM_CREATE:
// Create edit controls for user input
EditBoxes(hwnd, cs);
/* Create Radio Buttons */
CreateButton(hwnd,cs->hInstance,BS_AUTORADIOBUTTON,initRecArea(205,105,14,12),
IDBC_CHECKBOX_C,_T("Polar - C"));
CreateButton(hwnd,cs->hInstance,BS_AUTORADIOBUTTON,initRecArea(235,105,14,12),
IDBC_CHECKBOX_H,_T("Polar - H"));
CreateButton(hwnd,cs->hInstance,BS_AUTORADIOBUTTON,initRecArea(265,105,14,12),
IDBC_CHECKBOX_V,_T("Polar - V"));
/* Create Quit & Update Buttons */
CreateButton(hwnd,cs->hInstance,BS_DEFPUSHBUTTON,initRecArea(400,340,60,30),
IDBC_QUITBUTTON,_T("QUIT!"));
CreateButton(hwnd,cs->hInstance,BS_DEFPUSHBUTTON,initRecArea(500,340,80,30),
IDBC_UPDATEBUTTON,_T("UPDATE!"));
return 0;
case WM_PAINT:
hdc = BeginPaint(hwnd, &pntS);
/* *** User Interface *** */
drawArea(hwnd, hdc, pos, colors);
RadioButtonsText(hwnd, hdc, polarLbl);
RadaAntennaText(hwnd, rdrAntenaLbl, deg, db, halfMin, mtrs, hdc);
RadarReceiverText(hwnd, rdrTrans_recv, hz, mhz, mtrs, kw, usec, db, hdc);
/* Display beam values
update ? SetDlgItemFloat(hwnd,IDCE_SINGLELINE1,(float)beamWazth) : update=0;
*/
EndPaint(hwnd, &pntS);
return 0;
case WM_COMMAND:
// Listen to the input commands
switch( LOWORD(wParam) )
{
case IDBC_QUITBUTTON:
{
if(HIWORD(wParam) == BN_CLICKED){
PostQuitMessage(0);
}
}
case IDBC_UPDATEBUTTON:
{
if(HIWORD(wParam) == BN_CLICKED)
{
InvalidateRect (hwnd, NULL, TRUE);
UpdateWindow(hwnd);
}
}
}
return 0;
case WM_TIMER:
//SetTimer(hwnd, ID_TIMER, 500, NULL);
break;
case WM_DESTROY:
PostQuitMessage(0);
return 0;
default:
//let system deal with msg
return DefWindowProc(hwnd,uMsg,wParam,lParam);
}
return 0;
}
//=============================================================================
inline int ErrMsg(const ustring& s)
{
return MessageBox(0,s.c_str(),_T("ERROR"),MB_OK|MB_ICONEXCLAMATION);
}
//=============================================================================
// EDIT control
HWND CreateEdit(const HWND hParent,const HINSTANCE hInst,DWORD dwStyle,
const RECT& rc,const int id,const ustring& caption)
{
dwStyle|=WS_CHILD|WS_VISIBLE;
return CreateWindowEx(WS_EX_CLIENTEDGE,
_T("edit"),
caption.c_str(),
dwStyle,
rc.left,
rc.top,
rc.right,
rc.bottom,
hParent,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
hInst,
0);
}
//=============================================================================
// BUTTON Control
HWND CreateButton(const HWND hParent,const HINSTANCE hInst,DWORD dwStyle,
const RECT& rc,const int id,const ustring& caption)
{
dwStyle|=WS_CHILD|WS_VISIBLE;
return CreateWindowEx(0,
_T("button"),
caption.c_str(),
dwStyle,
rc.left,
rc.top,
rc.right,
rc.bottom,
hParent,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
hInst,
0);
}
// Purpose: Draws an object on the window
void paintObject(HWND hwnd, const RECT& rc, RGBColor *color, HDC hdc, int index)
{
HPEN hpen = CreatePen(PS_SOLID, 2, RGB(color[index+3].R, color[index+3].G, color[index+3].B));
HBRUSH hbrush = CreateSolidBrush(RGB(color[index].R, color[index].G, color[index].B));
DrawARectangle(hwnd, hpen, hdc, hbrush, rc);
DeleteObject(hpen);
DeleteObject(hbrush);
}
// Purpose: Draws a rectangle which will have text boxes for input data
void DrawARectangle(HWND hwnd, HPEN hpen, HDC hdc, HBRUSH hbrush, const RECT& rc)
{
// Select the new pen and brush, and then draw.
HPEN hpenOld = (HPEN)SelectObject(hdc, hpen);
HBRUSH hbrushOld = (HBRUSH)SelectObject(hdc, hbrush);
Rectangle(hdc,rc.left,rc.top,rc.right,rc.bottom);
SelectObject(hdc, hpenOld);
SelectObject(hdc, hbrushOld);
}
// Initialize rectangle area
RECT& initRecArea(int left, int top, int right, int bottom)
{
static RECT rec;
rec.left=left;
rec.top=top;
rec.right=right;
rec.bottom=bottom;
return rec;
}
//handles the WM_CREATE message of the main, parent window; return -1 to fail
HWND OnCreate(const HWND hwnd,CREATESTRUCT *cs, RECT& rc, int EditID)
{
return CreateEdit(hwnd,cs->hInstance,0,rc,EditID,_T(""));
}
// Display text on screen
void printText(HWND hWnd, TCHAR txt[], RECT& rc, HDC hDC, DWORD fnWeight)
{
long lfHeight = -MulDiv(12, GetDeviceCaps(hDC, LOGPIXELSY), 72);
HFONT font = CreateFont(lfHeight, 0, 0, 0, fnWeight, FALSE,
0, 0, 0, 0, 0, 0, 0, _T("Times New Roman"));
HGDIOBJ hDefFont = SelectObject(hDC, font);
SetBkColor(hDC, g_rgbBackground);
TextOut(hDC, rc.left, rc.top, txt, (int)_tcslen(txt));
SelectObject(hDC, hDefFont);
DeleteObject(hDefFont);
}
// Read in text as values
double GetValue(HWND hEdit,int nCtrlID)
{
float fValue = 0.00;
char szText[256];
GetWindowText(hEdit, szText, nCtrlID);
sscanf(szText,"%f",&fValue);
return Round((double)fValue, 2);
}
// Display the read value to screen
BOOL SetDlgItemFloat(HWND hWnd,int nCtrlID,float fValue)
{
HWND hControl = GetDlgItem(hWnd,nCtrlID);
char szText[256];
sprintf(szText,"%.2f",fValue);
return SetWindowTextA(hControl,szText);
}
// rounds a double variable to nPlaces decimal places
double Round(double dbVal, int nPlaces)
{
const double dbShift = pow(10.0, nPlaces);
return floor(dbVal * dbShift + 0.5) / dbShift;
}
// Check if Radio button is checked
BOOL SelectedButton(HWND hwnd, int CheckID)
{
return (int)SendMessage ( GetDlgItem(hwnd,CheckID),BM_GETCHECK,0,0 );
}
// ======================================================================================================
// User Interface functions
/* Labes for Radar Antenna Area */
void RadaAntennaText(HWND hwnd, TCHAR rdrAntenaLbl[5][25], TCHAR deg[], TCHAR db[],
TCHAR halfMin[], TCHAR mtrs[], HDC hdc)
{
printText(hwnd, _T("Radar Antenna"), initRecArea(15,15,0,0), hdc, 700); // Header
printText(hwnd, rdrAntenaLbl[AZIM], initRecArea(55,45,0,0), hdc, 0);
printText(hwnd, deg, initRecArea(265,45,0,0), hdc, 0);
printText(hwnd, rdrAntenaLbl[ELEV], initRecArea(48,75,0,0), hdc, 0);
printText(hwnd, deg, initRecArea(265,75,0,0), hdc, 0);
printText(hwnd, rdrAntenaLbl[GAIN], initRecArea(156,130,0,0), hdc, 0);
printText(hwnd, db, initRecArea(265,130,0,0), hdc, 0);
printText(hwnd, rdrAntenaLbl[RPM], initRecArea(151,160,0,0), hdc, 0);
printText(hwnd, halfMin, initRecArea(265,160,0,0), hdc, 0);
printText(hwnd, rdrAntenaLbl[HGTH], initRecArea(145,190,0,0), hdc, 0);
printText(hwnd, mtrs, initRecArea(265,190,0,0), hdc, 0);
}
/* Labes for Radar Transceiver Area */
void RadarReceiverText(HWND hwnd, TCHAR rdrTrans_recv[8][20], TCHAR hz[], TCHAR mhz[],
TCHAR mtrs[], TCHAR kw[], TCHAR usec[], TCHAR db[], HDC hdc)
{
/* Radar Transmitter/Receiver Area */
printText(hwnd, _T("Radar Transmitter/Receiver"),
initRecArea(350,15,0,0), hdc, 700); // Header
printText(hwnd, rdrTrans_recv[FREQ], initRecArea(395,45,0,0), hdc, 0);
printText(hwnd, mhz, initRecArea(540,45,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[WVLNTH], initRecArea(388,75,0,0), hdc, 0);
printText(hwnd, mtrs, initRecArea(540,75,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[PP], initRecArea(384,105,0,0), hdc, 0);
printText(hwnd, kw, initRecArea(540,105,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[PW], initRecArea(386,135,0,0), hdc, 0);
printText(hwnd, usec, initRecArea(540,135,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[PRF], initRecArea(431,165,0,0), hdc, 0);
printText(hwnd, hz, initRecArea(540,165,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[BNDWTH], initRecArea(401,195,0,0), hdc, 0);
printText(hwnd, mhz, initRecArea(540,195,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[NF], initRecArea(380,225,0,0), hdc, 0);
printText(hwnd, db, initRecArea(540,225,0,0), hdc, 0);
printText(hwnd, rdrTrans_recv[LOSS], initRecArea(415,255,0,0), hdc, 0);
printText(hwnd, db, initRecArea(540,255,0,0), hdc, 0);
}
// Display text around radio buttons
void RadioButtonsText(HWND hwnd, HDC hdc, TCHAR polarLbl[])
{
printText(hwnd, polarLbl, initRecArea(115,100,0,0), hdc, 0);
printText(hwnd, _T("c"), initRecArea(222,100,0,0), hdc, 0);
printText(hwnd, _T("h"), initRecArea(252,100,0,0), hdc, 0);
printText(hwnd, _T("v"), initRecArea(282,100,0,0), hdc, 0);
}
// Draw Rectangles on Window Area
void drawArea(HWND hwnd, HDC hdc, int pos, RGBColor colors[])
{
paintObject(hwnd,initRecArea(10,10,340,230),colors, hdc, pos);
paintObject(hwnd,initRecArea(345,10,625,285),colors, hdc, pos);
paintObject(hwnd,initRecArea(10,235,340,335),colors, hdc, pos);
paintObject(hwnd,initRecArea(10,340,340,440),colors, hdc, pos);
paintObject(hwnd,initRecArea(10,445,625,720),colors, hdc, pos);
}
// Isert Edit Controls
void EditBoxes(HWND hwnd, CREATESTRUCT *cs)
{
/* RADAR ANTENNA - Edit Boxes */
OnCreate(hwnd,cs,initRecArea(205,45,55,20),IDCE_SINGLELINE);
OnCreate(hwnd,cs,initRecArea(205,75,55,20),IDCE_SINGLELINE1);
OnCreate(hwnd,cs,initRecArea(205,130,55,20),IDCE_SINGLELINE2);
OnCreate(hwnd,cs,initRecArea(205,160,55,20),IDCE_SINGLELINE3);
OnCreate(hwnd,cs,initRecArea(205,190,55,20),IDCE_SINGLELINE4);
/* RADAR TRANSMITTER/RECEIVER - Edit Boxes */
OnCreate(hwnd,cs,initRecArea(480,45,55,20),IDCE_SINGLELINE5);
OnCreate(hwnd,cs,initRecArea(480,105,55,20),IDCE_SINGLELINE7);
OnCreate(hwnd,cs,initRecArea(480,135,55,20),IDCE_SINGLELINE8);
OnCreate(hwnd,cs,initRecArea(480,165,55,20),IDCE_SINGLELINE9);
OnCreate(hwnd,cs,initRecArea(480,195,55,20),IDCE_SINGLELINE10);
OnCreate(hwnd,cs,initRecArea(480,225,55,20),IDCE_SINGLELINE11);
OnCreate(hwnd,cs,initRecArea(480,255,55,20),IDCE_SINGLELINE12);
/* TARGET - Edit Boxes */
OnCreate(hwnd,cs,initRecArea(205,270,55,20),IDCE_SINGLELINE13);
OnCreate(hwnd,cs,initRecArea(205,300,55,20),IDCE_SINGLELINE14);
}
cstdio is C++, not C.
C uses stdio.h.
Are you writing C or C++? You seem to have a mix.
C...Quote:
Originally Posted by Elysia
No were in my code i've included cstdio.h... Don;t know where's that coming from
Ah, but you #include <string>, which is a C++ standard header. Perhaps you wanted to #include <string.h> instead.
No Difference... Is there anyone using Visual Studio 2003/2005/2008 who can just copy my code and try compiling it as .c?Quote:
Originally Posted by laserlight
Oh right, I saw it in the error output.Quote:
Originally Posted by csonx_p
Anyway, you are using C, yet you are using C++ stuff like std::string.
Seriously, that code needs to rego a big change and either you need to learn C or stick to learning C++, because this code cannot compile as C (namespaces aren't supported in C either).
Thought about that too, will fix such and come back to you... ThnxQuote:
Originally Posted by Elysia
Actually, when i though about that, i commented every CPP code style but still got the same errors... But will go through my code to make sure is 100% CQuote:
Originally Posted by Elysia
First thing I turn off in new projects, usually in the wizard, or first thing if the wizard wont let me (win32 projects). The savings even on large projects are negligiable. I have one project that has 100,000 lines of code in ~100 files, each including ~5 headers. It takes about 2 minutes to compile with PCH and 2 minutes 30 seconds without. I dont honestly see the point. I suppose if you had millions of lines of code and tens of thousands of #include's it migth make a bigger difference, but again, whats the point, you will still be compiling for an hour.Quote:
Originally Posted by matsp
IMO they woudl get better performance by multithreading the compile. FileA can be compiled in parallel with FILEB, the linker stage would probably still need to be serial, but not compilation.
Visual Studio is terribly slow with large projects but is reported to be faster than most other compilers. Pre-compiled headers are far more headache than they are worth which is why at home I don't use them and we also do not use them at work.
I've noticed that even on a quad-core machine VS2003 and VS2005 take one core up to 100% and leave the other three at 0%. The compile is multithreaded insofar as you can still interact with the GUI but I seriously doubt if the compile process itself is multi-threaded. It 'appears' to be one thread.
Honestly, i think the whole multithreading thing kind of caught most companies by surprise, it was never a serious technique until multi-core made it give huge performance increases. Now I see hundreds of black box 'turn yoru serial code into parallel code without having to think' solutions. OpenMP, RapidMind, CUDA, although the last 2 are really for use with GPU's its only a matter of time before CPU's support native vector processing. I wouldn't mind, but I end up having to evaluate every new flavor of the month and then explain to the suit why it wont improve our applications or reduce development time (it mostly has to do with some internally closed source libraries that he wont let me get the code to so I can't optimize them).
The only real reason I can see to use PCH is to obfuscate a distributed LIB so thay cant even see your class structure.
I think somewhere both of you have had bad experiences, because I really don't get what you do.
PCH speeds up compiles greatly. You just have to include windows.h and you'll notice how fast it gets. 30 seconds is a big deal if you ask me.
PCH are not difficult to use and they are not error prone (at least not to me). I haven't received any problems with them pretty much in any project I have. Just don't include headers that keep on changing. Only static non-changing headers go there and you should have no problems whatsoever.
So far as I know, VS can only do multi-threaded compile with different projects, because I really have been unable to get it compiling on anything else than one core in one project.
Yeah I know it only uses a single thread, I was just saying they would get better performance increases by going MT than by saddling us with PCH. 30 seconds on a 2 minute compile is nothing, since Im going to get a water and bull........ with a collegue anyway.
Yes, MT with a single project would be great. Additionally, I think there is something along the lines of that, or should be, but I've never gotten something like that to work.
In this case your not slacking, your code is compiling. Just like the shirt says. :DQuote:
...since Im going to get a water and bull........ with a collegue anyway.
I need one of those shirts. My boss is always acting like he is catching me slacking when Im just thinking :D He got ........ed today because he thought he 'caught' me again when I was just posting the post up above. He thinks im always doing something nefarious, poor guy has a lot of mental issues because of previous employees. I tolerate it because I can empathize with him about getting screwed over, but its getting to the point where he is the one screwing me over by not giving me my reviews or raises or profit sharing. I really would like to get a good review, but if I'm just going to get a crap review then I think its better to cut my losses now and stop wasting time at this company. Its not like he is developing my skill set like I expected. He acts like he has this amazing breakthrough AI that is so secret noone can see the source code, when in reality its just a neural network class that doesnt do anything any other neural network class doesnt do. Even if he did have some amazing new neuron model, it woudlnt matter because you cant get down to the individual neuron, you are saddled with ancient auto associative and hetero architectures. I mean its really frustrating on a personal, intellectual and professional level. He isnt teaching me anything about AI that I didn't already know 10 years ago, he doesnt let me talk to the customers directly, so I'm not making business contacts, and he basically ignores any suggestions I make, in fact he will do the opposite just to spite me. e.g. yesterday another engineer was having a problem with a robot where the set screws on teh wheels keep backign out. SO I suggested using a dab of nail polish to keep the screw from backing out rather than using lok-tite which would keep it from EVER backing out even if you wanted to change the tires (these are really small screws, so you cant get any torque on them to break the lok-tite). He overrides my suggestion and tells the guy to use superglue. I just walked back to my office, how the hell do you argue with a level of intelligence like that?Quote:
Originally Posted by Bubba
Ok, took me a while but managed to convert all the code to pure C... I now can compile but down to two warnings... This has to do with the ID of the child windowQuote:
Originally Posted by Elysia
What you see above is a C++ style, converting into C ...Code:HWND CreateButton(const HWND hParent,const HINSTANCE hInst,DWORD dwStyle,
const RECT& rc,const int id,const ustring& caption)
{
dwStyle|=WS_CHILD|WS_VISIBLE;
return CreateWindowEx(0,
_T("button"),
caption.c_str(),
dwStyle,
rc.left,
rc.top,
rc.right,
rc.bottom,
hParent,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
hInst,
0);
}
... gives a warningCode:(HMENU)id
Ignoring this warning disables the minimize/restore/close buttons on the window... Any ideas on how to convert this properly?Code:warning C4312: 'type cast' : conversion from 'int' to 'HMENU' of greater size
Got read of the warnings by casting the arguments and declaring id as 'HMENU' not 'const int' in the parameter list... But, still have the close/minimize button missing! Could there be anything i removed by mistake... Please assist!Quote:
Originally Posted by csonx_p
Well, that's weird, because those have to do with the window style.
You'll have to make sure the window style is correct...
I believe you need the WS_SYSMENU style to see the max/min buttons.
And as you know, reinterpret_cast and static_cast are C++ only, so you have to do a C-style cast to make it C.
But what's weird is that I never get the warning you do by casting int to HMENU, even with a C-style cast.
Currently dStyle is 0, when i change to WS_SYSMENU the application runs minimized (doesn't even show)...Quote:
Originally Posted by Elysia