RegQueryValueEx ERROR

I want to get the registry value (kind of char) and show to screen.. but I get "iiiiiiiiiiiiiiiiiiiiiiiii"... where is the problem???

Code:

HKEY hKey;
	DWORD dwLen = sizeof(MAX_PATH);
    char dwKeyEn[MAX_PATH];
	DWORD Type;
	if (RegOpenKeyEx(HKEY_CURRENT_USER, "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders", 0, KEY_QUERY_VALUE, &hKey) == ERROR_SUCCESS)
	RegQueryValueEx(HKEY_LOCAL_MACHINE,"Common Startup", NULL, &Type, (LPBYTE)dwKeyEn, &dwLen);
	MessageBox(NULL, dwKeyEn, "UYARI", NULL);
.....

I tried compiling your code with g++ on Linux but I got a bunch of errors.

ı use Microsoft Visual c++ 6.0 and ı didnt get error.. but ı get "iiiiiiiiiiiiiiiiiiiiiiiii"

Moved to Windows programming forum.

Originally Posted by koyboy

ı use Microsoft Visual c++ 6.0 and ı didnt get error.. but ı get "iiiiiiiiiiiiiiiiiiiiiiiii"

I was dropping a not-so-subtle hint that the thread should be moved...

can anybody help to me??

What do the functions return? If they fail, they return an error.

Mixing your metaphors here:

Code:

DWORD dwLen = sizeof(MAX_PATH);

That will give you a whopping 4 bytes to store your data in, so perhaps the error is that you need more space.

Of course, if the data doesn't fit, then the OS will not fill any of it in [the principle is that if it doesn't fit, you check the length you got back, and make it so that you supply enough of a buffer when you kindly request it again]. What you quote as iiiiii is actualy character 208 (0xCC) [or is it 0xDD, 225 decimal, or some such?] that Windows fills local variables with so that you can detect when you use uninitialized memory easier.

--
Mats

This works:

Code:

#include <stdio.h>
#include <windows.h>

int main(void)
{
	HKEY hKey;
	DWORD dwLen = MAX_PATH;
	char szKeyEn[MAX_PATH] = { 0 };
	DWORD dwType = 0;
	DWORD dwRetVal = 0;
	if (ERROR_SUCCESS == (dwRetVal = RegOpenKeyEx(
		HKEY_CURRENT_USER, 
		"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders", 
		0, 
		KEY_QUERY_VALUE, 
		&hKey)))
	{
            if (ERROR_SUCCESS == (dwRetVal = RegQueryValueEx(hKey, "Startup", 
		NULL, &dwType, (LPBYTE)szKeyEn, &dwLen)))
	   {
		if (dwType == REG_EXPAND_SZ)
		{
		    char szStartupPath[MAX_PATH];
		    if (0 != ExpandEnvironmentStrings(szKeyEn, szStartupPath, MAX_PATH))
			printf ("Value is &#37;s\n", szStartupPath);
		    else
			printf ("Error expanding value: %ld\n", GetLastError());
		}
		else if (dwType == REG_SZ)
		{
		    printf ("Value is %s\n", szKeyEn);
		}
		else
		{
		    printf ("Unexpected type returned: %ld\n", dwType);
		}
	    }
	    else
	    {
		printf ("Error querying value: %ld\n", dwRetVal);
	    }

	    RegCloseKey(hKey);
    }
    else
    {
	printf ("Error opening key: %ld\n", dwRetVal);
    }

    return 0;
}

I changed it but I got "iiiiiiiiiiiiiii" again :S.. can you give another advice??

Code:

HKEY hKey;
	DWORD dwLen = MAX_PATH;
    char dwKeyEn[MAX_PATH];
	if (RegOpenKeyEx(HKEY_CURRENT_USER, "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders", 0, KEY_READ, &hKey) == ERROR_SUCCESS)
	RegQueryValueEx(HKEY_LOCAL_MACHINE,"Common Startup", 0, NULL, (LPBYTE)dwKeyEn, &dwLen);
	MessageBox(NULL,dwKeyEn, "UYARI", NULL);

Although I provided the full answer above

Code:

RegQueryValueEx(HKEY_LOCAL_MACHINE,"Common Startup", 0, NULL, (LPBYTE)dwKeyEn, &dwLen);

The first parameter to this function call needs to be the handle of the key you just opened; in your case, hKey:

Code:

RegQueryValueEx(hKey, "Common Startup", 0, NULL, (LPBYTE)dwKeyEn, &dwLen);

that's wonderfull.. thanks @ rags_to_riches... I add this to my winapi app and changed printf to MessageBox and okkkkk