Registry Problems ( RegSetValuEx )

Hey everyone,

I'm having a bit of a problem when I save an entry into the registry. It'll story any number less than 100, however if the number (aka the variable: trigger_key ) is equal to or greater than 100 (no larger than 255), it saves a random value.

Code:

HKEY hk;
DWORD dwDisp;
TCHAR dwData[120];

RegCreateKeyExA(HKEY_CURRENT_USER, "SOFTWARE\\MacroKeys", 0, NULL, REG_OPTION_NON_VOLATILE, KEY_WRITE, NULL, &hk, &dwDisp);

_stprintf ( dwData, _T("%d"), trigger_key );
RegSetValueEx(hk, _T("trigger_key"), 0, REG_DWORD, (PBYTE)&dwData, sizeof(PDWORD));

Here is my code to retrieve the value

Code:

HKEY hk;
DWORD dwType;
DWORD dwLength;
TCHAR val[120];

RegOpenKeyExA(HKEY_CURRENT_USER, "SOFTWARE\\MacroKeys", 0, KEY_QUERY_VALUE, &hk);

RegQueryValueEx(hk, _T ( "trigger_key" ), NULL, NULL, (LPBYTE)val, &dwLength);
trigger_key = _ttoi ( val );

Any help will be appreciated.

Thanks,

Matt N

1. declare your variable dwData as a DWORD.

2. Remove the _stprintf line.

3. Check the return value of RegCreateKeyExA

long ret = RegCreateKeyExA...

4. Set the dwData value : dwData = trigger_key;

5. Change the RegSetValueEx :

Code:

        if( ret == ERROR_SUCCESS )
        {
             RegSetValueEx(hk, _T("trigger_key"), 0, REG_DWORD, (CONST BYTE*)&dwData, sizeof(dwData));
        }

These changes worked for me.

Originally Posted by DaveH

1. declare your variable dwData as a DWORD.

2. Remove the _stprintf line.

3. Check the return value of RegCreateKeyExA

long ret = RegCreateKeyExA...

4. Set the dwData value : dwData = trigger_key;

5. Change the RegSetValueEx :

Code:

        if( ret == ERROR_SUCCESS )
        {
             RegSetValueEx(hk, _T("trigger_key"), 0, REG_DWORD, (CONST BYTE*)&dwData, sizeof(dwData));
        }

These changes worked for me.

Thank you! Worked like a charm (for saving)...

Ok, now for some reason, whenever I try to load the values, they get reset to 0.

Code:

HKEY hk;
	DWORD dwType;
	DWORD dwLength;
	DWORD val;

	long ret = RegOpenKeyEx(HKEY_CURRENT_USER, _T("SOFTWARE\\AntiRecoil"), 0, KEY_QUERY_VALUE, &hk);

	if ( ret != ERROR_SUCCESS )
		return 1;

	RegQueryValueEx(hk, _T ( "k_trigger" ), NULL, NULL, (LPBYTE)val, &dwLength);
	k_trigger = val;

RegQueryValueEx(hk, _T ( "k_trigger" ), NULL, NULL, (LPBYTE)val, &dwLength);

should be:

RegQueryValueEx(hk, _T ( "k_trigger" ), NULL, NULL, (LPBYTE)&val, &dwLength);

Looks like you're writing using "trigger_key", while you're reading "k_trigger"?

Originally Posted by rags_to_riches

Looks like you're writing using "trigger_key", while you're reading "k_trigger"?

Yeah, don't worry about that (i changed trigger_key to k_trigger, forgot to post it)

And thanks Bleech, for the quick response (the mistake was so simple, now I feel like an idiot )