process finding

hi
I wrote a small code to find a specific process (in this case the notepad.exe).It compiles Ok but it wont identify the notepad. any one know why???
I'm using VC++ 6.0

here is the code

Code:

#include <windows.h>
#include <stdio.h>
#include <Tlhelp32.h>

void getprocess();

PROCESSENTRY32 pr;
HANDLE hpro;
BOOL test=TRUE;

int main(void){
getprocess();
	return 0;
}

void getprocess(){
hpro=CreateToolhelp32Snapshot(TH32CS_SNAPALL,0);
pr.dwSize=sizeof(PROCESSENTRY32);

Process32First(hpro,&pr);

while(test==TRUE){
test=Process32Next(hpro,&pr);

if(pr.szExeFile == "notepad.exe"){
MessageBox(NULL,"Notepad is running","Messenger",MB_OK);
}

printf(pr.szExeFile);
printf("\n");
}

CloseHandle(hpro);  
}

Code:

if(pr.szExeFile == "notepad.exe")

// should be something like
if(strcmp(pr.szExeFile, "notepad.exe")

With the loop set up like it is right now, you aren't going to be very happy if you have several processes running after notepad

> if(pr.szExeFile == "notepad.exe")
Lookup strcmp()

okay guys its working
but why the

Code:

if(pr.szExeFile == "notepad.exe")

is not working ??
thanks

I believe that that doesn't work because the "==" compares the addresses of the two items and not the values of them, don't ask why. Also strcmp returns 0 if the two strings are equal so Vicious's code should be:

Code:

if(!strcmp(pr.szExeFile, "notepad.exe"))
//Rather than
if(strcmp(pr.szExeFile, "notepad.exe")
//Which is testing if they are not equal

Originally Posted by P4R4N01D

I believe that that doesn't work because the "==" compares the addresses of the two items and not the values of them, don't ask why. Also strcmp returns 0 if the two strings are equal so Vicious's code should be:

Code:

if(!strcmp(pr.szExeFile, "notepad.exe"))
//Rather than
if(strcmp(pr.szExeFile, "notepad.exe")
//Which is testing if they are not equal

!!!!!! Yeah, sorry about that. Rough day

Originally Posted by P4R4N01D

I believe that that doesn't work because the "==" compares the addresses of the two items and not the values of them, don't ask why. Also strcmp returns 0 if the two strings are equal so Vicious's code should be:

Code:

if(!strcmp(pr.szExeFile, "notepad.exe"))
//Rather than
if(strcmp(pr.szExeFile, "notepad.exe")
//Which is testing if they are not equal

No, not really.

However, a character array becomes a pointer, and same with string literals. This means that you're essentially comparing the addresses of the variables, but that's just because that 'variable itself' contains an address(eg. a pointer).

Any normal variables (int and char, etc) that aren't pointers are compared the same way - the value that's stored is compared.

hi
thank you all for the replies