Printable View
So, this is the assignment:
3-3. Write a program to count how many times each distinct word appears in its input.
You might recognize it from Accelerated C++.
I have come as far as to initialize the vector and giving it the same amount of elements as the input:
What I'm not so sure of how to do is to actually find the words and pick out their letters to see what they really contain. Any help?Code:vector<string> skrivning;
double x;
while (cin >> x)
{
skrivning.push_back(x);
}
Perfect problem for a map<string,int> container.
A map is great for this, but if you haven't learned map in the book yet, have you learned sort?
You're right, map hasn't been introduced yet, though sort has. I'm guessing what you're getting at is to use sort to organise the strings in a decreasing (or non-decreasing) order, but how would I pick them out in a proper way?Quote:
Originally Posted by Daved
Once they're sorted, you can just go through the vector from start to finish and keep a count. If the current word is the same as the previous word, then increment the count. If it is different than the previous word, then restart the count for the new word.
This is about as far as I've come. Am I on the right track? I can't think of a way to keep that count for each word correctly other than in another vector, and how would I sort the counts out once stored?Code:#include <algorithm>
#include <iostream>
#include <string>
#include <vector>
using namespace std;
int main()
{
// initialize the vector
vector<string> skrivning;
double x;
cout << "Enter a sentence of your choice.";
while (cin >> x)
{
skrivning.push_back(x);
}
// sort and initialize neccesary variables
sort(skrivning.begin(), skrivning.end());
int u, count = 0;
int lastWord = skrivning[u-1];
// count the word appearances
for(u = 0; u < skrivning.size(); u++)
{
if (u == 0)
{
break;
}
else if(skrivning[u] == lastWord)
{
Do you need to sort the counts? I don't think you do. Do you even need to store the counts? I think that when you find that skrivning[u] != lastword you can just output lastword and the count before starting the new count.
Also note that you have a few bugs in the code as it is. Make sure to initialize u if you keep it, you probably want continue instead of break, and the first value for lastword should be skrivning[0] if you're going to initialize it with something (you can also get it to work with it starting out empty if you want).
The reason why I check if u == 0 is that I don't want the the loop to check for a match in the last word if it's the first word anyway, that'd be kind of pointless.Quote:
Originally Posted by Daved
First value for lastword? I use it to compare skrivning with the last word read, which is skrivning[u-1], so why shouldn't I initalize lastword to what's stated in the code above?
I know what you're doing. But the things I mentioned still apply.
The check for u== 0 is fine, but you don't want break, that will end the loop, you want continue to skip the rest of the loop and start again.
It's fine to store skrivning[u-1] in lastword, but not at the beginning. At the beginning u is uninitialized, so u-1 could be anything. Even if you initialize it to 0, u-1 would be -1, which is not valid.
Remember, just because you make an assignment of lastword = skrivning[u-1], doesn't mean that lastword will get updated automatically every time u changes. C++ doesn't work like that. Execution goes in order from top to bottom and the assignment only happens that one time. You have to assign a new value to lastword each time u changes or you find a new word.
Now I guess my problem is where to initialize the first lastWord = skrivning[u-1]. It doesn't fit anywhere it seems; putting it in the first line of the loop causes the program to crash.Code:#include <algorithm>
#include <iostream>
#include <string>
#include <vector>
using namespace std;
int main()
{
// initialize the vector
vector<string> skrivning;
string x;
cout << "Enter a sentence of your choice." << endl;
while (cin >> x)
{
skrivning.push_back(x);
}
// sort and initialize neccesary variables
sort(skrivning.begin(), skrivning.end());
int u = 0;
string lastWord;
// count the word appearances
for(u = 0; u < skrivning.size(); u++)
{
if(u == 0)
{
cout << skrivning[0] << endl;
}
else if(skrivning[u] != lastWord)
{
cout << skrivning[u] << endl;
lastWord = skrivning[u-1];
} else {
cout << skrivning[u] << " " << lastWord << " Match!" << endl;
}
}
system("PAUSE");
return 0;
}
Also when there are more than two similar words entered, the program doesn't catch the third one.
You can set lastWord equal to the first string in the vector, and then start your loop with the second vector entry (if there is one, that it). Then, there's no need for test of u==0.
You prompt says "enter sentences", but your logic appears to be geared for "words". I see no point in sorting sentences.
Todd
Each word in the sentence will be added to the vector separately, so it will work fine. Of course, the input only stops when the user inputs Ctrl-Z or Ctrl-D or whatever sequence indicates end-of-file on a console application, so maybe "text" or "paragraph" would be better than sentence.
What I've done in the past is I've sorted the vector, used vector.count() to find all how many times the first element appears. I then store that, and erase all of those that are the same. I then proceed to do the same procedure until I reach the end. I'm sure that the other ways would work as well, but I just thought I'd put in my two cents:).
Simplified. (I had to add a break since I can't figure out how to simulate EOF via the XCode Run Log... :( )
ToddCode:#include <algorithm>
#include <iostream>
#include <string>
#include <vector>
using namespace std;
int main()
{
// initialize the vector
vector<string> skrivning;
string x;
cout << "Enter a sentence of your choice." << endl;
while (cin >> x )
{
if (x=="X") break ;
skrivning.push_back(x);
}
// sort and initialize neccesary variables
sort(skrivning.begin(), skrivning.end());
int u = 0;
int word_count = 1 ;
for(u = 0 ; u < skrivning.size()-1; u++)
{
if (skrivning[u] == skrivning[u+1] )
{
word_count++ ;
}
else
{
cout << "Word is " << skrivning[u] << ", count is " << word_count << endl ;
word_count = 1 ;
}
}
cout << "Word is " << skrivning[skrivning.size()-1] << ", count is " << word_count << endl ;
system("PAUSE");
return 0;
}
(and it doesn't look for no words entered.)
Did you just do the problem for him (or her)? Why?
Well..... yes.... I guess I did finish it. Not sure how I can justify my action. I guess I figured the OP was pretty much there and had demonstrated real effort towards solving it, but was over complicating things.
No excuses. I finished it for them. If the mods feel it is inappropriate, pull it.
There's no official rule against doing people's work for them that I know of, and I didn't think it was a homework assignment (it might be), so it's not that big of a deal. I was just wondering. If you feel it is inappropriate, then you can pull it.
You just copied the poor indenting, too. The OP is mixing tabs n' spaces!
How am I? If the tabs don't line up like I want them to, I use spaces to put them in the right position.Quote:
Originally Posted by Elysia
Thanks for the solve, Todd Burch, I see now what I did wrong. :p And no, this was not a homework assignment.
But the thing is, you shouldn't. Just use tabs to indent, and you don't need to line it up anymore.Quote:
Originally Posted by Soulrivers
Mixing the two will only cause the code to become misaligned when you copy it elsewhere, outside your IDE.
Alternatively, just use spaces to indent. This is a situation where you cannot have your tabs and eat the spaces too :)
Or use all spaces - most editors/IDE's have a setting to select whether you want spaces or tabs for indentation.Quote:
Originally Posted by Elysia
Modern editors and IDE's are also usually capable of "autoindenting", which will make life better for you.
--
Mats
Or just use all tabs! You don't need to line-up code at all. Tabs is perfectly fine for making readable code!
Tabs vs. spaces is a big argument with both sides favoring one over the other, so there's no real point in saying which one is better.
Yes - what I said was just that there are two alternatives [I have my thoughts about which is better, and I know this is just as difficult to resolve as the battle over which Christian form is "better" - Protestantism or Catholicism]. But there's absolutely no need to MIX the two - that is DEFINITELY a way to confuse everything and anything.Quote:
Originally Posted by Elysia
--
Mats
100% Agreed :)Quote:
Originally Posted by matsp
Fine, I see your point. I'll try using only tabs in the future, thanks.