help with c program: binary to ascii program

This is a program where i input a 8 digit binary character and it calculates binary to ascii so if i enter a binary character 01000001 the program calculate and give me the ascii 65 (which is a 'A')

My problem is, once i get 8 character i want to calculate the 8 and get the ascii then calculate the next set. Right now it calculate the last set i input.

ie. i enter 1010101011110000, itll do the calculations for 11110000 and not the first part which is 10101010

would i have to add code into the if statement?

Code:

---

int bit_to_ascii(const char core[ ], char data[ ]);

int main( ) {
  char core2[256];
  char data2[13];
  int rc2;
  printf("enter: ");
  scanf("%256[^\n]", core2);
  rc2 = bit_to_ascii(core2, data2);
  printf("%d", rc2);
  return 0;
}

int bit_to_ascii(const char core[ ], char data[ ]) {
  int i, rc = 0, j, inte[7];
  char binarray[9];
  for(i=0, j=0; core[i] != '\0'; i++) {
    switch(core[i]) {
        case '1':
        case '0':
            if(j<8) {
              binarray[j++] = core[i];
            }
            else {
              j = 0; /* resets j to 0 after 8 1's or 0's have been found */
          if(j<8) {
              binarray[j++] = core[i];
            }
    }
            break;
      }
  }
  binarray[j] = '\0';
  inte[0] = (binarray[0] - 48) * 128;
  inte[1] = (binarray[1] - 48) * 64;
  inte[2] = (binarray[2] - 48) * 32;
  inte[3] = (binarray[3] - 48) * 16;
  inte[4] = (binarray[4] - 48) * 8;
  inte[5] = (binarray[5] - 48) * 4;
  inte[6] = (binarray[6] - 48) * 2;
  inte[7] = (binarray[7] - 48) * 1;
 
  printf("the binary array is: '%s' %d %d %d\n", binarray, inte[0], inte[1], inte[2]);
  return rc;
}

---

Well, when you reset j to 0, you then go ahead and write over the eight bits you had just read in. So at the end of the day, you've only got the last eight bits in your array. At that point, you should maybe stop reading and write out an answer, or store an answer, or do something with the data before reading more in.

oh what a simple mistake thanks alot man i got it working now

i have a next one though, i forgot to mention but if the last set is less than 8 characters i need to add 0's to make it a full 8 characters

so if the last set is: 10101

then i need to add 3 0's so it'll be 10101000

this is what i tried. i got the lenght of the binarray string, and the subtract the lenght by 8 (lenght is 6, do 8 - 6 equals 2 that means i add 2 zero's) but i can't get it working

Code:

---

  len = strlen(binarray);
  printf("%d", len);
  if(len<8){
            len2 = 8-5;
            printf("%d", len);
            }

---

Before or after you set binarray[j]='\0'?

right now its like this (after binarray = /0)

Code:

---

binarray[j] = '\0';
  len = strlen(binarray);
  printf("%d\n", len);
                if(len<8){
                          len2 = 8 - len;
                          printf("%d\n", len2);
                          for(m=len2; m<9; m++){
                                      binarray[len2]=0;
                                      }
                          }
  inte[0] = (binarray[0] - 48) * 128;
  inte[1] = (binarray[1] - 48) * 64;
  inte[2] = (binarray[2] - 48) * 32;
  inte[3] = (binarray[3] - 48) * 16;
  inte[4] = (binarray[4] - 48) * 8;
  inte[5] = (binarray[5] - 48) * 4;
  inte[6] = (binarray[6] - 48) * 2;
  inte[7] = (binarray[7] - 48) * 1;

---

Why not try

Code:

---

binarray[len2] = '0';

---

with single quotes like ' it does the same thing like before, with double quote it says this "61 D:\Untitled1.cpp invalid conversion from `const char*' to `char' "

also i made a mistake it should say

Code:

---

binarray[m] = '0';

---

not len2 where it says m

Well, you want the single quotes. So now we're back to "not working". Does len print what you think it should? And I don't think you have your loop correct; if you've read in 6 characters, so that len is 6, then your for-loop will zero out from 2 to 8. You should just go from len to 7 with the '0's.

you are right again i got it working good now, ill show you what i did for the loop

Code:

---

binarray[j] = '\0';
  len = strlen(binarray);
  printf("%d\n", len);
                if(len<8){
                          len2 = 8 - len;
                          m = len;
                          printf("%d\n", len2);
                          /*for(m=len2; m<9; m++){*/
                          do {
                                      binarray[m]='0';
                                      m++;
                          }while (m != 8);           
                                      /*}*/
                          }

---

i got a new problem i just need a way to start coding this but while searching for the 1's and 0's i need to also look for the word 'RTP' and the word 'RTP' is followed by a number. Any suggestions on how to do this because when i find RTP, the number after it determines how my times the 8 1's/0's are used (ie. if i find RTP4, then the 8 1's/0's are lets say 10101010 then i have to make it output 4 times;
10101010
10101010
10101010
10101010)

this is my code right now

Code:

---

int bit_to_ascii(const char core[ ], char data[ ]);

int main( ) {
  char core2[256];
  char data2[13];
  int rc2;
  printf("enter: ");
  scanf("%256[^\n]", core2);
  rc2 = bit_to_ascii(core2, data2);
  return 0;
}

int bit_to_ascii(const char core[ ], char data[ ]) {
  int i, rc = 0, j, inte[7], len, len2, m;
  char binarray[8];
 
  for(i=0, j=0; core[i] != '\0'; i++) {
    switch(core[i]) {
        case '1':
        case '0':
    if(j<8) {
              binarray[j++] = core[i];
            }
           
    else {
         
        binarray[j] = '\0';
         
        inte[0] = (binarray[0] - 48) * 128;
        inte[1] = (binarray[1] - 48) * 64;
        inte[2] = (binarray[2] - 48) * 32;
        inte[3] = (binarray[3] - 48) * 16;
        inte[4] = (binarray[4] - 48) * 8;
        inte[5] = (binarray[5] - 48) * 4;
        inte[6] = (binarray[6] - 48) * 2;
        inte[7] = (binarray[7] - 48) * 1;
 
        printf("the binary array is: '%s' %d %d %d %d %d %d %d %d\n", binarray, inte[0], inte[1], inte[2], inte[3], inte[4], inte[5], inte[6], inte[7]);
        j = 0; /* resets j to 0 after 8 1's or 0's have been found */
       
        if(j<8) {
              binarray[j++] = core[i];
            } //end if
           
      }//end else
     
      }//end switch
     
    }//end for loop
   
  //for last set of 8 1's/0's 
  binarray[j] = '\0';
 
  len = strlen(binarray); //finds lenght to determine how much zero's to add if lenght is less than 8
  printf("%d\n", len);
                if(len<8){
                          len2 = 8 - len;
                          m = len;
                          printf("%d\n", len2);
                          do {
                                      binarray[m]='0';
                                      m++;
                          }while (m != 8);           
                          }
                         
  inte[0] = (binarray[0] - 48) * 128;
  inte[1] = (binarray[1] - 48) * 64;
  inte[2] = (binarray[2] - 48) * 32;
  inte[3] = (binarray[3] - 48) * 16;
  inte[4] = (binarray[4] - 48) * 8;
  inte[5] = (binarray[5] - 48) * 4;
  inte[6] = (binarray[6] - 48) * 2;
  inte[7] = (binarray[7] - 48) * 1;
 
  printf("the binary array is: '%s' %d %d %d %d %d %d %d %d\n", binarray, inte[0], inte[1], inte[2], inte[3], inte[4], inte[5], inte[6], inte[7]);
  return rc;
}

---

Your indentation is such a mess that's it's impossible (read: too much effort) to work out what code is meant to be run in association which each control structure.

how is it now??

So you've got more cases to work with now, since there are more characters that you care about. I would put 'R' in the switch, and in that case look to see if the next two characters are T and P.

does it matter the placement, like if i put a case 'R': before the case 0: and 1:?

also, how should i check if the next two are TP? this is where im stuck.

Quote:

---

Originally Posted by bigmac(rexdale)

does it matter the placement, like if i put a case 'R': before the case 0: and 1:?

also, how should i check if the next two are TP? this is where im stuck.

---

It doesn't matter where, just somewhere.

You've got a big pile of characters, don't you? Look at your switch statement: which one are you checking now? If that one is R, what needs to be T, and what needs to be P?

Quote:

---

Originally Posted by tabstop

It doesn't matter where, just somewhere.

You've got a big pile of characters, don't you? Look at your switch statement: which one are you checking now? If that one is R, what needs to be T, and what needs to be P?

---

well if one is R, what needs to be T is the following character and what needs to be P is the next following character.

Quote:

---

Originally Posted by bigmac(rexdale)

well if one is R, what needs to be T is the following character and what needs to be P is the next following character.

---

And what is the "one" that we're checking: we're checking core[i] (since that's the argument to our switch). So if core[i] == 'R', we need ________ == 'T' and ________ == 'P'. Fill in the blanks and you're done.

core[i] == 'T' and same for P??

No, core[i] == 'R'. The next one needs to be 'T'.

oh, do you mean, core[i++]?

Code:

---

case 'R':
        i++;
        if(core[i]=='P'){
          i++;
        }
        if(core[i]=='T'){
          printf("RPT");
        }

---

seems to work now, but i need to see if the next character is a digit after the T

Quote:

---

Originally Posted by bigmac(rexdale)

oh, do you mean, core[i++]?

Code:

---

case 'R':
        i++;
        if(core[i]=='P'){
          i++;
        }
        if(core[i]=='T'){
          printf("RPT");
        }

---

seems to work now, but i need to see if the next character is a digit after the T

---

Well, wouldn't that digit now be in core[++i]? The hairy bit would be if you would need to check for two-digit (or three-digit) etc. numbers -- in other words, do you know when to stop reading an RPT code and start reading 1s and 0s again?

thats what i need to find out, if its a digit and how long the digit is. (the number that comes after RPT)

for the RTP, i have to use the 8 1's/0's that come before RTP, so a code like this 01010101 RPT2 would mean i have to use the 8 1's 0's (01010101) before RPT and do it 2 times. but the problem is i also have to be able to find the 8 1's 0's before the RPT with other characters like A or b or 9.

^^can someone help, been trying ever since and still i cant get it

Please post your current code.

to check if a character is between 1 and 9 you would have to write;
core[i + 3] >= '1' && core[i + 3] <= '9'

and you are at least detecting at that point whether the core array is holding a character from 1 to 9

at the certain point in the array