unexpected program crash

im working on a simple program.. but it constantly crashes. i have absolutely no idea why. ill start the program.. write my name.. press enter. and it gives me the windows error "send bug report" thing.. could somebody take a look and try to explain why?

Code:

---

#include <iostream>
#include <string>

using namespace std;

class Character{
      public:
Character(){
            Health = 100;
            Level = 1;
};
~Character(){};
string getName(){
    return name;
};
string getClass(){
    return Class;
};
int getAttack(){
    return Attack;
};
int getDefense(){
    return Defense;
};
int getLevel(){
    return Level;
};
int getHealth(){
    return Health;
};
string setName(string n){
      n = name;
};
protected:
          string name;
          string Class;
          int Attack;
          int Defense;
          int Level;
          int Health;
};

class Monster: public Character{
      };

int main(){
Character Player;
Character * pPlayer = &Player;
string dName;
cout<<"player name\n";
cin>>dName;
pPlayer->setName(dName);
cin.get();
cout<<"name is"<<Player.getName()<<"\n";
cout<<"player Class\n";
cin.get();
};

---

im using dev-cpp if its of any concelation

You need to properly indent your code. Anyway, the first thing I see that is wrong is that

Code:

---

#include <strings.h>

---

should be:

Code:

---

#include <string>

---

sorry about the indentation.. i usually let the compiler handle the indentation.. thanks for the strings.h comment.. ive fixed it. but the problem persisits.. seems to happen everytime i use pointers..

probably should mention im using dev-cpp

Well, the next problem that I noticed is this:

Code:

---

string setName(string n){
    n = name;
}

---

You are assigning name, which was not given a value in the constructor, to the local variable n. You probably want to do the opposite:

Code:

---

string setName(string n){
    name = n;
}

---

Quote:

---

but the problem persisits.. seems to happen everytime i use pointers..

---

Dev-C++ 4.9.9.2 uses the MinGW port of g++ 3.4.2. I compiled with the MinGW port of g++ 3.4.5 and tested on Windows XP, but could not duplicate such a problem. Your code looks okay where pointers are concerned.

One more thing: if you plan to use Character as a base class (and it appears that you do have such an intention), declare its destructor as virtual.

thanks for your input.. ill try this on a few other compilers and see how it works.. i just got through my tutorial on polymorphism. so im not too knowledgeable on virtual functions. but i know what they do. just not always the best time to implement them.

ive also edited the set name function

Quote:

---

Originally Posted by lilhawk2892

sorry about the indentation.. i usually let the compiler handle the indentation..

---

Huh? What does that even mean? The compiler doesn't care whatsoever about indentation. The ONLY reason for indentation is human readers.

my IDE... sorry. when i say compiler im usually referring to the entire development enviroment

Don't expect the IDE to do your work for you. It's your task to make the code readable. So go ahead an indent one time in each block (eg, inside main), and you'll see it becomes better.

Another problem is with your setName member function.

You are declaring that it returns a string but you dont return anything. Im guessing that this is a mistake and that you intend to declare it returns void.

Code:

---


void setName(string n)
{
    name = n ;
}

// or if you did want it to return the string then use

string setName(string n)
{
    name = n ;
    return name ;
}

---

Also remember to return 0 in your int main( ) function at the end.

Apart from that it seems to be working fine.

Hope this helps

those lasts tips helped my program is now running fine. and i know how to fix it the next time

as far as indents are concerned, just turn on teh option of converting tabs to spaces, that wha when you copy and paste you dont lose the indents.

That's not correct. Tabbed code pastes fine in the board, so long as you use code tags.

Normally, I would blame skewed indentation on Dev-C++'s default indentation setting (the "smart tabs" feature is not as smart as it should be, so it should be turned off, but is on by default), though in lilhawk2892's example code the indentation was simply lacking, not skewed.

smart tabs does a good job of almost working right :D