ofstream

Hi again!

So here's what im trying to do this time:

1.Open a file.
2.Capitalize the first letter of every line.
3.Put it in another file.

I got stuck with the third part. It capitalize every word on the console but not in the
created file.

Code:

---

#include <iostream>
#include <fstream>
using namespace std;

int main()
{
 
  ifstream TheFile("f2.txt");
  ofstream TheCopy;
  TheCopy.open ("YourCopy.txt",ios::app);
  string ch;
  while (getline(TheFile,ch))
  {     
          cout.put((int toupper(ch)));                       
          else cout.put(ch);
          TheCopy << ch;
       
  }
  TheCopy.close();
  TheFile.close(); 
  cout << endl;
  system("pause"); 
}

---

I hope i dont abuse your patience. Tx.

Why don't you open TheCopy only once before you start looping?

Also, don't hope to read "*.doc" files this way. Just create a simple text file with Notepad or similar and save to a plain text file. A Word document has a lot more in it than just the plain text and you'll probably just make the resulting file unreadable.

Code:

---

while (TheFile.get(ch))

---

Reading a line and then upping each character using an array is more efficient, but that's up to you if you want to add/do.

Code:

---

      if (pre == ' ' || pre == '\n')

        cout.put(char(toupper(ch)));                             
        else cout.put(ch);

---

Indent this and the following code properly first. The line after if should preferably be indented by a tab so we know that it's the only line line associated with the if. And the rest of the code afterwards should be on the same level as the while. Indentation is to help us keep track of where the blocks lie, not create confusion, which is exactly what you're doing.

Also, from what I can see, it only ups the character IF it's a space ' ' or a new line '\n'; otherwise it just prints out a wrong character.

And opening and closing a file directly after writing a char is a huge waste of time. It means it has to do the work to open the file, then write a character and when you close, it has to flush the buffer. As anon suggests, open the out file before the loop and close it after.
It also so happens that you try to close the output file twice.

your program only makes " " and "\n" upper. at the beginning of your loop you should write it
with the not operator

Code:

---

      if (! pre == ' ' || pre == '\n')

---

Ok, you have modified the original code, but you could have also notified us of it and told us what is not right now.

Code:

---


  char fileName[80];
  char buffer;

---

These are both unused and should be removed.

Code:

---


  ifstream TheFile("f2.txt");
  ofstream TheCopy;
  TheCopy.open ("YourCopy.txt",ios::app);
  char ch, pre = '\0';
...
    if (pre == ' ' || pre == '\n')

---

Does it give you an idea why the first word is not capitalized - unless the file begins with a space?

Code:

---

  while (TheFile.get(ch))
  {
 
      if (pre == ' ' || pre == '\n')

          cout.put(char(toupper(ch)));                             
          else cout.put(ch);
       
  TheCopy << ch;
  pre = ch;
       
  }

---

Do you have any idea why you see correct output on the screen (apart from the first word) but not in the output file?

Hint, toupper does not modify the argument. It returns the upper-case character.

Thanks Aron, Elisia and Unlockitall!

I intented and fixed the code. Its the same, its working on the console output but it writes
to the new file without upping the first letters.

@Unlockitall I think its good as it is because its working.The idea behind this
if ( pre == ' ' || pre == '\n') is that after a white space or a new line character there must
be a word.

@Elisya "Reading a line and then upping each character using an array is more efficient, but that's up to you if you want to add/do."

I only liked to uppercase every word's fist letter not every letter.

@Anon
- yes i was wondering why the first word wasnt capitalized Tx But i still dont get it. "Pre" is initialized to "\0". Why would it
be a problem, i dont see it.
- so if toupper() does not modify the argument, i guess another function that does it is not an option
so maybe i should find a workaround.

Quote:

---

Originally Posted by Ducky

@Elisya "Reading a line and then upping each character using an array is more efficient, but that's up to you if you want to add/do."

---

Sure, maybe I worded it a little wrong. You currently just read on a char-by-char basis, but you can also do the same code with reading a whole line and an array. The logic will be the same.

Quote:

---

@Anon - yes i was wondering why the first word wasnt capitalized Tx
- so if toupper() does not modify the argument, i guess another function that does it is not an option
so maybe i should find a workaround.

---

For the first problem perhaps try initializing pre to either ' ' or '\n', so the if condition also picks up the first word (as if there was a space before).

To change a letter to uppercase, perhaps try:

Code:

---

ch = toupper(ch);

---

@Anon
Cool, im so happy the first problem works great.
The second unfortunately not, i added it to the code of my first post, i hope i did it well.
Actually it capitalizes every letter so thats already a progress though. :)

@Elisya
Thanks for the advice , i dont know how to do it that way but im gonna look for it.

How about putting this line in the if block (and then printing both to screen and file unconditionally)?

I wonder how you managed to come up with the program if you can't figure out such simple things...

lol You got me! :)

Maybe i should go to a Beginner's board instead.:)
Thanks

@Elisya
I dont think that fstream supports arrays.

Yes, it does. Operators << and >> are pretty poor (and dangerous if misused), but there is also get and write from which you can read into an array. Then there's basic_istream.getline which works with array (but not std::string).
If you need to read into an std::string (recommended), then you can use getline to read into an std::string from your file.

Ok i figured out how to use getline with std::string

Code:

---

string ch ;
  while (getline(TheFile,ch))
  {
     
          cout.put((int toupper(ch)));                           
          else cout.put(ch);
         
    TheCopy << ch;
  }

---

But now it poses the problem on how to use toupper() only on the first character of the string.

Code:

---

ch[0] = (char)toupper(ch[0]);

---

std::string overloads operator [], so you can use it just like in a normal C-style string to access characters in the string (and assign them!).

Code:

---

cout.put((int toupper(ch)));

---

What's that int doing there? It looks like you're trying to define a toupper() function or something.

@Elisya
I was thinking about to use something like:
transform (ch.begin(), ch.end(), ch.begin(), toupper);
but what you're saying sounds easier, thanks.

@Cpjust
Yeah i was a bit confused 'bout it , thanks for pointing it out , i'll fix it.

I'm done with it and im glad. :)
Im gonna use it to write subtitles and want to offer it to those who are writing them also.
It seems to work with other extentions than .txt like .srt...
Thanks again for the help for everybody.

Code:

---

#include <iostream>
#include <fstream>
using namespace std;

int main()
{
  cout << "Enter file name : ";
  char FileName[99];
  cin  >> FileName;
  ifstream TheFile(FileName);
  ofstream TheCopy;
  TheCopy.open ("YourUppercasedCopy.srt",ios::app);
  string ch;
 
  while (getline(TheFile,ch))
  {     
          ch[0] = (char)toupper(ch[0]);
          TheCopy << ch << endl;
         
  }
  TheCopy.close();
  TheFile.close();
 
}

---

Using >> to a char buffer is not typically safe (try std::string instead).
And you're only upping the first letter of each row, in case you wanted to up every letter of every word.

I tried to do it with std::string first but it didnt compile that way i dont know why.

Code:

---

cout << "Enter file name : ";
  string FileName;
  cin  >> FileName;
  ifstream TheFile(FileName);  <-- compile error here

---

And upping every word was just a step in between because i didnt know how to up only the first word.

No, of course not... The C++ I/O really could have been done better.
You can use cin.get or cin.read to fetch X amount of characters from the stream. That way you won't have a buffer overrun if the filename is too long.

string FileName;
cin.get (FileName);

Doesn't compile either.

Needs a char array, and also specify the size of the array.

References

Code:

---

std::string fileName;
std::getline(std::cin, fileName);
std::ifstream fin(fileName.c_str());

---

Cool, thanks.
string fileName;
getline(cin,fileName);
ifstream TheFile(fileName.c_str());

It needed .c_str. Never heard of it. :)

Code:

---

ch[0] = (char)toupper(ch[0]);

---

C style casts are discuraged in C++.
C++ casts make your intent (and effect) more explicit. So I'd probably change that line to:

Code:

---

ch[0] = static_cast<char>( toupper(ch[0]) );

---

You're also missing some header files like <string> and <cctype>

Thanks Cpjust , i changed my code like you said.
I also liked to add a check if the letter is uppercase after a dot "." .
Im just not sure how to go about it.
Can i do the two things in one while() statement or shall i have to use two?
Can i use only getline() for the two or i need getline() and get()?
Should i use three files for it or i can do it with two?
Take File1 , uppercase every line , put it in File2
Take File2 , uppercase after "." put it in File3

Code:

---

#include <iostream>
#include <fstream>
#include <string>
#include <cctype>
using namespace std;


int main()
{
  cout << "Enter file name : ";
  string FileName;
  cin  >> FileName;
  ifstream TheFile(FileName.c_str());
  ofstream TheCopy;
  TheCopy.open ("Your_Uppercased_Copy.srt",ios::app);
 
  string str;
  size_t offset;
 
  while (getline(TheFile,str))
  {     
          str[0] = static_cast<char>( toupper(str[0]));
          TheCopy << str << endl;
  }
 

  while((offset = TheFile.find(".")) != -1)
  {
          str =  put.(char( toupper(offset + 1));
          TheCopy << str << endl;         
  }
  TheCopy.close(); 
  TheFile.close();
}

---

Code:

---

while((offset = TheFile.find(".")) != -1)

---

TheFile is a ifstream which doesn't have the find method. You can find things in a string. Then it would be wiser to compare against std::string::npos which may or may not equal signed value -1.

However, you should do all the capitalization before you output anything to TheCopy - in the first while loop where you actually have the string that you want to work with.

By the way, if this is normal text I'd expect a space after '.' unless there is a typographical error. If that is the case you might need to adjust your logic to find the first non-whitespace character after a full stop. You also fail to take into account that '.' may be the last character of the string.

Ok, thanks Anon!
I didnt find out how to use std::string::npos to find a character in a string but i find this method.
Ok now what i can do is up the first letter of a line and up after any(one) character i want.
What i cant seem to find is how to uppercase after two characters like ". " (dot and space).

Code:

---

int main()
{
  cout << "Enter file name : ";
  string  FileName;
  cin >>  FileName;
  ifstream TheFile(FileName.c_str());
  ofstream TheCopy;
  TheCopy.open ("Your_Uppercased_Copy.srt",ios::app);
 
  string str;
  char ch;
 
  while (getline(TheFile,str))
  {     
          str[0] = static_cast<char>( toupper(str[0]));
         
          for(int i = 0; str[i]; i++)
          if (str[i] == '.')
              str[i+1] = static_cast<char>( toupper(str[i+1]));
         
          TheCopy << str << endl;
  }
  TheFile.close();
  TheCopy.close();
}

---

If i add "(|| str[i] == '. ')" to "if (str[i] == '.')" it's not working. Why?

Quote:

---

What i cant seem to find is how to uppercase after two characters like ". " (dot and space).

---

To get this right... what you're saying is that given input like:

Code:

---

hello
.world
123 abc
5678

---

You expect output like:

Code:

---

Hello
.World
123 Abc
5678

---

Is this correct?

Yes, exactly.
And i wanna do it by reading a string.
I can do it with a char ch; , but i wanna be able to do it with a string like in the example.
I wanna choose two characters like ". ." two dots for example and uppercase the letter that comes right after.

Quote:

---

And i wanna do it by reading a string.

---

Yes, it makes sense to read each line into a string.

Quote:

---

I wanna choose two characters like ". ." two dots for example and uppercase the letter that comes right after.

---

More generally, you want to find the first alphabetic character in the line, and make it uppercase. isalpha() from <cctype> can help you, but need will need to loop character by chararacter within the string, and break out of the loop as soon as you have used toupper() to change the character found.

EDIT:
Ah, but the find_first_of member function of std::string can help you do away with the character by character loop and the use of isalpha(), though at the cost of having to list the entire alphabet in both uppercase and lowercase.

Thanks for your answer but :
"More generally, you want to find the first alphabetic character in the line"
No, the proggie that i posted does this already.


The problem with "find_first_of" it checks only one character not a sequence of characters:

From http://www.cplusplus.com/reference/s..._first_of.html
"Notice that for a match to happen it is enough that one of the characters matches in the string (any of them). To search for an entire sequence of characters use find instead."

And "find" doesnt work with ifstream. Now you see where is my problem.

Quote:

---

No, the proggie that i posted does this already.

---

It does? If it does, then your problem has been solved. I think it does not.

Quote:

---

The problem with "find_first_of" it checks only one character not a sequence of characters:

---

What sequence of characters do you want to find?

Quote:

---

And "find" doesnt work with ifstream. Now you see where is my problem.

---

Recall that you have read the line into a string.

EDIT:
I have this feeling that you changed your requirements midway through this thread. You need to get your requirements straight if you want people to help you coherently.

I asked you if given this input:

Code:

---

hello
.world
123 abc
5678

---

You wanted this output:

Code:

---

Hello
.World
123 Abc
5678

---

You agreed. But you also wrote that: "I wanna choose two characters like ". ." two dots for example and uppercase the letter that comes right after."

So, you have a choice. Given this input:

Code:

---

hello
.world
123 abc
5678
..def
..ghi

---

Do you want:

Code:

---

hello
.world
123 abc
5678
..Def
..ghi

---

or

Code:

---

hello
.world
123 abc
5678
..Def
..Ghi

---

or

Code:

---

Hello
.World
123 Abc
5678
..Def
..Ghi

---

?

....

Quote:

---

Im gonna put it like this : i wanna find in a phrase two characters consecutive
( one beside the other , one right after the other , like for example i wanna find "ra":
you find "ra" in the word "phrase" and uppercase the letter right after "ra" which gives you :
phraSe. ) Do you get it now?

---

Ah. In this case, the find() member function of std::string is what you need. You have to learn how to handle the lack of the search string, but as mentioned you just compare the return value of find() with std::string::npos.

Quote:

---

And i said yes before when you showed me your example because i want my program to do different things
and for the other things you asked it can already do it.

---

That's good.

So you're saying that find() is working with ifstream, because just before you, Anon said it didnt
and if you check out the ifstream reference , there is no find() in it.
http://www.cplusplus.com/reference/iostream/ifstream/
Thanks!

Quote:

---

So you're saying that find() is working with ifstream, because just before you, Anon said it didnt
and if you check out the ifstream reference , there is no find() in it.

---

I'm not. I'm saying find() works with std::string, i.e., you need to read from the ifstream into a string. You are already doing this with your use of std::getline().

Cool. Thanks for clearing this up to me :-)

Ok i checked out find() but i must do something wrong

Code:

---

found=str.find('.');
        if (found!=string::npos)
        str = static_cast<char>( toupper((int(found))+1));
TheCopy << str << endl;

---

Maybe its the (int(found))+1).
How shall i tell it to the program that i want to use toupper() on the character after the found string?

Quote:

---

str = static_cast<char>( toupper((int(found))+1));

---

Do you have a concrete idea of why this would do what you want, or did you just write random code and hope it works?

Im afraid its the latter.

Well, the +1 shows you have an algorithm in mind, so +1 to you. However, what you're missing is that you want to make an character uppercase, but you never actually access the character (str[found+1]), and then you attempt to assign to a string (str), not a character. Of course, you also need to handle the case where the '.' is the last character, in which case there is no character to turn uppercase.

Thank you very much Laserlight , you're very nice and you teach me a lot!
I found it at last (with your help) and it's working. :)

Code:

---

found=str.find(". ");
        if (found!=string::npos)
        str[found+2] = static_cast<char>( toupper(str[found+2]));

---

As to the problem with the dot at the end of the line, actually what i want is to capitalize the
next line's first letter if the previous line ends with a dot.
That would look something like this: found=str.find(".\n");
and that works great with .get() but it doesnt wanna work with getline().
Im wondering why...

Because 1) getline() swallows the newline and probably 2) you read only one line at a time.

Ehem, that makes sense, thanks CornedBee!

If i use EOF as the delimiting character for istream::getline , will it read the whole file at once?

getline(TheFile,str,EOF)

If yes , will it still swallow the '\n' character?
Or anyway is it possible to do what i want with istream::getline (namely to detect the end of line in some way )
or shall i look for another method?
Cheers

EOF isn't necessarily a valid char value. You can't pass it to getline().

Ok i understand.
So maybe i have to go about it something like that:

Code:

---

while (!eof())
 {getline(TheFile,str,)}

---

That's simply a syntax error.

Or read() with a fixed buffer. It's considerably more efficient than scanning the stuff you read for newlines.

Another thing: see the FAQ for eof(). Never loop until eof() is true. If there's an I/O error, it won't ever be.

Thanks Cornedbee, you gave me the final solution!

I let alone getline() and i rewrite the whole program with read()

Code:

---

int main () {
  int length;
  char * str;
 
  cout << "Enter file name : ";
  string  FileName;
  cin >>  FileName;
  ifstream TheFile(FileName.c_str());
  ofstream TheCopy;
  TheCopy.open ("Your_Uppercased_Copy.srt",ios::app);
 
  // get length of file:
  TheFile.seekg (0, ios::end);
  length = TheFile.tellg();
  TheFile.seekg (0, ios::beg);

  // allocate memory:
  str = new char [length];

  // read data as a block:
  TheFile.read (str,length);
  TheFile.close();
  str[0] = static_cast<char>( toupper(str[0]));
  for(int i = 0; str[i]; i++)
          if (str[i] == '.'|| str[i] == '!'|| str[i] == '?')
              str[i+1] = static_cast<char>( toupper(str[i+1]));
  for(int j = 0; str[j]; j++)
          if (str[j] == '.'|| str[j] == '!'|| str[j] == '?')
          if (str[j+1] == '\n')
              str[j+2] = static_cast<char>( toupper(str[j+2]));
  for(int k = 0; str[k]; k++)
          if (str[k] == '.'|| str[k] == '!'|| str[k] == '?')
          if (str[k+1] == ' ')
              str[k+2] = static_cast<char>( toupper(str[k+2]));
         
              TheCopy.write (str,length);
  TheCopy.close();
  delete[] str;
  return 0;
}

---

You shouldn't use seekg() and tellg() with non-binary streams. You could get corrupted data on Windows.

Ok thanks, but if i add "ios::binary" it doesnt work.

ifstream TheFile(FileName.c_str(), ios::binary)

I know. The two simply don't mix. There's no fast way to determine how many characters there are in a file. Best thing seekg and tellg can do for you is give you a guideline for allocating, but you still need to be prepared for 1) getting less than that and b) getting more than that.