Problem with values changing

At first i would like to apologize for my bad English.

Second, i have a problem with my C++ program.
I have class

Code:

class Trena { public: string dromologia[6]; int thesis[3]; int kr_dr; int kr_thesis; int change; void initialize_t();

in a hyper class Metaforika

I set values to this with this code :

Code:

void Metaforika::Trena::initialize_t(){ dromologia[1] = "patra athina"; dromologia[2] = "patra pyrgos "; dromologia[3] = " patra thesalloniki"; dromologia[4] = " patra lianokladi"; dromologia[5] = "athina larisa"; thesis[1] = 6; thesis[2] = 12; thesis[3] = 0;

BUT when i try to change the values kr_dr, kr_thesis through a function, the cannot be changed.

Code:

void Metaforika::kratisi(int x,int y,int z){ Trena train; train.kr_dr =x; train.kr_thesis=y;

it gives me values of "424577" ( not exactly like this )

i've trying using a constructor

Code:

Metaforika::Trena::Trena(int y,int z) { kr_dr =y; kr_thesis=z; thesis[z]--;

but same thing happens.

Any help would be appreciated

Arrays start at index 0, and the item at index [array_size] is the first one out of bounds.

It is also possible that you are changing the values of a local and leaving the object you are interested in (member of Metaphorika?) uninitialized. You might post something more complete and be more careful with indexing arrays.

As you told me, i initialize kr_dr and kr_thesis.

Code:

void Metaforika::Trena::initialize_t(){ dromologia[1] = "patra athina"; dromologia[2] = "patra pyrgos "; dromologia[3] = " patra thesalloniki"; dromologia[4] = " patra lianokladi"; dromologia[5] = "athina larisa"; thesis[1] = 6; thesis[2] = 12; thesis[3] = 0; kr_dr=0; kr_thesis=0;

I have another class called Ploio.

THIS code give me the fault numbers.

Code:

void Metaforika::test() { Trena train; Ploa boat; train.initialize_t(); boat.initialize_p(); kratisi(1,2,2);

BUT if i call it from main

Code:

int main() { int i; Metaforika Meta; Meta.test(); Meta.kratisi(1,2,2); cin>> i; return(0);

the numbers fix. Thats the real problem i have i think.
The kratisi's function variables cannot be changed through another function but they can be changed through main . Is there something i'm missing?
eg. The array index problem doesn't matter because the value is always >0 [ i've created tha same program with structures and didn't have problem]

Your string array (if you want to store strings in your array), should be declared something like:

string dromologia[6][40];

Then you can assign a string to dromologia[0] and so on.

've fixed that but still, my problem is with numbers kr_dr and kr_thesis that dont really change. only in main the can be changed.
am i missing something?

I don't see where you are outputting any results, so how do you know the values are wrong?

But I do see that in kratisi you declare a local object and set its values. This object doesn't exist any longer once the function returns and is not the same object as the one with the same name in the calling code. May-be you want to set the values of this object, not a local?

Quote:

Originally Posted by kcpilot

Your string array (if you want to store strings in your array), should be declared something like:

string dromologia[6][40];

Then you can assign a string to dromologia[0] and so on.

This is wrong. std::string is not a char array.

Code:

cout << train.kr_dr<< endl;

i'm outputting the results, i thought it wasn't necessary to post it.

i declare an object of class Trena named train. Doesn't that suppose to change the values of the variables declared in the structure of the class.

example.

Code:

Class Metaforika { Class Trena { int c; void test(); }} void Metaforika::test() { Trena train; train.c =5; }

isn't that suppose to print 5 in train.c ? the int c; declared in the class.
I'm just talking theoretical so if i'm saying something wrong you can tell me.

Quote:

Originally Posted by patra_user

Code:

cout << train.kr_dr<< endl;

i'm outputting the results, i thought it wasn't necessary to post it.

i declare an object of class Trena named train. Doesn't that suppose to change the values of the variables declared in the structure of the class.

example.

Code:

Class Metaforika { Class Trena { int c; void test(); }} void Metaforika::test() { Trena train; // This is a LOCAL copy of class Trena. It disappears when the function returns. train.c =5; }

isn't that suppose to print 5 in train.c ? the int c; declared in the class.
I'm just talking theoretical so if i'm saying something wrong you can tell me.

See above comment in red.

--
Mats

OK. I think you've got that right.
What do i do to fix that?
Thank you guys.

Perhaps you'd like to have an instance of Trena as part of your Metaforika class?

--
Mats

Instance of trena in Metaforika Class

Code:

public: void kratisi(int x,int y,int z ); Trena train;

Constructor to set kr_dr , and kr_thesis
given values of y = 2 , z = 2

Code:

Metaforika::Trena::Trena(int y,int z) { kr_dr =y; kr_thesis=z; thesis[z]--; cout << y << " " << z;

Printing the values in the other function, the function that has problem

Code:

void Metaforika::kratisi(int x,int y,int z){ if (x==1) { Trena(y,z); cout << train.kr_dr<< endl; }}

OUTPUT

Code:

2 2 20898778896

still..

Quote:

Originally Posted by patra_user;697226
[CODE

void Metaforika::kratisi(int x,int y,int z){
if (x==1) {
Trena(y,z);
cout << train.kr_dr<< endl; }}
[/CODE]

Yes, because it should be:

Code:

void Metaforika::kratisi(int x,int y,int z){ if (x==1) { train(y,z); cout << train.kr_dr<< endl; }}

Your code just creates a temporar Train object that is never stored or used [it is created, then destroyed when the function is finished].

--
Mats

It gets me this error:

Quote:

no match for call to `(Metaforika::Trena) (int&, int&)'

i'm starting to be a pain in the ............sorry matsp.

what changes shall i do to this code?

Code:

Metaforika::Trena::Trena(int y,int z) {

Of course, that doesn't work. You need to have either a constructor to train() in your Metaforika constructor, or use a set function for your train component.

--
Mats

in my Metaforika constructor? How is that possible? My Metaforika constractor is just empty. I'm missing serious subjects here i think.

or the other way,
set function for my train component?

Quote:

Originally Posted by patra_user

in my Metaforika constructor? How is that possible? My Metaforika constractor is just empty. I'm missing serious subjects here i think.

or the other way,
set function for my train component?

Yes, create a member function of Trena that takes two variables, and pass in y, z to that function.

--
Mats

Member function of Trena

Code:

void fill_trena (int,int);

Code:

void Metaforika::kratisi(int x,int y,int z){ train.fill_trena(2,3); cout<<"inside kratisi: "; cout << train.kr_dr<< endl;

Ok so far : above code prints 2.

Code:

void Metaforika::Trena::fill_trena(int y, int z){ kr_dr=y; cout << endl << "function: " << y << endl;

Ok as well,above code prints 2.

Code:

void Metaforika::test() { Trena train; kratisi(1,2,2); cout<<"inside test-kratisi: "; cout << train.kr_dr<< endl;

Prints 0 !!

Quote:

Originally Posted by patra_user

Member function of Trena

Code:

void fill_trena (int,int);

Code:

void Metaforika::kratisi(int x,int y,int z){ train.fill_trena(2,3); cout<<"inside kratisi: "; cout << train.kr_dr<< endl;

Ok so far : above code prints 2.

Code:

void Metaforika::Trena::fill_trena(int y, int z){ kr_dr=y; cout << endl << "function: " << y << endl;

Ok as well,above code prints 2.

Code:

void Metaforika::test() { Trena train; kratisi(1,2,2); cout<<"inside test-kratisi: "; cout << train.kr_dr<< endl;

Prints 0 !!

The red part shouldn't be there - it creates a local copy of Trena, which isn't the one you want, and since it's local, it will "shadow" (or hide) the instance in your class itself.

--
Mats

AMEN!
Thanks a lot Mats.
You sure know how to program.

Quote:

Originally Posted by patra_user

AMEN!
Thanks a lot Mats.
You sure know how to program.

Ehm :blush:, yes, at least for simple stuff :)

--
Mats