warning: implicit declaration of function `sigset', `sighold' & `sigrelse'

OK, I almost have this thing building cleanly, but I'm seeing these warnings:

Code:

---

warning: implicit declaration of function `sigset'
warning: implicit declaration of function `sighold'
warning: implicit declaration of function `sigrelse'

---

Even though that .c file includes <signal.h>
Am I missing something, or does RedHat Enterprise 3.0 not support those functions?

http://linux.die.net/man/3/sigset lists a define.

Quote:

---

Originally Posted by robwhit

http://linux.die.net/man/3/sigset lists a define.

---

So I need to add this before including <signal.h>?

Code:

---

#define _XOPEN_SOURCE 500

---

presumably.

OK this is weird.
I added the #define _XOPEN_SOURCE 500 right before including <signal.h>, but it's still giving me those warnings.
What the hell???

Does it link correctly, if you ignore the warnings - not saying ignoring them is a good thing - but if you also get an error at the link phase with problems with the same symbold, I'd recommend that you replace the sigset, et.al. with the signal() et.al equivalents.

--
Mats

Hmm... After I moved the #include <signal.h> before any other #include, it worked.

Now I'm getting:

Code:

---

warning: passing arg 2 of `sigset' from incompatible pointer type

---

for the following 2 calls to sigset:

Code:

---

oldchld = (void(*)()) sigset(SIGCHLD, _sci_reaper_);
if (oldchld == SIG_ERR) {
        sprintf(prtbuf, "sigset call failed with errno %d", errno);
        sci_prt( prtbuf);
        oldchld = SIG_DFL;
}
oldterm = (void(*)()) sigset(SIGTERM, _sci_terminate_);
if (oldterm == SIG_ERR) {
        sprintf(prtbuf, "sigset call failed with errno %d", errno);
        sci_prt( prtbuf);
        oldterm = SIG_DFL;

---

_sci_reaper_ is defined as:

Code:

---

static void _sci_reaper_();

---

But sigset() is defined as:

Code:

---

typedef void (*sighandler_t)(int);
sighandler_t sigset(int sig, sighandler_t disp);

---

<sigh>
Should I add the int parameter to the _sci_reaper_ functions and just ignore it? What is the int used for? :confused:

Quote:

---

Originally Posted by cpjust

What is the int used for? :confused:

---

It holds the number of the signal which caused the handler to be invoked. It sounds useless until you realize that you can handle many different signals all with the same handler function.

OK, I'm totally buffudled, so I'm just gonna add the int parameter and ignore it.
I think this code it only used for the test harness anyways.

Quote:

---

Originally Posted by cpjust

OK, I'm totally buffudled, so I'm just gonna add the int parameter and ignore it.
I think this code it only used for the test harness anyways.

---

Don't be befuddled :-)

Imagine that you're handling the SIGINT signal and the SIGUSR1 signal both with the same handler function. How does this function know which signal it received? The signal number is in that integer.

Quote:

---

Originally Posted by brewbuck

Imagine that you're handling the SIGINT signal and the SIGUSR1 signal both with the same handler function. How does this function know which signal it received? The signal number is in that integer.

---

Yeah, I understand that part (sort of). But since the old code never did anything with that int, I'm guessing I don't need to worry about it either?
All those handler functions do is:

Code:

---

static void
_sci_reaper_()
{
        signalled++;
        while ( _sci_dowait_(0) )      /* non-blocking wait */
                ;
}

static void
_sci_terminate_()
{
        signalled++;
        if ( mypid == (PID_TYPE) 0 ) {
                shut_down = 2;
        }
}

---

The code as it stands should be OK, but if you ever run this on a system where the callee cleans the stack, then you'd have stack corruption because the function is called with a parameter but the function itself is not aware of this parameter. [This is a rather unlikely scenario as long as we are discussing normal Linux/Windows calls.

--
Mats

To get rid of the warning, I just added ( int i ) parameters to the functions and then didn't do anything else with them.