Including a custom class file

Hey,

I have two files. One is a class file that I created and the other file implements the class. I have a couple of questions concerning this.

First off, in my class file, do I need to include the class declaration and all the methods of the class? Right now my class file just looks like this:

Code:

---

class myStack {
   
    public:
        string (*aa);
        int stackSize;
        int cc;
        void setStackSize(int);
        void pop(int);
        void push(int);
        int displayStackSize();
};

---

The methods setStackSize, pop, and push are all written inside of my driver program.

Second, to include my class from my driver program, is the correct code:

Code:

---

#include "myStack"

---

or does it need a .c or a .h at the end? .h is only for header files, what is a .c? Does that just mean that it is written in C?

Thanks!

Your class file (header) should also have inclusion guards

Code:

---

#ifndef SOMETHING_H
#define SOMETHING_H

class YourClass {};

#endif

---

Google to see what inclusion guards are needed for.

To include the custom header files, use #include "myheader.h" (provided you have saved it with the ".h" extension). I don't think file extensions mean a lot per se - they're all simple text files after all - but certain programs, such as IDE's and compilers (?) use them to automatically figure out what kind of files these are.

By the way, what is

Code:

---

string (*aa);

---

?

If it is a string pointer, one conventionally wouldn't use the braces. But you probably don't need a pointer anyway.

And to use a string, the header should #include <string> and make sure the name is looked up in std namespace: it's std::string.

So can I put my class methods in the same file as the class? Or do I just define the class in one file and have the methods in the driver file? And then I would use #include myStack.cpp inside my driver file to include the class file if I saved it as myStack.cpp ?

the string (*aa) is a string pointer to an array.

edit: i've been reading more around this forum. Is this on the right track?

myStack.h - the class definition
myStack.cpp - the class methods, includes myStack.h
stackDriver.cpp - "drives" the program, includes myStack.cpp

Quote:

---

Originally Posted by Beowolf

So can I put my class methods in the same file as the class? Or do I just define the class in one file and have the methods in the driver file? And then I would use #include myStack.cpp inside my driver file to include the class file if I saved it as myStack.cpp ?

the string (*aa) is a string pointer to an array.

edit: i've been reading more around this forum. Is this on the right track?

myStack.h - the class definition
myStack.cpp - the class methods, includes myStack.h
stackDriver.cpp - "drives" the program, includes myStack.cpp

---

Almost, but you have to actually include myStack.h in your stackDriver.cpp file. It's a bit complicated ;)

QuantumPete

To confirm what QuantumPete says: It is almost never ever right to include a .cpp (or .c) file.

The idea is that you compile several .cpp files and combine them in a process called "linking". Header files (.h) are used to let each .cpp file know what functions, classes and variables are declared in other .cpp files, so that each .cpp file can make use of the other .cpp files functions.

--
Mats

Quote:

---

Originally Posted by matsp

It is almost never ever right to include a .cpp (or .c) file.

---

Though it does happen and those people need to be poked with a sharp stick.

To build on what matsp said:
Each .c(pp) file is compiled by itself. If you are using a function (or class, etc) that is defined in another .c file, then you don't have a definition for it in the current file and the compiler thinks it's undefined and has no code -> boom, compiler won't let you do that. If you include a declaration, however (such as you have in .h files, that's what they're there for), then you tell the compiler: 'hold on! I know the code for that function isn't in this file, but here's what it should look like and don't worry, the linker will find it'.
The linker then takes all your source files and puts them into a great big program (or library or whatever), whilst doing so, it searches all source files that are included for any functions that are undefined in a particular source file.
Since this not only applies to functions, but also to classes, basic types, etc, we generally refer to symbols.

Hope that's not *more* confusing now.

QuantumPete

Quote:

---

Originally Posted by QuantumPete

Though it does happen and those people need to be poked with a sharp stick.

---

Yes, I agree.

--
Mats

Ok, I broke my program down into three files, but I am getting some compiler errors. First, my files:

myStack.h

Code:

---

/* myStack.h */
#include <string>

class myStack
{
    public:
        string (*aa);
        int stackSize;
        int cc;
        void setStackSize(int);
        void pop(int);
        void push(int);
        int displayStackSize();
};

---

myStack.cpp

Code:

---

#include <iostream>
#include <string>
#include "myStack.h"

using namespace std;

void myStack::setStackSize(int x)
{

    stackSize = x;

    if(!(aa = new(nothrow) string[stackSize+1]))
        cerr << "Program cannot handle a stack of size " << stackSize << ".\n"; 
 
}


void myStack::pop(int p) {
    if(p == 0)
        cout << "Empty stack.\n";
    else
        cout << aa[p-1] << "\n";
}


void myStack::push(int p)
{
    if(p == stackSize)
    {
        cerr << "Full stack.\n";
    }
    else
    {
        aa[p] = aa[p].substr(1, aa[p].length());
        cc++;
    }
}

---

stackDriver.cpp

Code:

---

#include <iostream>
#include <string>
#include <ctype.h>
#include <stdlib.h>
#include "myStack.h"

using namespace std;

int main(int argc, char *argv[]) {
    myStack stack1;
    int arg_length;
    char current_digit;


    if(argc < 2) {
        cerr << "Bad command line argument.\n";
        exit(1);
    }

    arg_length = strlen(argv[1]);

    if(arg_length > 9) {
        cerr << "Bad command line argument.\n";
        exit(1);
    }
   
    for(int ii = 0; ii < arg_length; ii++) {
        current_digit = argv[1][ii];
        if(!(isdigit(current_digit))) {
            cerr << "Bad command line argument.\n";
            exit(1);
        }
    }

    stack1.setStackSize(atoi(argv[1]));

    stack1.cc = 0;
    while(1 != 2) { // infinite loop
        getline(cin, stack1.aa[stack1.cc]);
        if(stack1.aa[stack1.cc].length() > 80)
            cerr << "Bad input.\n";
        else if(stack1.aa[stack1.cc][0] == '<')
            stack1.pop(stack1.cc);
        else if(stack1.aa[stack1.cc][0] == '>')
            stack1.push(stack1.cc);
        else if(stack1.aa[stack1.cc].length() == 0)
            exit(0);
        else
            cerr << "Bad input.\n";
    }     
   

    system("Pause");
    return 0;
}

---

Sorry for the long code postings, but I thought you would probably want to see the whole thing. My compiler errors are this:

Code:

---

3 N:\USERS\bakewens\CS240\Program 2\myStack.cpp In file included from N:\USERS\bakewens\CS240\Program 2\myStack.cpp
7 N:\USERS\bakewens\CS240\Program 2\myStack.h ISO C++ forbids declaration of `string' with no type
7 N:\USERS\bakewens\CS240\Program 2\myStack.h expected `;' before '(' token

---

and then a lot more, but they all have to do with not having aa initialized, and that is because of the declaration of 'string' with no type error.

So, two questions: first, of course, what is the compiler complaining about "ISO C++ forbids a declaration of 'string' with no type'? What does that mean?

Second, is my file structure finally correct? :-p

Thanks for all of the help!

It should be:

Code:

---

std::string *aa;

---

which is actually what anon said in the first reply.

>> what is the compiler complaining about "ISO C++ forbids a declaration of 'string' with no type'?
Since you didn't specify the std namespace, the compiler didn't know what "string" was.

>> is my file structure finally correct?
You need header include guards in your header file (see anon's reply). Everything else looks fine.

Doh! Thanks.

I just compiled myStack.cpp again and the only thing that I received was this error that I have never seen before:

Code:

---

[Linker error] undefined reference to `WinMain@16'
ld returned 1 exit status

---

That is a linker error. Both myStack.cpp and stackDriver.cpp should be in the same project (are you using Dev-C++?).

If they're in the same project, both will be compiled and linked to each other, and the linker will find the main() function in stackDriver.cpp

If you try to run myStack.cpp by itself or have it in its own project, the linker will complain because you cannot create an executable without the main function.

Your compiler wants WinMain() instead of main().

>> Your compiler wants WinMain() instead of main().
I think it mentions WinMain even though it would be perfectly happy with a regular main. I might be wrong about this though.

If it does insist on a WinMain, then the project is wrong. You should be using a console application project, not a windows application project.

Yes, I am using Dev-C++.

I've put my three files in a project now. The structure is like:

Project1:
--main.cpp
--myStack.cpp
--myStack.h

I went to compile the project and now it is giving me this error:

Code:

---

1 N:\USERS\bakewens\CS240\Program 2\myStack.cpp expected unqualified-id before '[' token
1 N:\USERS\bakewens\CS240\Program 2\myStack.cpp expected `,' or `;' before '[' token

---

Code:

Code:

---

#include <iostream> //problem
#include <string>
#include "myStack.h"

using namespace std;

void myStack::setStackSize(int x)
[etc]

---

How does this whole project thing work when I want to run my program on another computer? For example, if I take my 3 files and want to compile them in another place that is not running Dev-C++, is it going to give me the WinMain error again?

I'm not sure why it gives you that error, is that the entire error text? Does it give you a line number or some other error message? Can you give more details on how you created the project?

As far as running on another computer, how you do it depends on what compiler or IDE is on the other computer. If you have Dev-C++ on the other computer, you can create a console project and add the files to it like you did here. There might be a project file that Dev-C++ creates and you can just copy that over, but I'm not familiar enough with Dev-C++ to know.

If you're using a different IDE or compiler, then you create a project or makefile or command line that is appropriate for that compiler. In VC++, you'd create an empty Win32 Console Application project and add the files to the project. If you're using gcc without an IDE, then you'd compile the two cpp files and link them together on the command line.

The full error message is:

Code:

---

1 N:\USERS\bakewens\CS240\Program 2\myStack.cpp expected unqualified-id before '[' token
1 N:\USERS\bakewens\CS240\Program 2\myStack.cpp expected `,' or `;' before '[' token
 N:\USERS\bakewens\CS240\Program 2\Makefile.win [Build Error]  [myStack.o] Error 1

---

The line number is 1.

The other computer will just be using gcc through a terminal window command prompt. How would you link them together on the command line?

I don't remember. Do a man gcc and it should give you the options you need. You might just need to compile them on the same line> g++ stackDriver.cpp myStack.cpp, but like I said I don't remember.

As to your current error, that's pretty strange. It's compiling as a C++ project? How did you create the project?

I just compiled it again and the error went away...I haven't changed anything :-\ Hmm!

I have a different question now: getline returns -1 on EOF, so an appropriate loop to read all of the contents of a file until the file is done would be this, correct?

Code:

---

while(getline(cin, stack1.aa[stack1.cc]) != -1) {

---

edit: i just compiled that and it gave me this error:

Code:

---

main.cpp no match for 'operator!=' in 'std::getline [with _CharT = char, _Traits = std::char_traits<char>, _Alloc = std::allocator<char>][lot more stuff]

---

but this is pretty much the same example as linuxmanpages.com has.

By the way, on Dev-C++, how do I include a file as my input stream and not the keyboard? I tried add "<inputFile.txt" in Parameters under Execute, but that didn't work. The dev-c++ site is not very helpful, either.

No, getline does not return -1 on EOF. If the read attempt fails, it will evaluate to false (that doesn't necessarily mean EOF, but that doesn't matter). So you should do this:

Code:

---

while(getline(cin, stack1.aa[stack1.cc])) {

---

Of course, that's not exactly how a stack usually works. Generally, you would read into a temporary variable and then call a Push function to push the value onto the stack.

Ok, thanks, it compiles now. Linuxmanpages.com says about getline:

Quote:

---

Both functions return -1 on failure to read a line (including end of file condition).

---

Oh well.

Any idea on to why I include "<testInput.txt" in the command line parameters the program does not read the file as the input stream and still waits for keyboard entry? My parameter list looks like this:

Code:

---

5 <testInput.txt

---

where 5 is the size of the stack, and I know that the file exists in the current working directory

That man page is for a completely different function that goes by the same name (notice the parameters are different than what you're using). I'd use a different reference for you C++ programming. Perhaps a book, or cppreference.com or dinkumware.com.

As for the redirect issue, I would expect that the end of the redirected file should cause the getline to stop running. Can you post your updated code?

Argh! That "expected unqualified-id before '[' token" is back for no apparent reason.

My new code:

main.cpp

Code:

---

#include <cstdlib>
#include <iostream>
#include <string>
#include <ctype.h>
#include <stdlib.h>
#include "myStack.h"

using namespace std;

int main(int argc, char *argv[]) {
    myStack stack1;
    int arg_length;
    char current_digit;


    if(argc < 2) {
        cerr << "Bad command line argument.\n";
        exit(1);
    }

    arg_length = strlen(argv[1]);

    if(arg_length > 9) {
        cerr << "Bad command line argument.\n";
        exit(1);
    }
   
    for(int ii = 0; ii < arg_length; ii++) {
        current_digit = argv[1][ii];
        if(!(isdigit(current_digit))) {
            cerr << "Bad command line argument.\n";
            exit(1);
        }
    }

    stack1.setStackSize(atoi(argv[1]));

    stack1.cc = 0;
    while(getline(cin, stack1.aa[stack1.cc])) {
        if(stack1.aa[stack1.cc].length() > 80)
            cerr << "Bad input.\n";
        else if(stack1.aa[stack1.cc][0] == '<')
            stack1.pop(stack1.cc);
        else if(stack1.aa[stack1.cc][0] == '>')
            stack1.push(stack1.cc);
        else if(stack1.aa[stack1.cc].length() == 0)
            exit(0);
        else
            cerr << "Bad input.\n";
    }     
   

    system("Pause");
    return 0;
}

---

myStack.cpp

Code:

---

#include <iostream>
#include <string>
#include "myStack.h"

using namespace std;

void myStack::setStackSize(int x)
{

    stackSize = x;

    if(!(aa = new(nothrow) string[stackSize+1]))
        cerr << "Program cannot handle a stack of size " << stackSize << ".\n"; 
 
}


void myStack::pop(int p) {
    if(p == 0)
    {
        cout << "Empty stack.\n";
    }
    else
    {
        cout << aa[p-1];
        cc--;
    }
}


void myStack::push(int p)
{
    if(p == stackSize)
    {
        cerr << "Full stack.\n";
    }
    else
    {
        aa[p] = aa[p].substr(1, aa[p].length());
        aa[p] += "\n";
        cc++;
    }
}

---

myStack.h

Code:

---

/* myStack.h */
#ifndef HEADER_H
#define HEADER_H
#include <string>

class myStack
{
    public:
        std::string (*aa);
        int stackSize;
        int cc;
        void setStackSize(int);
        void pop(int);
        void push(int);
        int displayStackSize();
};
#endif

---

And finally, post your input file.

Code:

---

<
>hello
<
>hi there
<

---

It works for me. This is the output I get:

Code:

---

D:\test\Debug>test.exe 5 <testInput.txt
Empty stack.
hello
hi there
Press any key to continue . . .

---

I'm using VC++ 7.1 and I run it from a command prompt.

I ran it through the command prompt and it worked fine, too. I guess it is just an issue with Dev-C++.

About the compile error that I get sometimes ("expected unqualified-id before '[' token"): when I get it and then I switch around the #include positioning in my file (for example just switch #include <iostream> down one) the error goes away for a while. Google has practically no results when I search about this.

Question, though: why do you include both <cstdlib> and <stdlib.h>? Also, you should use <cctype> instead of <ctype.h>.

I'm guessing the "expected unqualified-id before '[' token" error is just something wrong with your configuration, but who knows.

I could only run it from the command prompt as well. VC++ had issues with redirected input from its command-line settings.

Quote:

---

Originally Posted by CornedBee

Question, though: why do you include both <cstdlib> and <stdlib.h>? Also, you should use <cctype> instead of <ctype.h>.

---

Is including both cstdlib and stdlib repetitive? Is there a better choice to include one or the other, or does it not really matter which one I choose?

cstdlib is the true C++ header. It is defined to have the same contents as the C header stdlib.h, but with all elements except the macros declared inside namespace std, as everything in the standard library should be.
stdlib.h is the compatibility header. In addition to doing everything the cstdlib header does, it also imports all symbols of the header into the global one, so that programs written with the C header in mind continue to work.

So, in theory, cstdlib doesn't pollute your global namespace that much.

In practice, it is somewhat different: compilers tend to pack C and C++ in a single package, and there's hardly a difference between stdlib.h and cstdlib. cstdlib is often implemented by including stdlib.h and then importing the elements into the std namespace. This is, strictly speaking, non-conformant, because it pollutes the global namespace. In addition, I know that some compilers used to not present the symbols in the std namespace when stdlib.h was included - VC++6, for example, didn't.

However, in modern C++ programs you should include the cname versions of all the inherited headers, not the name.h versions.