open several files and execute?

I have an external .exe that will process a single file at a time. The problem is i have several hundreds of files to process, so i wanted to implement some code that allows me to loop an instruction for every file in a directory (all are named *.xyz).

Any sugestions please?
Thanks

how about a shell script?

Code:

---

FILES=`ls *.xyz`
for i in $FILES
do
  my_prog $i
done

---

QuantumPete
Edit: I just noticed the part about .exe - Are you running this on windows?

Quote:

---

Originally Posted by QuantumPete

how about a shell script?

Code:

---

FILES=`ls *.xyz`
for i in $FILES
do
  my_prog $i
done

---

QuantumPete

---

It`s a windows machine:(

Quote:

---

Originally Posted by autopilot

It`s a windows machine:(

---

/me scratches his head...
It's been aeons since I last wrote a batch script... Have a google...

QuantumPete

Quick google gave me this:

Code:

---

FOR %%c in (C:\windows\desktop\*.xyz) DO echo %%c

---

replace echo with your prog name, put the whole thing in a file with a .bat extension and let rip ;)

QuantumPete
Edit: Here's the website: http://home.att.net/~gobruen/progs/d...dos_batch.html

Quote:

---

Originally Posted by QuantumPete

Quick google gave me this:

Code:

---

FOR %%c in (C:\windows\desktop\*.xyz) DO echo %%c

---

replace echo with your prog name, put the whole thing in a file with a .bat extension and let rip ;)

QuantumPete
Edit: Here's the website: http://home.att.net/~gobruen/progs/d...dos_batch.html

---

Cool! Problem solved, thank you QuantumPete!

You can also use "explorer" to select a bunch of files and "open" them (either just hitting enter/double-clicking, or using "Open with..." by right-clicking on one of the selected files) - although this assumes that the application takes multiple inputs, rather than just a single file each time.

--
Mats

Quote:

---

Originally Posted by autopilot

Cool! Problem solved, thank you QuantumPete!

---

Found another problem...

Code:

---

FOR %%c in (C:\*.pc) DO normfet.exe %%c %%c.txt -nml

---

Won`t write anything to %%c.txt(i need the prefix of the original file on the output file). It works if the syntaxe is only "program infile outfile", but the "-nml" wont allow the write of the outfile, although the program runs fine.

Any ideas?

What's the -nml supposed to do?
Let's the part of your code, where you deal with the arguments

QuantumPete

Quote:

---

Originally Posted by QuantumPete

What's the -nml supposed to do?
Let's the part of your code, where you deal with the arguments

QuantumPete

---

the program is not mine (normfet.exe), i am using the executable only.
"-nml" is one instruction to the program. I run a similar batch script with other programs, it only fails with this one.

Have you tried putting the -nml at the beginning? Most programs expect their arguments first and then any other files

QuantumPete

Quote:

---

Originally Posted by QuantumPete

Have you tried putting the -nml at the beginning? Most programs expect their arguments first and then any other files

QuantumPete

---

Yes i tried changing the order but it errors out. What i think is strange is the fact that i can see that the "normfet.exe" is working but still nothing is written.

Put echo in front of normfat.exe and see whether the arguments that are printed to the screen are the ones that you'd expect.

Quote:

---

Originally Posted by QuantumPete

Put echo in front of normfat.exe and see whether the arguments that are printed to the screen are the ones that you'd expect.

---

Code:

---

Usage: Normfet.exe <infile> <outfile_prefix> [-nml | -bbr ...]

---

I wrote the following:

Code:

---

#include <stdio.h>
#include <string.h>

int main(int argc, char *argv[])
{
  char child1[] = "normfet.exe";
  char child2[BUFSIZ];
  char child3[BUFSIZ];
 
  // nome saida
  strcpy (child3, argv[1]);
  strcat (child3, "nm");

  strcpy (child2, child1);
  strcat (child2, " ");
  strcat (child2, argv[1]);
  strcat (child2, " ");
  strcat (child2, child3);
  strcat (child2, " -nml -ftr");
 
  printf ("Executing %s\n", child2);
  system (child2);
 
  return 0;
}

---

and then used the batch script with

Code:

---

FOR %%c in (C:\3d\*.xyz) DO tnormefet.exe %%c

---

but it errors out just before finishing. I guess there is nothing else to do, normfet.exe killed my plans.

Did you try putting 'echo' before normfet.exe in the batch file? Cos it says 'prefix' and I'm wondering whether the ouput file is correctly named.

QuantumPete

This is probably slightly clearer:

Code:

---

#include <stdio.h>
#include <string.h>

int main(int argc, char *argv[])
{
  char command_string[BUFSIZ] = {0};
  snprintf (command_string, "normfet.exe %s %snm -nml -ftr", argv[1], argv[1]);
 
  printf ("Executing %s\n", command_string);
  system (command_string);
 
  return 0;
}

---

QuantumPete

Quote:

---

Originally Posted by QuantumPete

This is probably slightly clearer

QuantumPete

---

Tried out your solution, it just opens the files (xyz) in notepad :confused:
I tried my last solution again, it does not error out: the output of the program is normal and the prefix of the input file is there and it ends it the nm (output file name). But again, nothing is written.

But no error happens now

Quote:

---

Originally Posted by autopilot

Tried out your solution, it just opens the files (xyz) in notepad :confused:
I tried my last solution again, it does not error out: the output of the program is normal and the prefix of the input file is there and it ends it the nm (output file name). But again, nothing is written.

But no error happens now

---

Wierd. But it works if you don't use the for loop, but run the normfet.exe for each file individually?

QuantumPete

When batch lets you down, use C :)

Code:

---

#include <windows.h>
#include <stdio.h>

int main(void)
{
    WIN32_FIND_DATA FindFileData;
    HANDLE hFind;
    char cmd[256];

    if((hFind = FindFirstFile(".\\*.xyz", &FindFileData)) == INVALID_HANDLE_VALUE)
    {
        puts("ABANDON SHIP, Y'ARRH");
        return 1;
    }

    do {
        if(strcmp(FindFileData.cFileName, ".") == 0 || strcmp(FindFileData.cFileName, "..") == 0)
            continue;

        sprintf(cmd, "normfet.exe &#37;s %snm -nml -ftr", FindFileData.cFileName, FindFileData.cFileName);
        if(CreateProcess(NULL, cmd, NULL, NULL, FALSE, NORMAL_PRIORITY_CLASS, NULL, NULL, NULL) != 0)
            printf("Run on %s...", FindFileData.cFileName);

    } while (FindNextFile(hFind, &FindFileData) != 0);

    FindClose(hFind);
    return 0;
}

---

Untested, Fix at will.

Quote:

---

Originally Posted by zacs7

When batch lets you down, use C :)
Untested, Fix at will.

---

21 C:\3d\teste.c too few arguments to function `CreateProcessA'

Stick a zero in front of NORMAL_PRIORITY_CLASS, I think.

I think Salem meant that "It's up to you to fix it".

--
Mats

Salem said what? :p

If you confused me with Salem, Either I'm getting pretty skilled, or you need glasses ;)

Again, if i run my program like this "tnormfet.exe 5.xyz" it calls norfet.exe and it works great and outputs the file(5.xyznw)
How would i change it to scan the files on a dir and automatically loop the program for all of them?

Code:

---

#include <stdio.h>
#include <string.h>

int main(int argc, char *argv[])
{
  char child1[] = "normfet.exe";
  char child2[BUFSIZ];
  char child3[BUFSIZ];
 
  // nome saida
  strcpy (child3, argv[1]);
  strcat (child3, "nw");

  strcpy (child2, child1);
  strcat (child2, " ");
  strcat (child2, argv[1]);
  strcat (child2, " ");
  strcat (child2, child3);
  strcat (child2, " -nml -ftr");
 
  printf ("Executing %s\n", child2);
  system (child2);
 
  return 0;
}

---

Quote:

---

Originally Posted by zacs7

Salem said what? :p

If you confused me with Salem, Either I'm getting pretty skilled, or you need glasses ;)

---

Ah, sorry, yes I got confused, and as I only tested my eyes for these glasses about 3 months ago, I think they are OK still (actually, only 2 weeks or so ago, they checked my eyesight for a medical test too, and that was OK too). Probably more bitrot in the RAM.

--
Mats

That's pretty much what mine does, just replace CreateProcess with system(), a little bit of speed shouldn't matter.

Quote:

---

Originally Posted by autopilot

Again, if i run my program like this "tnormfet.exe 5.xyz" it calls norfet.exe and it works great and outputs the file(5.xyznw)
How would i change it to scan the files on a dir and automatically loop the program for all of them?

---

By reading the FAQ perhaps?