strcmp help!!

my program crashes at the condition part

Code:

---

/* Reading from the script file */

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
#include <ctype.h>
//#include <iostream>
#include <string.h>

int main()
{
  FILE *myFile;
  char filename[20];

     
  /* Ask user to enter the filname including the format */
  printf( "Enter the script filename with the format. ie script.txt\n" );
  scanf( "&#37;s", filename  );
 
  /* Open filename for Reading (only) */
  myFile = fopen(filename, "r");
                if (myFile == NULL) {
                        printf("ERROR! Unable to open your file.\n"); 
            printf( "Closing file.......\n" ); 
            //delay two second
            sleep (2000);
                        exit(-1);
  }   
  /* Open file success message */
        else {
            printf( "The file %s is valid\n\n", filename );
}
           
           
    char string[500];
    fgets (string , 500 , myFile);

   
    char *tokenPtr;
    tokenPtr = strtok( string , " " );
      while ( tokenPtr != NULL ) {
      printf( "%s\n", tokenPtr );
      tokenPtr = strtok( NULL, " " );
}


    //EXE Crashes here
 if ( strcmp ( tokenPtr, "RESET" ) == 0 ){
      printf ("\n Resetting the motors.");
      //outportb(0x378, 0);
      }
     



  getch();
  return 0;
}

---

If the while loop preceding it doesn't end until tokenPtr is null, then what is tokenPtr when you pass it to strcmp?

It looks like you're compiling your C code with a C++ compiler as well.

In

Code:

---

    char *tokenPtr;
    tokenPtr = strtok( string , " " );
    while ( tokenPtr != NULL )
  {
      printf( "%s\n", tokenPtr );
      tokenPtr = strtok( NULL, " " );
    }

---

if it does not find SPACE or " ", tokenPtr will be NULL and hence in strcmp gets (NULL, RESET)...

it crashes after it prints out the the script from the file word by word

Code:

---

/* Reading from the script file */

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
#include <ctype.h>
//#include <iostream>
#include <string.h>
//#include "DLPORTIO.h"

int main()
{
  FILE *myFile;
  char filename[20];
  int time[10] = {1,2,3,4,5,6,7,8,9,10};
  char data[50];
  char *token;
           
           
  /* Ask user to enter the filname including the format */
  printf( "Enter the script filename with the format. ie script.txt\n" );
  scanf( "&#37;s", filename  );
 
  /* Open filename for Reading (only) */
  myFile = fopen(filename, "r");
                if (myFile == NULL) {
                        printf("ERROR! Unable to open your file.\n"); 
            printf( "Closing file in 2 seconds.......\n" ); 
            //delay two second
            sleep (2000);
                        exit(-1);
  }   
  /* Open file success message */
        else {
            printf( "The script file %s is being read....\n\n", filename );
}
           
    fgets (data , 50 , myFile);
   
    token = strtok( data , " " );
    while ( token != NULL )
  {
      printf( "%s\n", token );
      token = strtok( NULL, " " );
 
}
      //I GUESS IT CRASHES HERE?

      //token=toupper(token);
      if ( strcmp ( token, "RESET" )==0 ) {
          printf( "Resetting the motor ......");
      //outportb(0x378, 0x00);
      }
      else if ( strcmp ( token, "#" )== 0 ){
          printf( "Skipped..");
          sleep (500);
          exit(-1);
          }
      else if ( strcmp ( token, "FORWARD" )==0 ) {
          printf( "Moving forward.......");
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "REVERSE" )==1 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "PAUSE" )==1 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "HEADLIGHTS" )==1 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "TURNRIGHT" )==1 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "TURN LEFT" )==1 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "LOOP" )==1 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "ENDLOOP" )==1 ) {
      //outportb(0x378, 0x01);
          }
     
  getch();
  return 0;
}

---

http://www.open-std.org/jtc1/sc22/wg...rary_functions

Quote:

---

7.1.4 Use of library functions
1 Each of the following statements applies unless explicitly stated otherwise in the detailed descriptions that follow: If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined.

---

Are you not pretty much all but guaranteeing a crash in the best case?

Don't pass a null pointer to strcmp.

Quote:

---

Don't pass a null pointer to strcmp.

---

what kind of loop can i use so i can pass it to strcmp then?

I dunno. My crystal ball is out for cleaning and I can't visualize your input file or intentions.

A guess might be to put your if-tree in the loop instead of after it. But I'm not psychic either.

Perhaps learn to indent better?

Quote:

---

Originally Posted by Dave_Sinkula

I dunno. My crystal ball is out for cleaning and I can't visualize your input file or intentions.

A guess might be to put your if-tree in the loop instead of after it. But I'm not psychic either.

Perhaps learn to indent better?

---

sorry about the indent

purpose of the program is to read a script from a text file, then tokenize each word/number, then use strcmp to read the word/number that has been tokenized to outport parallel pins.

Well then take Dave_Sinkula's suggestion and put the if(strcmp()) inside the while loop, before the call to strtok(). Right after the printf() would be a good place.

Quote:

---

Originally Posted by dwks

Well then take Dave_Sinkula's suggestion and put the if(strcmp()) inside the while loop, before the call to strtok(). Right after the printf() would be a good place.

---

it works but it crashes
heres a screenshot
http://img362.imageshack.us/img362/2691/untitlednx5.jpg

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
#include <ctype.h>
//#include <iostream>
#include <string.h>
//#include "DLPORTIO.h"

int main()
{
  FILE *myFile;
  char filename[20];
  int time[10] = {1,2,3,4,5,6,7,8,9,10};
  char data[50];
  char *token;
           
           
  /* Ask user to enter the filname including the format */
  printf( "Enter the script filename with the format. ie script.txt\n" );
  scanf( "%s", filename  );
 
  /* Open filename for Reading (only) */
  myFile = fopen(filename, "r");
                if (myFile == NULL) {
                        printf("ERROR! Unable to open your file.\n"); 
            printf( "Closing file in 2 seconds.......\n" ); 
            //delay two second
            sleep (2000);
                        exit(-1);
        }   
  /* Open file success message */
        else {
            printf( "The script file %s is being read....\n\n", filename );
        }
           
  /* Reading data from script file */ 
    fgets (data , 50 , myFile);
    token = strtok( data , " " );
   
  /* Looping the token for output until it's null(empty) */
    while ( token != NULL )
  {
      printf( "%s\n", token );
     
      if ( strcmp ( token, "RESET" )==0 ) {
          printf( "Resetting the motor ......");
      //outportb(0x378, 0x00);
      }
      else if ( strcmp ( token, "#" )== 0 ){
          printf( "Skipped..");
          sleep (500);
          exit(-1);
      }
      else if ( strcmp ( token, "FORWARD" )==0 ) {
          printf( "Moving forward.......");
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "REVERSE" )==0 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "PAUSE" )==0) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "HEADLIGHTS" )==0 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "TURNRIGHT" )==0 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "TURN LEFT" )==0 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "LOOP" )==0 ) {
      //outportb(0x378, 0x01);
          }
      else if ( strcmp ( token, "ENDLOOP" )==0 ) {
      //outportb(0x378, 0x01);
      }
     
      // Ends when the script file is null
      token = strtok( NULL, " " );
}
     

      printf( "\n Press any key to end program....." );
      getch();
      return 0;
}

---

Quote:

---

Originally Posted by apm

it works but it crashes

---

Maybe it doesn't know what to do with getch?

thanks for the help! i decided to make new a new txt for the heck of it and it doesn't crash anymore, strange.

3 more things to do until my program is complete

- make the script uppercase right when the script has been tokenized so my condition will work, i tried to use toupper but it gives me error

Code:

---

token=toupper(token);

aa.c:41: warning: passing arg 1 of `toupper' makes integer from pointer without a cast
aa.c:41: warning: assignment makes pointer from integer without a cast

---

- how do i make it so that if a line in the script file starts with a symbol ie "#, $" then it skips the whole line?




- if a line starts with a LOOP command and follow by a number 2 then i have to make a loop about this command 2 times, instead other lines are just "FORWARD 2" How do i do this?
example

Code:

---

LOOP 3
        FORWARD 2
        Headlights ON
        Pause 2
        RESET
EndLoop

---

vs.

Code:

---

Forward 3

---

hope someone can help me here!

thanks

Quote:

---

Originally Posted by apm

- make the script uppercase right when the script has been tokenized so my condition will work, i tried to use toupper but it gives me error

Code:

---

token=toupper(token);

aa.c:41: warning: passing arg 1 of `toupper' makes integer from pointer without a cast
aa.c:41: warning: assignment makes pointer from integer without a cast

---

---

toupper operates on a single character, not a string. You can write a trivial function to do a whole string.

Quote:

---

Originally Posted by apm

- how do i make it so that if a line in the script file starts with a symbol ie "#, $" then it skips the whole line?

---

Check the first character, ignore the rest of the line.

Quote:

---

Originally Posted by apm

- if a line starts with a LOOP command and follow by a number 2 then i have to make a loop about this command 2 times, instead other lines are just "FORWARD 2" How do i do this?
example

Code:

---

LOOP 3
        FORWARD 2
        Headlights ON
        Pause 2
        RESET
EndLoop

---

vs.

Code:

---

Forward 3

---

---

For now, work on the first two.

Quote:

---

Originally Posted by Dave_Sinkula

toupper operates on a single character, not a string. You can write a trivial function to do a whole string.

Check the first character, ignore the rest of the line.

For now, work on the first two.

---

1. strupr( token ); worked like a charm

2. actually if i can just make condition in which if they see symbol they'll just print out ignore line. It would be an escape, except if a line is like "# FORWARD"

3. i presume that i have to make conditions within the condition but i'm kinda stuck