Collecting text and putting in string

Hey!

This time, I'm trying to collect the text (ALL text) from a text file, and put it in a string that I can print out later. Here's what I've come up with:

Code:

---

#include <iostream.h>
#include <stdio.h>
#include <fstream.h>

using namespace std;

string InfoCollectDataHolder;

class ParseText
{
    public:
        ParseText();
        ~ParseText();
        void Parse();
    protected:
        string InfoCollectDataHolder;
};

ParseText::ParseText()
{

}

ParseText::~ParseText()
{

}

void ParseText::Parse()
{
    ifstream FileToParse("InfoCollect.txt");
    while (FileToParse)
    {
        getline (FileToParse, InfoCollectDataHolder);
    }
    FileToParse.close();
}

int main()
{
    ParseText ParseExample;
    ParseExample.Parse();
    cout<<InfoCollectDataHolder;
    cin.get();
}

---

Hmm... doesn't seem to work right.
Can somebody show me the err's of my ways? :)

Thanks for your help!
FlyingIsFun1217

You repeat to read into the same string and never store that string anywhere.
Kurt

Sorry, you're going to have to dumb that down some :(

FlyingIsFun1217 :)

---------

Sorry, I think I see what you mean...

FlyingIsFun1217...

Read each line into a buffer string and then append it to InfoCollectDataHolder:

Code:

---

string s;

while ( getline( FileToParse, s ) ) {
  InfoCollectDataHolder += s;
}

---

This is a cool way to read a whole file in one shot too:

Code:

---

#include <iostream>
#include <fstream>
#include <string>
#include <sstream>


using namespace std;


int main() {
  ifstream ifs( "test.txt" );

  if ( ifs ) {
    ostringstream oss;
    string s;

    oss << ifs.rdbuf();

    s = oss.str();

    cout << s;
  }
}

---

Removed the while loop, kept the contents. Still nothing.

Thanks again!
FlyingIsFun1217

Noir's second suggestion works perfectly, modify that to fit your needs.

Will do :)
Thanks everybody! I'll probably be back :P

FlyingIsFun1217

Code:

---

#include <iostream>
#include <stdio.h>
#include <fstream>
#include <sstream>

using namespace std;

string InfoCollectDataHolder;

class ParseText
{
    public:
        ParseText();
        ~ParseText();
        void Parse();
    protected:
        string InfoCollectDataHolder;
};

ParseText::ParseText()
{

}

ParseText::~ParseText()
{

}

void ParseText::Parse()
{
    ifstream FileToParse("InfoCollect.txt");
    if (FileToParse)
    {
        ostringstream oss;

        oss << FileToParse.rdbuf();

        InfoCollectDataHolder = oss.str();
    }
}

int main()
{
    ParseText ParseExample;
    ParseExample.Parse();
    cout<<InfoCollectDataHolder;
    cin.get();
}

---

This seems to not work either...
Does it matter that I'm using Linux? I'm kinda new to developing on the platform, but I wouldn't think that there's anything to stop it from working right... :/

FlyingIsFun1217

Code:

---

#include <iostream>
#include <stdio.h>
#include <fstream>
#include <sstream>

using namespace std;

string InfoCollectDataHolder;

class ParseText
{
    public:
        ParseText();
        ~ParseText();
        void Parse();
    protected:
        string InfoCollectDataHolder;
};

ParseText::ParseText()
{

}

ParseText::~ParseText()
{

}

void ParseText::Parse()
{
   
      ifstream FileToParse("InfoCollect.txt");
    if (FileToParse)
    {
        ostringstream oss;

        oss << FileToParse.rdbuf();

        InfoCollectDataHolder = oss.str();
        cout<<InfoCollectDataHolder;
    }
    }

int main()
{
    ParseText ParseExample;
    ParseExample.Parse();
    cin.get();
}

---

Code:

---

InfoCollectDataHolder

---

You have two of them.
You are reading into ParseExample.InfoCollectDataHolder and printing the global one.
Kurt

Quote:

---

Originally Posted by Oldman47

Code:

---

#include <iostream>
#include <stdio.h>
#include <fstream>
#include <sstream>

using namespace std;

string InfoCollectDataHolder;

class ParseText
{
    public:
        ParseText();
        ~ParseText();
        void Parse();
    protected:
        string InfoCollectDataHolder;
};

ParseText::ParseText()
{

}

ParseText::~ParseText()
{

}

void ParseText::Parse()
{
   
      ifstream FileToParse("InfoCollect.txt");
    if (FileToParse)
    {
        ostringstream oss;

        oss << FileToParse.rdbuf();

        InfoCollectDataHolder = oss.str();
        cout<<InfoCollectDataHolder;
    }
    }

int main()
{
    ParseText ParseExample;
    ParseExample.Parse();
    cin.get();
}

---

---

Hmm... Not working for me. You got it to work?

ZuK, I see what you mean. Whoops! Forgot to delete that... :P

FlyingIsFun1217
----------------------------------------------
Seems after deleting the class member InfoCollectDataHolder string, I still just get the same results. Shouldn't the class be using the global string and the main function read it too?

Thanks again!
FlyingIsFun1217

The code I posted worked fine. Maybe add #include <string> and I'd also add some code to handle a file error (perhaps your opening of the file is failing) since you have no idea as to whether or not that's occuring. As a test, simply assign some text to your string;

Code:

---

void ParseText::Parse()
{
   
      ifstream FileToParse("InfoCollect.txt");
    if (FileToParse.good())
      {
              ostringstream oss;

              oss << FileToParse.rdbuf();

            InfoCollectDataHolder = oss.str();

      }

        else if(FileToParse.bad())
          {
            InfoCollectDataHolder= "This is a test of the emergency code system....";
          }
 
        cout<<InfoCollectDataHolder;
    }
    }

---

Yep. Seems it's something with the text file:

Code:

---

void ParseText::Parse()
{
    ifstream FileToParse("InfoCollect.txt");

    if (FileToParse)
    {
        ostringstream oss;

        oss << FileToParse.rdbuf();

        InfoCollectDataHolder = oss.str();
    }

    else
    {
        InfoCollectDataHolder = "Sorry, couldn't open file...";
    }

    cout<<InfoCollectDataHolder;
}

---

Is this maybe something with linux having permissions on the text file (I know thats kinda off topic, but...)? I have it set to read and write for all users... :/

FlyingIsFun1217

I don't know jack about Linux. Salem could probably answer that .....

Where is Salem? I havn't seen him around much... Although thats not saying anything, because I havn't been around lately...

FlyingIsFun1217