Need help in my SDL window

>///< i feel like a noob having trouble in SDL but
i get an error In function `int SDL_main(int, char**)':
`void SDL_Quit()' cannot appear in a constant-expression
Makefile.win [Build Error] [window.o] Error 1

Code:

---

int main(int argc, char *argv[])
{
 
  if(SDL_Init(SDL_INIT_VIDEO) < 0) {
  fprintf(stderr, "Unable to init SDL: %s\n", SDL_GetError());
  exit(1);
  }
  SDL_Surface *screen;
 
  screen = SDL_SetVideoMode(SCREEN_WIDTH,SCREEN_HEIGHT,SCREEN_BPP,SDL_SWSURFACE);
  if(screen == NULL)
  {
      printf("Unable to set video mode:%s\n",SDL_GetError());
      exit(1);
}

  SDL_WM_SetCaption("Justin's game",0);
 {
  SDL_Event event;
 
  SDL_WaitEvent(&event);
 
        switch(event.type)
        {
          case SDL_KEYDOWN:
            printf("The %s key was pressed!\n",
                  SDL_GetKeyName(event.key.keysym.sym));
            break;
            case SDL_Quit:
                exit(0);
        }
 
} 
 
 
 
}

---

oohh i didn't add the includes up in that copy but there cstdlib,cstdio, SDL.h, and the defines for WIDTH,HEIGHT, and BPP :P

Never mind i found the problem it was case SDL_QUIT instead of SDL_Quit XD idiot me

The only problem now is that that window instantly closes

I think you need a variable for the 'game loop'. Declare a variable like:

bool quit = false;

Then put your event handling in a loop that checks whether quit is still false.

Code:

---

while (quit == false)
{
 SDL_WaitEvent(&event);
 
        switch(event.type)
        {
          case SDL_KEYDOWN:
            printf("The %s key was pressed!\n",
                  SDL_GetKeyName(event.key.keysym.sym));
            break;
            case SDL_Quit:
                quit = true;
        }
}

---

Note how I've changed your SDL_Quit case.

Quote:

---

Note how I've changed your SDL_Quit case.

---

You didn't:

Code:

---

case SDL_Quit:

---

It should be SDL_QUIT as mentioned. :)

BTW, you should be calling SDL_Quit() when your program exits. Often this is done by calling

Code:

---

atexit(SDL_Quit);

---

Code:

---

SDL_WM_SetCaption("<EDITED>'s game",0);

---

Try not to put that kind of thing on the internet. Now we all know your real name is. At least it's not your full name and phone number . . .

Quote:

---

Originally Posted by dwks

BTW, you should be calling SDL_Quit() when your program exits. Often this is done by calling

Code:

---

atexit(SDL_Quit);

---

---

That's considered bad SDL programming practise. Read the SDL Tutorials section of the SDL documentation for why, as I don't remember ;)

Quote:

---

Originally Posted by kawk

Try not to put that kind of thing on the internet. Now we all know your real name is [---]. At least it's not your full name and phone number . . .

---

Try not to make posts like that, so that if the OP decides to edit his or her post, it's not recorded in your post.

Quote:

---

That's considered bad SDL programming practise. Read the SDL Tutorials section of the SDL documentation for why, as I don't remember ;)

---

There's nothing wrong with it AFAIK; it's actually in the tutorials. (That having been said, I never use it myself. :) )

Quote:

---

There's nothing wrong with it AFAIK; it's actually in the tutorials. (That having been said, I never use it myself. )

---

According to the SDL 1.2.9 tutorials, it's "fine for small applications, but should not be used in larger programs". I imagine it's because if your program has crashed so badly that you have corrupted the loaded SDL libraries (Which I _have_ done, BTW) and you try to call SDL_Quit . . . well, lets just say it's not pretty.