ReadFile() Putting Trash in Buffer

Hey,

I had made a simple window using the Forgers tutorials. Now I'm making a program that needs a window, but its in c++ rather then c (as the tutorials are). I was able to fix all of the problems except one when I converted the code, and it is in the readfile() function.

Anyway, after messing with it for a while and reading th documentation in it, I got it to compile:

Code:

---

void LoadTextFileToEdit(HWND hEdit, HWND window, LPCTSTR pszFileName)
{
    LPCTSTR  lpBuffer;
    LPDWORD dwNumRead;
    DWORD size;
   
    size = sizeof(DWORD)*256;
    dwNumRead = &size;
   
    ReadFile(&pszFileName, &lpBuffer, size, dwNumRead,NULL);
    SetWindowText(window, pszFileName);
    SetWindowText(hEdit, lpBuffer);
}

---

This code will run but the contents of the file is not being read into lpBuffer, or at least not properly, because when I open a file it spits out stuff like:
‹ÿU‹ìSV‹uW¿

I know that the problem is me messing around with code I don't really understand, but if it's not too much trouble could you point out the problem.

Thanks,
David

Well, the first parm to ReadFile should be a HANDLE for an open file not the file name. You should always check your return codes.

Code:

---

BOOL LoadFile( LPSTR pszFileName)
{
    HANDLE hFile;
    BOOL bSuccess = FALSE;

    hFile = CreateFile(pszFileName, GENERIC_READ, FILE_SHARE_READ, NULL,
        OPEN_EXISTING, NULL, NULL);
    if(hFile != INVALID_HANDLE_VALUE)
    {
        DWORD dwFileSize;
        dwFileSize = GetFileSize(hFile, NULL);
        if(dwFileSize != 0xFFFFFFFF)
        {
            LPSTR pszFileText;
            pszFileText =(LPSTR) GlobalAlloc(GPTR, dwFileSize + 1);
            if(pszFileText != NULL)
            {
                DWORD dwRead;
                if(ReadFile(hFile, pszFileText, dwFileSize, &dwRead, NULL))
                {
                    pszFileText[dwFileSize] = 0; // Null terminator
                    bSuccess = TRUE; // It actually worked!!!!
                }
                GlobalFree(pszFileText);
            }
        }
        CloseHandle(hFile);
    }
    return bSuccess;
}

---

Yeah, I actaully forgot to do createfile(). Thanks.

I'm getting an error that doesn't make much since now:
147 ld returned 1 exit status

147 is the create file function:

Code:

---

hFile = CreateFile(pszFileName, GENERIC_READ, FILE_SHARE_READ, NULL,
        OPEN_EXISTING, NULL, NULL);

---

EDIT: ^Disregard, it was a spelling mistake.

And thanks again.